Fossil Forum
Post: "Error: login failed" on sync is easy to miss
On editing users server-side (including myself), I think Firefox's password manager updated users with my own without being apparent to myself. This caused the login to fail for other users.
In the terminal, the login failure is easy to miss as it's surrounded by other lines that are repeated all the time and therefore easy to pass over. It took me a few minutes to see the problem.
Eg:
Sync with https://[email protected]/Repo/ Round-trips: 1 Artifacts sent: 0 received: 0 Error: login failed Round-trips: 1 Artifacts sent: 0 received: 0 Sync done, wire bytes sent: 1150 received: 314 remote: 10.0.0.1
As much as I dislike color spam, it might help if this was in red, and probably at the end of the message instead of the middle.
I have an alternative suggestion: get rid of the chatty statistics output (unless the --verbose option is in effect). Then by default there's no output unless an error occurs, just like the Unix tradition.
Except the --verbose option is already taken and does increase the chatty statistics considerably, depending on how many round trips there are.
The default output isn't "chatty" in my opinion, except when there are failures. Notice that all the Round-trips are written on one line, so the typical normal output is 3 lines:
$ fossil pull Pull from https://[email protected]/home Round-trips: 4 Artifacts sent: 0 received: 24 Pull done, wire bytes sent: 2752 received: 81034 remote: 194.195.208.62
If you ever see more than 3 lines, it's likely that there was an error. I wouldn't exactly call that "chatty statistics" for a network oriented program. Is it any more "chatty" than scp?
probably at the end of the message instead of the middle.
I too definitely don't like color spam, however, I'm not opposed to a Warning at the end of the sync to help users look for the reason. How about something like:
https://fossil-scm.org/home/info/cae9c9085879e1fa
Also, there is already a Warning if you commit and there are errors during autosync so this isn't too different.
We have recent evidence that adding more output simply results in more ignored output.
And then, what's next?
$ echo "X"
X
WARNING: The last command printed something to the screen, please see above and read it!
No, really! I think somebody with the technical skills to use Fossil should be able to spot an error message in a handful of screen lines!
And: "warning, there's errors" sounds a bit ... I don't know. Maybe it's just me having a bad day :(
Stepping the error lines in a few spaces might make then more easily spotted.
Sync with https://[email protected]/Repo/ Round-trips: 1 Artifacts sent: 0 received: 0 Error: login failed Round-trips: 1 Artifacts sent: 0 received: 0 Sync done, wire bytes sent: 1150 received: 314 remote: 10.0.0.1