Fossil Forum
Post: duplicate header "History of ..." with default skin in wiki page history
- switch to "default" skin
- go to https://fossil-scm.org/home/whistory?name=Apache+On+Windows+XP
- see the duplicate header "History of ..."
- switch to Etienne skin
- go to https://fossil-scm.org/home/whistory?name=Apache+On+Windows+XP
- see only one header
is this known and will this be fixed or will the new default skin be Etienne in the longterm? because I wanted to created a custom skin based on the current ones but would like to base it on the official standard skin which should be most used / maintained?
will the new default skin be Etienne in the longterm?
Other way around. Étienne is the old default, renamed in honor of its creator to allow the new default to take the name. Étienne persists as the default the official Fossil repos apparently because drh doesn't like whitespace. (Only partly joking.) After I merged this new default skin to trunk, he added a feature that let a site declare a different skin other than "default" for visitors who hadn't made an explicit skin selection in support of this.
I've been content to switch the Fossil sites back to this new "default" on my own browsers, and naturally so, since I developed it to my own tastes. I think it's a shame more people don't get to see my work until they instantiate a repo of their own and see the new default, but… 🤷♂️
is this known
It's on-purpose. Back during the development of the new default, I was convinced to move the title — which was up in the header in Étienne — down into the body so that a wiki/embedded doc page without headers didn't look like it was indented to no good purpose. This at least gave you a top-level header in the body, under which all else was indented.
If you pay attention to your own example, you will see that there is a duplication on that page with Étienne as well, up at the top of the page, after the big "Fossil / " header bits. The only thing that differs between these two skins on that point is how close the two duplicates are.
which should be most used / maintained?
As should now be plain, there are advocates for both. Which one will get more attention will come down to who wants to put time into their favored skin. I don't see that one is going to die off in favor of the other.
Perhaps the single most relevant action item here is, why does /whistory put a copy of the title in the body itself? Shouldn't it leave that to the skin, regardless of which one is selected?
Z 4095107f4671f4e1
Perhaps the single most relevant action item here is, why does /whistory put a copy of the title in the body itself?
In this particular case it sets the first one with style_header() and then emits a second header of its own which contains a hyperlink to the page in question. Presumably, though i've not confirmed this, we can't pass the hyperlink through style_header() without it getting HTML-escaped along its way to the skin's preferred spot. Assuming that's the case, we just need to find a suitable spot on the page for the current link to the wiki page, then can remove that second header. If we can indeed pass the link through style_header(), that would be ideal here.