Fossil SCM
The setup_settings page now only opens a checkout if no explicit repo was provided, to avoid it showing versioned properties from a different repo. Problem reported on the ML.
Commit
0ab00799595231fa5a5884efe37c71037eb63624
Parent
e05a74f1f471272…
1 file changed
+5
-1
+5
-1
| --- src/setup.c | ||
| +++ src/setup.c | ||
| @@ -1331,11 +1331,15 @@ | ||
| 1331 | 1331 | login_needed(); |
| 1332 | 1332 | } |
| 1333 | 1333 | |
| 1334 | 1334 | (void) aCmdHelp; /* NOTE: Silence compiler warning. */ |
| 1335 | 1335 | style_header("Settings"); |
| 1336 | - db_open_local(0); | |
| 1336 | + if(!g.repositoryOpen){ | |
| 1337 | + /* Provide read-only access to versioned settings, | |
| 1338 | + but only if no repo file was explicitly provided. */ | |
| 1339 | + db_open_local(0); | |
| 1340 | + } | |
| 1337 | 1341 | db_begin_transaction(); |
| 1338 | 1342 | @ <p>This page provides a simple interface to the "fossil setting" command. |
| 1339 | 1343 | @ See the "fossil help setting" output below for further information on |
| 1340 | 1344 | @ the meaning of each setting.</p><hr /> |
| 1341 | 1345 | @ <form action="%s(g.zTop)/setup_settings" method="post"><div> |
| 1342 | 1346 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -1331,11 +1331,15 @@ | |
| 1331 | login_needed(); |
| 1332 | } |
| 1333 | |
| 1334 | (void) aCmdHelp; /* NOTE: Silence compiler warning. */ |
| 1335 | style_header("Settings"); |
| 1336 | db_open_local(0); |
| 1337 | db_begin_transaction(); |
| 1338 | @ <p>This page provides a simple interface to the "fossil setting" command. |
| 1339 | @ See the "fossil help setting" output below for further information on |
| 1340 | @ the meaning of each setting.</p><hr /> |
| 1341 | @ <form action="%s(g.zTop)/setup_settings" method="post"><div> |
| 1342 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -1331,11 +1331,15 @@ | |
| 1331 | login_needed(); |
| 1332 | } |
| 1333 | |
| 1334 | (void) aCmdHelp; /* NOTE: Silence compiler warning. */ |
| 1335 | style_header("Settings"); |
| 1336 | if(!g.repositoryOpen){ |
| 1337 | /* Provide read-only access to versioned settings, |
| 1338 | but only if no repo file was explicitly provided. */ |
| 1339 | db_open_local(0); |
| 1340 | } |
| 1341 | db_begin_transaction(); |
| 1342 | @ <p>This page provides a simple interface to the "fossil setting" command. |
| 1343 | @ See the "fossil help setting" output below for further information on |
| 1344 | @ the meaning of each setting.</p><hr /> |
| 1345 | @ <form action="%s(g.zTop)/setup_settings" method="post"><div> |
| 1346 |