Fossil SCM
Fixed bug in the new code setting up the timeline, forgot to clean up loop state, causing data from previous iterations to bleed into the current one, causing the use of bogus data and ultimatively a bogus timeline. Note! Incidentially a bug in the old code was fixed by the new one, the use of mismatching revisions and commit messages. That caused the generation of extra changesets in the old code.
Commit
10e3b3ed76e73022adc76b5e98f0c28133b51c4e
Parent
2740b48b6323093…
2 files changed
+6
+1
-1
+6
| --- tools/lib/cvs.tcl | ||
| +++ tools/lib/cvs.tcl | ||
| @@ -188,10 +188,16 @@ | ||
| 188 | 188 | NoteDeadRoots $f $rev $operation |
| 189 | 189 | timeline::add $date($rev) $f $rev $operation $auth($rev) $cmsg($rev) |
| 190 | 190 | incr n |
| 191 | 191 | } |
| 192 | 192 | #B Extend branch management |
| 193 | + | |
| 194 | + unset md | |
| 195 | + unset date | |
| 196 | + unset auth | |
| 197 | + unset cmsg | |
| 198 | + unset stat | |
| 193 | 199 | } |
| 194 | 200 | |
| 195 | 201 | write 0 cvs "Generated [NSIPL $n entry entries]" |
| 196 | 202 | return |
| 197 | 203 | } |
| 198 | 204 |
| --- tools/lib/cvs.tcl | |
| +++ tools/lib/cvs.tcl | |
| @@ -188,10 +188,16 @@ | |
| 188 | NoteDeadRoots $f $rev $operation |
| 189 | timeline::add $date($rev) $f $rev $operation $auth($rev) $cmsg($rev) |
| 190 | incr n |
| 191 | } |
| 192 | #B Extend branch management |
| 193 | } |
| 194 | |
| 195 | write 0 cvs "Generated [NSIPL $n entry entries]" |
| 196 | return |
| 197 | } |
| 198 |
| --- tools/lib/cvs.tcl | |
| +++ tools/lib/cvs.tcl | |
| @@ -188,10 +188,16 @@ | |
| 188 | NoteDeadRoots $f $rev $operation |
| 189 | timeline::add $date($rev) $f $rev $operation $auth($rev) $cmsg($rev) |
| 190 | incr n |
| 191 | } |
| 192 | #B Extend branch management |
| 193 | |
| 194 | unset md |
| 195 | unset date |
| 196 | unset auth |
| 197 | unset cmsg |
| 198 | unset stat |
| 199 | } |
| 200 | |
| 201 | write 0 cvs "Generated [NSIPL $n entry entries]" |
| 202 | return |
| 203 | } |
| 204 |
+1
-1
| --- tools/lib/cvs_timeline.tcl | ||
| +++ tools/lib/cvs_timeline.tcl | ||
| @@ -19,11 +19,11 @@ | ||
| 19 | 19 | # ----------------------------------------------------------------------------- |
| 20 | 20 | # API Implementation |
| 21 | 21 | |
| 22 | 22 | proc ::vc::cvs::ws::timeline::add {date file revision operation author cmsg} { |
| 23 | 23 | variable timeline |
| 24 | - lappend timeline($date) [list $file $revision $operation $author $cmsg] | |
| 24 | + lappend timeline($date) [list $file $revision $operation $author $cmsg] | |
| 25 | 25 | return |
| 26 | 26 | } |
| 27 | 27 | |
| 28 | 28 | proc ::vc::cvs::ws::timeline::foreach {dv fv rv ov av cv script} { |
| 29 | 29 | upvar 1 $dv date $fv file $rv revision $ov operation $av author $cv cmsg |
| 30 | 30 |
| --- tools/lib/cvs_timeline.tcl | |
| +++ tools/lib/cvs_timeline.tcl | |
| @@ -19,11 +19,11 @@ | |
| 19 | # ----------------------------------------------------------------------------- |
| 20 | # API Implementation |
| 21 | |
| 22 | proc ::vc::cvs::ws::timeline::add {date file revision operation author cmsg} { |
| 23 | variable timeline |
| 24 | lappend timeline($date) [list $file $revision $operation $author $cmsg] |
| 25 | return |
| 26 | } |
| 27 | |
| 28 | proc ::vc::cvs::ws::timeline::foreach {dv fv rv ov av cv script} { |
| 29 | upvar 1 $dv date $fv file $rv revision $ov operation $av author $cv cmsg |
| 30 |
| --- tools/lib/cvs_timeline.tcl | |
| +++ tools/lib/cvs_timeline.tcl | |
| @@ -19,11 +19,11 @@ | |
| 19 | # ----------------------------------------------------------------------------- |
| 20 | # API Implementation |
| 21 | |
| 22 | proc ::vc::cvs::ws::timeline::add {date file revision operation author cmsg} { |
| 23 | variable timeline |
| 24 | lappend timeline($date) [list $file $revision $operation $author $cmsg] |
| 25 | return |
| 26 | } |
| 27 | |
| 28 | proc ::vc::cvs::ws::timeline::foreach {dv fv rv ov av cv script} { |
| 29 | upvar 1 $dv date $fv file $rv revision $ov operation $av author $cv cmsg |
| 30 |