Fossil SCM
The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive.
Commit
2aaee4841e0f7587538dd19791466f1bea35e43ecb9adfef457bd383f0d2929b
Parent
024305978f53f9f…
1 file changed
+2
+2
| --- test/tester.tcl | ||
| +++ test/tester.tcl | ||
| @@ -550,10 +550,12 @@ | ||
| 550 | 550 | # |
| 551 | 551 | # Be sure to adhere to the requirements of run_in_checkout! |
| 552 | 552 | proc test_block_in_checkout { name rscript {tscript ""} } { |
| 553 | 553 | if {$::outside_fossil_repo} { |
| 554 | 554 | puts "Skipping $name test: not in Fossil repo checkout." |
| 555 | + set $::CODE 0 | |
| 556 | + set $::RESULT "" | |
| 555 | 557 | } else { |
| 556 | 558 | run_in_checkout $rscript |
| 557 | 559 | if {[string length $tscript] == 0} { |
| 558 | 560 | return "" |
| 559 | 561 | } else { |
| 560 | 562 |
| --- test/tester.tcl | |
| +++ test/tester.tcl | |
| @@ -550,10 +550,12 @@ | |
| 550 | # |
| 551 | # Be sure to adhere to the requirements of run_in_checkout! |
| 552 | proc test_block_in_checkout { name rscript {tscript ""} } { |
| 553 | if {$::outside_fossil_repo} { |
| 554 | puts "Skipping $name test: not in Fossil repo checkout." |
| 555 | } else { |
| 556 | run_in_checkout $rscript |
| 557 | if {[string length $tscript] == 0} { |
| 558 | return "" |
| 559 | } else { |
| 560 |
| --- test/tester.tcl | |
| +++ test/tester.tcl | |
| @@ -550,10 +550,12 @@ | |
| 550 | # |
| 551 | # Be sure to adhere to the requirements of run_in_checkout! |
| 552 | proc test_block_in_checkout { name rscript {tscript ""} } { |
| 553 | if {$::outside_fossil_repo} { |
| 554 | puts "Skipping $name test: not in Fossil repo checkout." |
| 555 | set $::CODE 0 |
| 556 | set $::RESULT "" |
| 557 | } else { |
| 558 | run_in_checkout $rscript |
| 559 | if {[string length $tscript] == 0} { |
| 560 | return "" |
| 561 | } else { |
| 562 |