Fossil SCM

Fix a bug introduced with [e0198213f3]: using "style.visibility" is essential to calculate the dimensions in the hidden state.

florian 2019-05-21 09:40 UTC tooltip-experiments
Commit 3850b32ceae21d5fb4f36f6c3e1932daa4a98c21f3643c0cdba832b0b4055451
1 file changed +4 -1
+4 -1
--- src/graph.js
+++ src/graph.js
@@ -593,17 +593,20 @@
593593
var hbr = br.replace(/&/g, "&")
594594
.replace(/</g, "&lt;")
595595
.replace(/>/g, "&gt;")
596596
.replace(/"/g, "&quot;")
597597
.replace(/'/g, "&#039;");
598
+ /* Setup while hidden, to ensure proper dimensions. */
599
+ tooltipObj.style.visibility = "hidden"
598600
tooltipObj.innerHTML = "<a href=\""+dest+"\">"+hbr+"</a>"
601
+ tooltipObj.style.display = "inline"
599602
tooltipObj.style.position = "absolute"
600603
var x = posX + 4 + window.pageXOffset
601604
tooltipObj.style.left = x+"px"
602605
var y = posY + window.pageYOffset - tooltipObj.clientHeight - 4
603606
tooltipObj.style.top = y+"px"
604
- tooltipObj.style.display = "inline"
607
+ tooltipObj.style.visibility = "visible"
605608
}
606609
}
607610
function dblclickOnGraph(e){
608611
var ix = findTxIndex(e);
609612
var dest = branchHyperlink(ix)
610613
--- src/graph.js
+++ src/graph.js
@@ -593,17 +593,20 @@
593 var hbr = br.replace(/&/g, "&amp;")
594 .replace(/</g, "&lt;")
595 .replace(/>/g, "&gt;")
596 .replace(/"/g, "&quot;")
597 .replace(/'/g, "&#039;");
 
 
598 tooltipObj.innerHTML = "<a href=\""+dest+"\">"+hbr+"</a>"
 
599 tooltipObj.style.position = "absolute"
600 var x = posX + 4 + window.pageXOffset
601 tooltipObj.style.left = x+"px"
602 var y = posY + window.pageYOffset - tooltipObj.clientHeight - 4
603 tooltipObj.style.top = y+"px"
604 tooltipObj.style.display = "inline"
605 }
606 }
607 function dblclickOnGraph(e){
608 var ix = findTxIndex(e);
609 var dest = branchHyperlink(ix)
610
--- src/graph.js
+++ src/graph.js
@@ -593,17 +593,20 @@
593 var hbr = br.replace(/&/g, "&amp;")
594 .replace(/</g, "&lt;")
595 .replace(/>/g, "&gt;")
596 .replace(/"/g, "&quot;")
597 .replace(/'/g, "&#039;");
598 /* Setup while hidden, to ensure proper dimensions. */
599 tooltipObj.style.visibility = "hidden"
600 tooltipObj.innerHTML = "<a href=\""+dest+"\">"+hbr+"</a>"
601 tooltipObj.style.display = "inline"
602 tooltipObj.style.position = "absolute"
603 var x = posX + 4 + window.pageXOffset
604 tooltipObj.style.left = x+"px"
605 var y = posY + window.pageYOffset - tooltipObj.clientHeight - 4
606 tooltipObj.style.top = y+"px"
607 tooltipObj.style.visibility = "visible"
608 }
609 }
610 function dblclickOnGraph(e){
611 var ix = findTxIndex(e);
612 var dest = branchHyperlink(ix)
613

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button