Fossil SCM

Reverted the text size for Pikchr diagrams to the old 0.9em to match hard-coded assumptions in pikchr.c. See the checked-in comment for the alternative solutions considered and rejected.

wyoung 2024-01-27 11:44 inskinerator-modern-backport
Commit 39368cdfbd7a5d683b05620366ad870820d2a201db4b18b1ff0eb922681beb7f
1 file changed +14
--- skins/default/css.txt
+++ skins/default/css.txt
@@ -258,10 +258,24 @@
258258
margin-left: 70pt;
259259
margin-right: 50pt;
260260
}
261261
262262
.content .pikchr-wrapper {
263
+ /* Pikchr was developed with the assumption that it would be
264
+ * integrated into a Fossil repo using the old 0.9em body font
265
+ * size, which no longer obtians. This gives us a choice:
266
+ *
267
+ * 1. Change Pikchr to track this skin change, potentially breaking
268
+ * uses of alternate skins with differing default font sizes.
269
+ * 2. Restore the old default for Pikchr diagrams so the old
270
+ * assumptions continue to be valid.
271
+ * 3. Make everyone with custom skins set pikchr-scale=1.11 (1/0.9)
272
+ * in their skin's footer.txt to increase the diagram's relative
273
+ * size to compensate for the font size change.
274
+ *
275
+ * We choose #2 because it puts both adjustments in the same file. */
276
+ font-size: 0.9em;
263277
margin-left: 70pt;
264278
}
265279
div.pikchr-wrapper.center:not(.source) {
266280
margin-left: 0;
267281
}
268282
--- skins/default/css.txt
+++ skins/default/css.txt
@@ -258,10 +258,24 @@
258 margin-left: 70pt;
259 margin-right: 50pt;
260 }
261
262 .content .pikchr-wrapper {
 
 
 
 
 
 
 
 
 
 
 
 
 
 
263 margin-left: 70pt;
264 }
265 div.pikchr-wrapper.center:not(.source) {
266 margin-left: 0;
267 }
268
--- skins/default/css.txt
+++ skins/default/css.txt
@@ -258,10 +258,24 @@
258 margin-left: 70pt;
259 margin-right: 50pt;
260 }
261
262 .content .pikchr-wrapper {
263 /* Pikchr was developed with the assumption that it would be
264 * integrated into a Fossil repo using the old 0.9em body font
265 * size, which no longer obtians. This gives us a choice:
266 *
267 * 1. Change Pikchr to track this skin change, potentially breaking
268 * uses of alternate skins with differing default font sizes.
269 * 2. Restore the old default for Pikchr diagrams so the old
270 * assumptions continue to be valid.
271 * 3. Make everyone with custom skins set pikchr-scale=1.11 (1/0.9)
272 * in their skin's footer.txt to increase the diagram's relative
273 * size to compensate for the font size change.
274 *
275 * We choose #2 because it puts both adjustments in the same file. */
276 font-size: 0.9em;
277 margin-left: 70pt;
278 }
279 div.pikchr-wrapper.center:not(.source) {
280 margin-left: 0;
281 }
282

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button