Fossil SCM
Fix bad url on "Advanced"/"Basic" link of the timeline page. The zLink argument of style_submenu_element() should be a literal "%s", otherwise, encoded url parameter value may contain "%" and get corrupt by the vmprintf() call inside. Problem was happening when clicking on "Basic/Advanced" link on this page: http://www.fossil-scm.org/index.html/timeline?advm=1&chng=src/*
Commit
3c2ef25d03fb48d532badb0cba2843de24c1b19f75da27b4b9f0ab0a1fc70349
Parent
e07fdbc51e6e9b8…
1 file changed
+2
-2
+2
-2
| --- src/timeline.c | ||
| +++ src/timeline.c | ||
| @@ -2019,13 +2019,13 @@ | ||
| 2019 | 2019 | } |
| 2020 | 2020 | if( search_restrict(SRCH_CKIN)!=0 ){ |
| 2021 | 2021 | style_submenu_element("Search", "%R/search?y=c"); |
| 2022 | 2022 | } |
| 2023 | 2023 | if( advancedMenu ){ |
| 2024 | - style_submenu_element("Basic", url_render(&url, "advm", "0", 0, 0)); | |
| 2024 | + style_submenu_element("Basic", "%s", url_render(&url, "advm", "0", 0, 0)); | |
| 2025 | 2025 | }else{ |
| 2026 | - style_submenu_element("Advanced", url_render(&url, "advm", "1", 0, 0)); | |
| 2026 | + style_submenu_element("Advanced", "%s", url_render(&url, "advm", "1", 0, 0)); | |
| 2027 | 2027 | } |
| 2028 | 2028 | if( PB("showid") ) tmFlags |= TIMELINE_SHOWRID; |
| 2029 | 2029 | if( useDividers && zMark && zMark[0] ){ |
| 2030 | 2030 | double r = symbolic_name_to_mtime(zMark); |
| 2031 | 2031 | if( r>0.0 ) selectedRid = timeline_add_divider(r); |
| 2032 | 2032 |
| --- src/timeline.c | |
| +++ src/timeline.c | |
| @@ -2019,13 +2019,13 @@ | |
| 2019 | } |
| 2020 | if( search_restrict(SRCH_CKIN)!=0 ){ |
| 2021 | style_submenu_element("Search", "%R/search?y=c"); |
| 2022 | } |
| 2023 | if( advancedMenu ){ |
| 2024 | style_submenu_element("Basic", url_render(&url, "advm", "0", 0, 0)); |
| 2025 | }else{ |
| 2026 | style_submenu_element("Advanced", url_render(&url, "advm", "1", 0, 0)); |
| 2027 | } |
| 2028 | if( PB("showid") ) tmFlags |= TIMELINE_SHOWRID; |
| 2029 | if( useDividers && zMark && zMark[0] ){ |
| 2030 | double r = symbolic_name_to_mtime(zMark); |
| 2031 | if( r>0.0 ) selectedRid = timeline_add_divider(r); |
| 2032 |
| --- src/timeline.c | |
| +++ src/timeline.c | |
| @@ -2019,13 +2019,13 @@ | |
| 2019 | } |
| 2020 | if( search_restrict(SRCH_CKIN)!=0 ){ |
| 2021 | style_submenu_element("Search", "%R/search?y=c"); |
| 2022 | } |
| 2023 | if( advancedMenu ){ |
| 2024 | style_submenu_element("Basic", "%s", url_render(&url, "advm", "0", 0, 0)); |
| 2025 | }else{ |
| 2026 | style_submenu_element("Advanced", "%s", url_render(&url, "advm", "1", 0, 0)); |
| 2027 | } |
| 2028 | if( PB("showid") ) tmFlags |= TIMELINE_SHOWRID; |
| 2029 | if( useDividers && zMark && zMark[0] ){ |
| 2030 | double r = symbolic_name_to_mtime(zMark); |
| 2031 | if( r>0.0 ) selectedRid = timeline_add_divider(r); |
| 2032 |