Fossil SCM

Add some links to improve navigation between attachments and their target. Experimentally use a collapsed DETAILS element for attachment lists in forum post to save some UI clutter.

stephan 2026-06-04 16:50 UTC attach-v2

Commit 48445daff04eb47fc333149b20b6fe85de0c60ca1d0082b1dd053bf7508a75a5

Parent 4a0be8d60443d58…

5 files changed +41 -8 +4 +8 -1 +14 -7 +6 -1

~ src/attach.c ~ src/default.css ~ src/event.c ~ src/forum.c ~ src/tkt.c

M src/attach.c

+41 -8

		--- src/attach.c
		+++ src/attach.c
		@@ -215,20 +215,21 @@
215	215	** At most one of technote=, tkt=, forumpost=, or page= may be supplied.
216	216	**
217	217	** If none are given, all attachments are listed. If one is given, only
218	218	** attachments for the designated technote, ticket or wiki page are shown.
219	219	**
220		-** HASH may be just a prefix of the relevant technical note or ticket
221		-** artifact hash, in which case all attachments of all technical notes or
222		-** tickets with the prefix will be listed. Forum posts, on the other hand,
223		-** require a unique hash prefix.
	220	+** HASH may be just a prefix of the relevant forum post, technical
	221	+** note, or ticket artifact hash, in which case all attachments of all
	222	+** technical notes or tickets with the prefix will be listed. Forum
	223	+** posts, on the other hand, require a unique hash or hash prefix.
224	224	*/
225	225	void attachlist_page(void){
226	226	const char *zPage = P("page");
227	227	const char *zTkt = P("tkt");
228	228	const char *zTechNote = P("technote");
229	229	const char *zForumPost = P("forumpost");
	230	+ char *zLink = 0;
230	231	Blob sql;
231	232	Stmt q;
232	233
233	234	if( zPage && zTkt ) zTkt = 0;
234	235	login_check_credentials();
		@@ -248,32 +249,47 @@
248	249	if( fnid<=0 ){
249	250	webpage_error("Invalid forum post ID: %h", zForumPost);
250	251	}
251	252	blob_append_sql(&sql, " WHERE target="
252	253	"(SELECT uuid FROM blob WHERE rid=%d)", fnid);
	254	+ zLink = mprintf("forum post <a href='%R/forumpost/%t'>%#h</a>",
	255	+ zForumPost, hash_digits(0), zForumPost);
253	256	}else if( zPage ){
254	257	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
255	258	style_header("Attachments To Wiki page %h", zPage);
256	259	blob_append_sql(&sql, " WHERE target=%Q", zPage);
	260	+ zLink = mprintf("wiki page <a href='%R/wiki?name=%t'>%h</a>",
	261	+ zPage, zPage);
257	262	}else if( zTkt ){
258	263	if( g.perm.RdTkt==0 ){ login_needed(g.anon.RdTkt); return; }
259	264	style_header("Attachments To Ticket %S", zTkt);
260	265	blob_append_sql(&sql, " WHERE target GLOB '%q*'", zTkt);
	266	+ zLink = mprintf("ticket <a href='%R/tktview?name=%t'>%#h</a>",
	267	+ zTkt, hash_digits(0), zTkt);
261	268	}else if( zTechNote ){
262	269	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
263	270	style_header("Attachments To Tech Note %S", zTechNote);
264	271	blob_append_sql(&sql, " WHERE target GLOB '%q*'",
265	272	zTechNote);
	273	+ zLink = mprintf("tech-note <a href='%R/technote?name=%t'>%#h</a>",
	274	+ zTechNote, hash_digits(0), zTechNote);
266	275	}else{
267	276	if( g.perm.RdTkt==0 && g.perm.RdWiki==0 ){
268	277	login_needed(g.anon.RdTkt \|\| g.anon.RdWiki);
269	278	return;
270	279	}
271	280	style_header("All Attachments");
272	281	}
273	282	blob_append_sql(&sql, " ORDER BY mtime DESC");
274	283	db_prepare(&q, "%s", blob_sql_text(&sql));
	284	+
	285	+ if( zLink ){
	286	+ @ <h2>Attachments for %s(zLink)</h2>
	287	+ fossil_free(zLink);
	288	+ zLink = 0;
	289	+ }
	290	+
275	291	@ <ol>
276	292	while( db_step(&q)==SQLITE_ROW ){
277	293	const char *zDate;
278	294	const char *zSrc;
279	295	const char *zTarget;
		@@ -954,11 +970,11 @@
954	970	zTarget = db_text(0, "SELECT substr(tagname,7) FROM tag"
955	971	" WHERE tagname GLOB 'event-%q*'", zTarget);
956	972	if( zTarget==0) fossil_redirect_home();
957	973	}
958	974	zTo = zFrom ? 0 : mprintf("%R/technote?name=%T", zTarget);
959		- zTargetType = mprintf("Tech Note <a href=\"%R/technote/%s\">%S</a>",
	975	+ zTargetType = mprintf("Tech-note <a href=\"%R/technote/%s\">%S</a>",
960	976	zTarget, zTarget);
961	977	noJsArgs[1] = zTarget;
962	978	break;
963	979	}
964	980	case CFTYPE_TICKET:{
		@@ -984,11 +1000,11 @@
984	1000	}
985	1001	if( !db_exists("SELECT 1 FROM tag WHERE tagname='wiki-%q'", zTarget) ){
986	1002	fossil_redirect_home();
987	1003	}
988	1004	zTo = zFrom ? 0 : mprintf("%R/wiki?name=%T", zTarget);
989		- zTargetType = mprintf("Wiki Page <a href=\"%R/wiki?name=%h\">%h</a>",
	1005	+ zTargetType = mprintf("Wiki page <a href=\"%R/wiki?name=%h\">%h</a>",
990	1006	zTarget, zTarget);
991	1007	noJsArgs[3] = zTarget;
992	1008	break;
993	1009	}
994	1010	}
		@@ -1306,10 +1322,12 @@
1306	1322	*/
1307	1323	#define ATTACHLIST_HRULE_ABOVE 0x01 /* Insert <hr> above header */
1308	1324	#define ATTACHLIST_TARGET_BLANK 0x02 /* use target=_blank for links */
1309	1325	#define ATTACHLIST_SIZE 0x04 /* add size */
1310	1326	#define ATTACHLIST_HIDE_UNAPPROVED 0x08 /* Hide pending-moderation files */
	1327	+#define ATTACHLIST_DETAILS_CLOSED 0x10 /* Wrap in a closed DETAILS element */
	1328	+#define ATTACHLIST_DETAILS_OPEN 0x20 /* Wrap in an open DETAILS element */
1311	1329	#endif
1312	1330
1313	1331	/*
1314	1332	** Output HTML to show a list of attachments.
1315	1333	*/
		@@ -1320,11 +1338,14 @@
1320	1338	){
1321	1339	int cnt = 0;
1322	1340	char szBuf[36] = {0}; /* scratchpad for attachment size value */
1323	1341	const char *zLinkTgt = (ATTACHLIST_TARGET_BLANK & flags)
1324	1342	? " target=\"_blank\"" : "";
	1343	+ const int bUseDetail = flags &
	1344	+ (ATTACHLIST_DETAILS_CLOSED \| ATTACHLIST_DETAILS_OPEN);
1325	1345	Stmt q;
	1346	+
1326	1347	db_prepare(&q,
1327	1348	"SELECT datetime(mtime,toLocal()), a.filename, a.user,"
1328	1349	" b1.uuid, a.src, a.target, a.attachid, b2.size\n"
1329	1350	" FROM attachment a, blob b1, blob b2\n"
1330	1351	" WHERE a.isLatest\n"
		@@ -1350,15 +1371,27 @@
1350	1371	&& moderation_pending(aid)
1351	1372	&& !moderation_user_could(aid, 1, 0) ){
1352	1373	continue;
1353	1374	}
1354	1375	if( cnt==0 ){
1355		- @ <section class='attachlist'>
	1376	+ if( bUseDetail ){
	1377	+ @ <details class='attachlist'
	1378	+ if( ATTACHLIST_DETAILS_OPEN & flags ){
	1379	+ @ open
	1380	+ }
	1381	+ @ >
	1382	+ }else{
	1383	+ @ <section class='attachlist'>
	1384	+ }
1356	1385	if( flags & ATTACHLIST_HRULE_ABOVE ){
1357	1386	@ <hr>
1358	1387	}
1359		- @ %s(zHeader)
	1388	+ if( bUseDetail ){
	1389	+ @ <summary>%s(zHeader)</summary>
	1390	+ }else{
	1391	+ @ %s(zHeader)
	1392	+ }
1360	1393	@ <ul>
1361	1394	}
1362	1395	cnt++;
1363	1396	switch( attachment_target_type(zTarget, 1) ){
1364	1397	case CFTYPE_TICKET: zTypeArg = "tkt"; break;
1365	1398

	--- src/attach.c
	+++ src/attach.c
	@@ -215,20 +215,21 @@
215	** At most one of technote=, tkt=, forumpost=, or page= may be supplied.
216	**
217	** If none are given, all attachments are listed. If one is given, only
218	** attachments for the designated technote, ticket or wiki page are shown.
219	**
220	** HASH may be just a prefix of the relevant technical note or ticket
221	** artifact hash, in which case all attachments of all technical notes or
222	** tickets with the prefix will be listed. Forum posts, on the other hand,
223	** require a unique hash prefix.
224	*/
225	void attachlist_page(void){
226	const char *zPage = P("page");
227	const char *zTkt = P("tkt");
228	const char *zTechNote = P("technote");
229	const char *zForumPost = P("forumpost");

230	Blob sql;
231	Stmt q;
232
233	if( zPage && zTkt ) zTkt = 0;
234	login_check_credentials();
	@@ -248,32 +249,47 @@
248	if( fnid<=0 ){
249	webpage_error("Invalid forum post ID: %h", zForumPost);
250	}
251	blob_append_sql(&sql, " WHERE target="
252	"(SELECT uuid FROM blob WHERE rid=%d)", fnid);


253	}else if( zPage ){
254	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
255	style_header("Attachments To Wiki page %h", zPage);
256	blob_append_sql(&sql, " WHERE target=%Q", zPage);


257	}else if( zTkt ){
258	if( g.perm.RdTkt==0 ){ login_needed(g.anon.RdTkt); return; }
259	style_header("Attachments To Ticket %S", zTkt);
260	blob_append_sql(&sql, " WHERE target GLOB '%q*'", zTkt);


261	}else if( zTechNote ){
262	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
263	style_header("Attachments To Tech Note %S", zTechNote);
264	blob_append_sql(&sql, " WHERE target GLOB '%q*'",
265	zTechNote);


266	}else{
267	if( g.perm.RdTkt==0 && g.perm.RdWiki==0 ){
268	login_needed(g.anon.RdTkt \|\| g.anon.RdWiki);
269	return;
270	}
271	style_header("All Attachments");
272	}
273	blob_append_sql(&sql, " ORDER BY mtime DESC");
274	db_prepare(&q, "%s", blob_sql_text(&sql));







275	@ <ol>
276	while( db_step(&q)==SQLITE_ROW ){
277	const char *zDate;
278	const char *zSrc;
279	const char *zTarget;
	@@ -954,11 +970,11 @@
954	zTarget = db_text(0, "SELECT substr(tagname,7) FROM tag"
955	" WHERE tagname GLOB 'event-%q*'", zTarget);
956	if( zTarget==0) fossil_redirect_home();
957	}
958	zTo = zFrom ? 0 : mprintf("%R/technote?name=%T", zTarget);
959	zTargetType = mprintf("Tech Note <a href=\"%R/technote/%s\">%S</a>",
960	zTarget, zTarget);
961	noJsArgs[1] = zTarget;
962	break;
963	}
964	case CFTYPE_TICKET:{
	@@ -984,11 +1000,11 @@
984	}
985	if( !db_exists("SELECT 1 FROM tag WHERE tagname='wiki-%q'", zTarget) ){
986	fossil_redirect_home();
987	}
988	zTo = zFrom ? 0 : mprintf("%R/wiki?name=%T", zTarget);
989	zTargetType = mprintf("Wiki Page <a href=\"%R/wiki?name=%h\">%h</a>",
990	zTarget, zTarget);
991	noJsArgs[3] = zTarget;
992	break;
993	}
994	}
	@@ -1306,10 +1322,12 @@
1306	*/
1307	#define ATTACHLIST_HRULE_ABOVE 0x01 /* Insert <hr> above header */
1308	#define ATTACHLIST_TARGET_BLANK 0x02 /* use target=_blank for links */
1309	#define ATTACHLIST_SIZE 0x04 /* add size */
1310	#define ATTACHLIST_HIDE_UNAPPROVED 0x08 /* Hide pending-moderation files */


1311	#endif
1312
1313	/*
1314	** Output HTML to show a list of attachments.
1315	*/
	@@ -1320,11 +1338,14 @@
1320	){
1321	int cnt = 0;
1322	char szBuf[36] = {0}; /* scratchpad for attachment size value */
1323	const char *zLinkTgt = (ATTACHLIST_TARGET_BLANK & flags)
1324	? " target=\"_blank\"" : "";


1325	Stmt q;

1326	db_prepare(&q,
1327	"SELECT datetime(mtime,toLocal()), a.filename, a.user,"
1328	" b1.uuid, a.src, a.target, a.attachid, b2.size\n"
1329	" FROM attachment a, blob b1, blob b2\n"
1330	" WHERE a.isLatest\n"
	@@ -1350,15 +1371,27 @@
1350	&& moderation_pending(aid)
1351	&& !moderation_user_could(aid, 1, 0) ){
1352	continue;
1353	}
1354	if( cnt==0 ){
1355	@ <section class='attachlist'>








1356	if( flags & ATTACHLIST_HRULE_ABOVE ){
1357	@ <hr>
1358	}
1359	@ %s(zHeader)




1360	@ <ul>
1361	}
1362	cnt++;
1363	switch( attachment_target_type(zTarget, 1) ){
1364	case CFTYPE_TICKET: zTypeArg = "tkt"; break;
1365

	--- src/attach.c
	+++ src/attach.c
	@@ -215,20 +215,21 @@
215	** At most one of technote=, tkt=, forumpost=, or page= may be supplied.
216	**
217	** If none are given, all attachments are listed. If one is given, only
218	** attachments for the designated technote, ticket or wiki page are shown.
219	**
220	** HASH may be just a prefix of the relevant forum post, technical
221	** note, or ticket artifact hash, in which case all attachments of all
222	** technical notes or tickets with the prefix will be listed. Forum
223	** posts, on the other hand, require a unique hash or hash prefix.
224	*/
225	void attachlist_page(void){
226	const char *zPage = P("page");
227	const char *zTkt = P("tkt");
228	const char *zTechNote = P("technote");
229	const char *zForumPost = P("forumpost");
230	char *zLink = 0;
231	Blob sql;
232	Stmt q;
233
234	if( zPage && zTkt ) zTkt = 0;
235	login_check_credentials();
	@@ -248,32 +249,47 @@
249	if( fnid<=0 ){
250	webpage_error("Invalid forum post ID: %h", zForumPost);
251	}
252	blob_append_sql(&sql, " WHERE target="
253	"(SELECT uuid FROM blob WHERE rid=%d)", fnid);
254	zLink = mprintf("forum post <a href='%R/forumpost/%t'>%#h</a>",
255	zForumPost, hash_digits(0), zForumPost);
256	}else if( zPage ){
257	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
258	style_header("Attachments To Wiki page %h", zPage);
259	blob_append_sql(&sql, " WHERE target=%Q", zPage);
260	zLink = mprintf("wiki page <a href='%R/wiki?name=%t'>%h</a>",
261	zPage, zPage);
262	}else if( zTkt ){
263	if( g.perm.RdTkt==0 ){ login_needed(g.anon.RdTkt); return; }
264	style_header("Attachments To Ticket %S", zTkt);
265	blob_append_sql(&sql, " WHERE target GLOB '%q*'", zTkt);
266	zLink = mprintf("ticket <a href='%R/tktview?name=%t'>%#h</a>",
267	zTkt, hash_digits(0), zTkt);
268	}else if( zTechNote ){
269	if( g.perm.RdWiki==0 ){ login_needed(g.anon.RdWiki); return; }
270	style_header("Attachments To Tech Note %S", zTechNote);
271	blob_append_sql(&sql, " WHERE target GLOB '%q*'",
272	zTechNote);
273	zLink = mprintf("tech-note <a href='%R/technote?name=%t'>%#h</a>",
274	zTechNote, hash_digits(0), zTechNote);
275	}else{
276	if( g.perm.RdTkt==0 && g.perm.RdWiki==0 ){
277	login_needed(g.anon.RdTkt \|\| g.anon.RdWiki);
278	return;
279	}
280	style_header("All Attachments");
281	}
282	blob_append_sql(&sql, " ORDER BY mtime DESC");
283	db_prepare(&q, "%s", blob_sql_text(&sql));
284
285	if( zLink ){
286	@ <h2>Attachments for %s(zLink)</h2>
287	fossil_free(zLink);
288	zLink = 0;
289	}
290
291	@ <ol>
292	while( db_step(&q)==SQLITE_ROW ){
293	const char *zDate;
294	const char *zSrc;
295	const char *zTarget;
	@@ -954,11 +970,11 @@
970	zTarget = db_text(0, "SELECT substr(tagname,7) FROM tag"
971	" WHERE tagname GLOB 'event-%q*'", zTarget);
972	if( zTarget==0) fossil_redirect_home();
973	}
974	zTo = zFrom ? 0 : mprintf("%R/technote?name=%T", zTarget);
975	zTargetType = mprintf("Tech-note <a href=\"%R/technote/%s\">%S</a>",
976	zTarget, zTarget);
977	noJsArgs[1] = zTarget;
978	break;
979	}
980	case CFTYPE_TICKET:{
	@@ -984,11 +1000,11 @@
1000	}
1001	if( !db_exists("SELECT 1 FROM tag WHERE tagname='wiki-%q'", zTarget) ){
1002	fossil_redirect_home();
1003	}
1004	zTo = zFrom ? 0 : mprintf("%R/wiki?name=%T", zTarget);
1005	zTargetType = mprintf("Wiki page <a href=\"%R/wiki?name=%h\">%h</a>",
1006	zTarget, zTarget);
1007	noJsArgs[3] = zTarget;
1008	break;
1009	}
1010	}
	@@ -1306,10 +1322,12 @@
1322	*/
1323	#define ATTACHLIST_HRULE_ABOVE 0x01 /* Insert <hr> above header */
1324	#define ATTACHLIST_TARGET_BLANK 0x02 /* use target=_blank for links */
1325	#define ATTACHLIST_SIZE 0x04 /* add size */
1326	#define ATTACHLIST_HIDE_UNAPPROVED 0x08 /* Hide pending-moderation files */
1327	#define ATTACHLIST_DETAILS_CLOSED 0x10 /* Wrap in a closed DETAILS element */
1328	#define ATTACHLIST_DETAILS_OPEN 0x20 /* Wrap in an open DETAILS element */
1329	#endif
1330
1331	/*
1332	** Output HTML to show a list of attachments.
1333	*/
	@@ -1320,11 +1338,14 @@
1338	){
1339	int cnt = 0;
1340	char szBuf[36] = {0}; /* scratchpad for attachment size value */
1341	const char *zLinkTgt = (ATTACHLIST_TARGET_BLANK & flags)
1342	? " target=\"_blank\"" : "";
1343	const int bUseDetail = flags &
1344	(ATTACHLIST_DETAILS_CLOSED \| ATTACHLIST_DETAILS_OPEN);
1345	Stmt q;
1346
1347	db_prepare(&q,
1348	"SELECT datetime(mtime,toLocal()), a.filename, a.user,"
1349	" b1.uuid, a.src, a.target, a.attachid, b2.size\n"
1350	" FROM attachment a, blob b1, blob b2\n"
1351	" WHERE a.isLatest\n"
	@@ -1350,15 +1371,27 @@
1371	&& moderation_pending(aid)
1372	&& !moderation_user_could(aid, 1, 0) ){
1373	continue;
1374	}
1375	if( cnt==0 ){
1376	if( bUseDetail ){
1377	@ <details class='attachlist'
1378	if( ATTACHLIST_DETAILS_OPEN & flags ){
1379	@ open
1380	}
1381	@ >
1382	}else{
1383	@ <section class='attachlist'>
1384	}
1385	if( flags & ATTACHLIST_HRULE_ABOVE ){
1386	@ <hr>
1387	}
1388	if( bUseDetail ){
1389	@ <summary>%s(zHeader)</summary>
1390	}else{
1391	@ %s(zHeader)
1392	}
1393	@ <ul>
1394	}
1395	cnt++;
1396	switch( attachment_target_type(zTarget, 1) ){
1397	case CFTYPE_TICKET: zTypeArg = "tkt"; break;
1398

M src/default.css

		--- src/default.css
		+++ src/default.css
		@@ -2009,10 +2009,14 @@
2009	2009	div.helpPage blockquote {
2010	2010	margin-left: 0.2em;
2011	2011	}
2012	2012
2013	2013	/* .attach* = styles for file attachments */
	2014	+section.attachlist {}
	2015	+details.attachlist > summary {
	2016	+ cursor: pointer;
	2017	+}
2014	2018	.attach-widget {
2015	2019	margin-bottom: 1em;
2016	2020	display: flex;
2017	2021	flex-direction: column;
2018	2022	gap: 0.75em;
2019	2023

	--- src/default.css
	+++ src/default.css
	@@ -2009,10 +2009,14 @@
2009	div.helpPage blockquote {
2010	margin-left: 0.2em;
2011	}
2012
2013	/* .attach* = styles for file attachments */




2014	.attach-widget {
2015	margin-bottom: 1em;
2016	display: flex;
2017	flex-direction: column;
2018	gap: 0.75em;
2019

	--- src/default.css
	+++ src/default.css
	@@ -2009,10 +2009,14 @@
2009	div.helpPage blockquote {
2010	margin-left: 0.2em;
2011	}
2012
2013	/* .attach* = styles for file attachments */
2014	section.attachlist {}
2015	details.attachlist > summary {
2016	cursor: pointer;
2017	}
2018	.attach-widget {
2019	margin-bottom: 1em;
2020	display: flex;
2021	flex-direction: column;
2022	gap: 0.75em;
2023

M src/event.c

+8 -1

		--- src/event.c
		+++ src/event.c
		@@ -229,11 +229,18 @@
229	229	}else{
230	230	@ <pre>
231	231	@ %h(blob_str(&fullbody))
232	232	@ </pre>
233	233	}
234		- attachment_list(zFullId, "<h2>Attachments:</h2>", 1);
	234	+ {
	235	+ char * z = mprintf(
	236	+ "<h2><a href='%R/attachlist?technote=%t'>Attachments</a>:</h2>",
	237	+ zFullId
	238	+ );
	239	+ attachment_list(zFullId, z, 1);
	240	+ fossil_free(z);
	241	+ }
235	242	document_emit_js();
236	243	style_finish_page();
237	244	manifest_destroy(pTNote);
238	245	}
239	246
240	247

	--- src/event.c
	+++ src/event.c
	@@ -229,11 +229,18 @@
229	}else{
230	@ <pre>
231	@ %h(blob_str(&fullbody))
232	@ </pre>
233	}
234	attachment_list(zFullId, "<h2>Attachments:</h2>", 1);







235	document_emit_js();
236	style_finish_page();
237	manifest_destroy(pTNote);
238	}
239
240

	--- src/event.c
	+++ src/event.c
	@@ -229,11 +229,18 @@
229	}else{
230	@ <pre>
231	@ %h(blob_str(&fullbody))
232	@ </pre>
233	}
234	{
235	char * z = mprintf(
236	"<h2><a href='%R/attachlist?technote=%t'>Attachments</a>:</h2>",
237	zFullId
238	);
239	attachment_list(zFullId, z, 1);
240	fossil_free(z);
241	}
242	document_emit_js();
243	style_finish_page();
244	manifest_destroy(pTNote);
245	}
246
247

M src/forum.c

+14 -7

		--- src/forum.c
		+++ src/forum.c
		@@ -1045,17 +1045,24 @@
1045	1045	/*
1046	1046	** Renders the attachment list for the given forum post.
1047	1047	** Emits no output if there are no attachments.
1048	1048	*/
1049	1049	static void forum_render_attachment_list(const char *zUuid){
1050		- char * zLbl = mprintf("<a href='%R/attachlist?forumpost=%!S'>"
1051		- "Attachments</a>:", zUuid);
1052		- attachment_list(zUuid, zLbl,
1053		- ATTACHLIST_HRULE_ABOVE
1054		- \| ATTACHLIST_SIZE
1055		- \| ATTACHLIST_HIDE_UNAPPROVED);
1056		- fossil_free(zLbl);
	1050	+#if 1
	1051	+ attachment_list(zUuid, "📎 Attachments", 0
	1052	+ \| ATTACHLIST_SIZE
	1053	+ \| ATTACHLIST_HIDE_UNAPPROVED
	1054	+ \| ATTACHLIST_DETAILS_CLOSED);
	1055	+#else
	1056	+ char * zLbl = mprintf("<a href='%R/attachlist?forumpost=%!S'>"
	1057	+ "Attachments</a>:", zUuid);
	1058	+ attachment_list(zUuid, zLbl,
	1059	+ ATTACHLIST_HRULE_ABOVE
	1060	+ \| ATTACHLIST_SIZE
	1061	+ \| ATTACHLIST_HIDE_UNAPPROVED);
	1062	+ fossil_free(zLbl);
	1063	+#endif
1057	1064	}
1058	1065
1059	1066	/*
1060	1067	** Renders the attachment list for p or (if not NULL) pEditHead.
1061	1068	*/
1062	1069

	--- src/forum.c
	+++ src/forum.c
	@@ -1045,17 +1045,24 @@
1045	/*
1046	** Renders the attachment list for the given forum post.
1047	** Emits no output if there are no attachments.
1048	*/
1049	static void forum_render_attachment_list(const char *zUuid){
1050	char * zLbl = mprintf("<a href='%R/attachlist?forumpost=%!S'>"
1051	"Attachments</a>:", zUuid);
1052	attachment_list(zUuid, zLbl,
1053	ATTACHLIST_HRULE_ABOVE
1054	\| ATTACHLIST_SIZE
1055	\| ATTACHLIST_HIDE_UNAPPROVED);
1056	fossil_free(zLbl);







1057	}
1058
1059	/*
1060	** Renders the attachment list for p or (if not NULL) pEditHead.
1061	*/
1062

	--- src/forum.c
	+++ src/forum.c
	@@ -1045,17 +1045,24 @@
1045	/*
1046	** Renders the attachment list for the given forum post.
1047	** Emits no output if there are no attachments.
1048	*/
1049	static void forum_render_attachment_list(const char *zUuid){
1050	#if 1
1051	attachment_list(zUuid, "📎 Attachments", 0
1052	\| ATTACHLIST_SIZE
1053	\| ATTACHLIST_HIDE_UNAPPROVED
1054	\| ATTACHLIST_DETAILS_CLOSED);
1055	#else
1056	char * zLbl = mprintf("<a href='%R/attachlist?forumpost=%!S'>"
1057	"Attachments</a>:", zUuid);
1058	attachment_list(zUuid, zLbl,
1059	ATTACHLIST_HRULE_ABOVE
1060	\| ATTACHLIST_SIZE
1061	\| ATTACHLIST_HIDE_UNAPPROVED);
1062	fossil_free(zLbl);
1063	#endif
1064	}
1065
1066	/*
1067	** Renders the attachment list for p or (if not NULL) pEditHead.
1068	*/
1069

M src/tkt.c

+6 -1

		--- src/tkt.c
		+++ src/tkt.c
		@@ -789,11 +789,16 @@
789	789	safe_html_context(DOCSRC_TICKET);
790	790	Th_Render(zScript);
791	791	if( g.thTrace ) Th_Trace("END_TKTVIEW<br>\n", -1);
792	792
793	793	if( zFullName ){
794		- attachment_list(zFullName, "<h2>Attachments:</h2>", 1);
	794	+ char * z = mprintf(
	795	+ "<h2><a href='%R/attachlist?tkt=%t'>Attachments</a>:</h2>",
	796	+ zFullName
	797	+ );
	798	+ attachment_list(zFullName, z, 1);
	799	+ fossil_free(z);
795	800	}
796	801
797	802	builtin_fossil_js_bundle_or("dom", "storage", NULL);
798	803	builtin_request_js("fossil.page.ticket.js");
799	804	builtin_fulfill_js_requests();
800	805

	--- src/tkt.c
	+++ src/tkt.c
	@@ -789,11 +789,16 @@
789	safe_html_context(DOCSRC_TICKET);
790	Th_Render(zScript);
791	if( g.thTrace ) Th_Trace("END_TKTVIEW<br>\n", -1);
792
793	if( zFullName ){
794	attachment_list(zFullName, "<h2>Attachments:</h2>", 1);





795	}
796
797	builtin_fossil_js_bundle_or("dom", "storage", NULL);
798	builtin_request_js("fossil.page.ticket.js");
799	builtin_fulfill_js_requests();
800

	--- src/tkt.c
	+++ src/tkt.c
	@@ -789,11 +789,16 @@
789	safe_html_context(DOCSRC_TICKET);
790	Th_Render(zScript);
791	if( g.thTrace ) Th_Trace("END_TKTVIEW<br>\n", -1);
792
793	if( zFullName ){
794	char * z = mprintf(
795	"<h2><a href='%R/attachlist?tkt=%t'>Attachments</a>:</h2>",
796	zFullName
797	);
798	attachment_list(zFullName, z, 1);
799	fossil_free(z);
800	}
801
802	builtin_fossil_js_bundle_or("dom", "storage", NULL);
803	builtin_request_js("fossil.page.ticket.js");
804	builtin_fulfill_js_requests();
805

Fossil SCM

Keyboard Shortcuts