Fossil SCM

On the /hash-collisions page show the true first instance of each collision, not the second.

drh 2015-02-11 12:03 trunk
Commit 4ce3a2bfacbf3fed12f4ba5dcaf739564de01074
1 file changed +1 -1
+1 -1
--- src/name.c
+++ src/name.c
@@ -1091,15 +1091,15 @@
10911091
const char *zUuid = db_column_text(&q,0);
10921092
int n = db_column_bytes(&q,0);
10931093
int i;
10941094
nHash++;
10951095
for(i=0; zPrev[i] && zPrev[i]==zUuid[i]; i++){}
1096
- memcpy(zPrev, zUuid, n+1);
10971096
if( i>0 && i<=UUID_SIZE ){
10981097
aCollide[i].cnt++;
10991098
if( aCollide[i].z[0]==0 ) memcpy(aCollide[i].z, zPrev, n+1);
11001099
}
1100
+ memcpy(zPrev, zUuid, n+1);
11011101
}
11021102
db_finalize(&q);
11031103
style_header("Hash Prefix Collisions");
11041104
@ <table border=1><thead>
11051105
@ <tr><th>Length<th>Instances<th>First Instance</tr>
11061106
--- src/name.c
+++ src/name.c
@@ -1091,15 +1091,15 @@
1091 const char *zUuid = db_column_text(&q,0);
1092 int n = db_column_bytes(&q,0);
1093 int i;
1094 nHash++;
1095 for(i=0; zPrev[i] && zPrev[i]==zUuid[i]; i++){}
1096 memcpy(zPrev, zUuid, n+1);
1097 if( i>0 && i<=UUID_SIZE ){
1098 aCollide[i].cnt++;
1099 if( aCollide[i].z[0]==0 ) memcpy(aCollide[i].z, zPrev, n+1);
1100 }
 
1101 }
1102 db_finalize(&q);
1103 style_header("Hash Prefix Collisions");
1104 @ <table border=1><thead>
1105 @ <tr><th>Length<th>Instances<th>First Instance</tr>
1106
--- src/name.c
+++ src/name.c
@@ -1091,15 +1091,15 @@
1091 const char *zUuid = db_column_text(&q,0);
1092 int n = db_column_bytes(&q,0);
1093 int i;
1094 nHash++;
1095 for(i=0; zPrev[i] && zPrev[i]==zUuid[i]; i++){}
 
1096 if( i>0 && i<=UUID_SIZE ){
1097 aCollide[i].cnt++;
1098 if( aCollide[i].z[0]==0 ) memcpy(aCollide[i].z, zPrev, n+1);
1099 }
1100 memcpy(zPrev, zUuid, n+1);
1101 }
1102 db_finalize(&q);
1103 style_header("Hash Prefix Collisions");
1104 @ <table border=1><thead>
1105 @ <tr><th>Length<th>Instances<th>First Instance</tr>
1106

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button