Fossil SCM
Rewrote the autoreconfigure explanation comment. It was confusing and contained errors.
Commit
50844e5c6be4836ffcacb836d941c5bff5f7735e80fda0267ef1a662350032ca
Parent
454e119398c27c8…
1 file changed
+12
-10
+12
-10
| --- Makefile.in | ||
| +++ Makefile.in | ||
| @@ -53,20 +53,22 @@ | ||
| 53 | 53 | rm -f autoconfig.h config.log Makefile |
| 54 | 54 | |
| 55 | 55 | reconfig: |
| 56 | 56 | @AUTOREMAKE@ |
| 57 | 57 | |
| 58 | -# Reconfigure whenever an audiosetup file or one of the make source | |
| 59 | -# files change, unless this is "make clean". | |
| 58 | +# Automatically reconfigure whenever an autosetup file or one of the | |
| 59 | +# make source files change. | |
| 60 | 60 | # |
| 61 | 61 | # The "touch" is necessary to avoid a make loop due to a new upstream |
| 62 | -# feature in autosetup where *.in outputs are touched only if they | |
| 63 | -# actually change. If something other than Makefile.in changes, we'll | |
| 64 | -# reconfigure but Makefile won't change, so this rule will remain out of | |
| 65 | -# date, so we'll reconfigure but Makefile won't change, so we'll... | |
| 66 | -# | |
| 67 | -# This also why we repeat the reconfig target's command here instead | |
| 68 | -# of delegating to it with "$(MAKE) reconfig": having children running | |
| 69 | -# around interfering makes this worse. | |
| 62 | +# feature in autosetup (GH 0a71e3c3b7) which rewrites *.in outputs only | |
| 63 | +# if doing so will write different contents; otherwise, it leaves them | |
| 64 | +# alone so the mtime doesn't change. This means that if you change one | |
| 65 | +# our depdendencies besides Makefile.in, we'll reconfigure but Makefile | |
| 66 | +# won't change, so this rule will remain out of date, so we'll reconfig | |
| 67 | +# but Makefile won't change, so we'll reconfig but... endlessly. | |
| 68 | +# | |
| 69 | +# This is also why we repeat the reconfig target's command here instead | |
| 70 | +# of delegating to it with "$(MAKE) reconfig": having children running | |
| 71 | +# around interfering makes this failure mode even worse. | |
| 70 | 72 | Makefile: @srcdir@/Makefile.in $(SRCDIR)/main.mk @AUTODEPS@ |
| 71 | 73 | @AUTOREMAKE@ |
| 72 | 74 | touch @builddir@/Makefile |
| 73 | 75 |
| --- Makefile.in | |
| +++ Makefile.in | |
| @@ -53,20 +53,22 @@ | |
| 53 | rm -f autoconfig.h config.log Makefile |
| 54 | |
| 55 | reconfig: |
| 56 | @AUTOREMAKE@ |
| 57 | |
| 58 | # Reconfigure whenever an audiosetup file or one of the make source |
| 59 | # files change, unless this is "make clean". |
| 60 | # |
| 61 | # The "touch" is necessary to avoid a make loop due to a new upstream |
| 62 | # feature in autosetup where *.in outputs are touched only if they |
| 63 | # actually change. If something other than Makefile.in changes, we'll |
| 64 | # reconfigure but Makefile won't change, so this rule will remain out of |
| 65 | # date, so we'll reconfigure but Makefile won't change, so we'll... |
| 66 | # |
| 67 | # This also why we repeat the reconfig target's command here instead |
| 68 | # of delegating to it with "$(MAKE) reconfig": having children running |
| 69 | # around interfering makes this worse. |
| 70 | Makefile: @srcdir@/Makefile.in $(SRCDIR)/main.mk @AUTODEPS@ |
| 71 | @AUTOREMAKE@ |
| 72 | touch @builddir@/Makefile |
| 73 |
| --- Makefile.in | |
| +++ Makefile.in | |
| @@ -53,20 +53,22 @@ | |
| 53 | rm -f autoconfig.h config.log Makefile |
| 54 | |
| 55 | reconfig: |
| 56 | @AUTOREMAKE@ |
| 57 | |
| 58 | # Automatically reconfigure whenever an autosetup file or one of the |
| 59 | # make source files change. |
| 60 | # |
| 61 | # The "touch" is necessary to avoid a make loop due to a new upstream |
| 62 | # feature in autosetup (GH 0a71e3c3b7) which rewrites *.in outputs only |
| 63 | # if doing so will write different contents; otherwise, it leaves them |
| 64 | # alone so the mtime doesn't change. This means that if you change one |
| 65 | # our depdendencies besides Makefile.in, we'll reconfigure but Makefile |
| 66 | # won't change, so this rule will remain out of date, so we'll reconfig |
| 67 | # but Makefile won't change, so we'll reconfig but... endlessly. |
| 68 | # |
| 69 | # This is also why we repeat the reconfig target's command here instead |
| 70 | # of delegating to it with "$(MAKE) reconfig": having children running |
| 71 | # around interfering makes this failure mode even worse. |
| 72 | Makefile: @srcdir@/Makefile.in $(SRCDIR)/main.mk @AUTODEPS@ |
| 73 | @AUTOREMAKE@ |
| 74 | touch @builddir@/Makefile |
| 75 |