Fossil SCM

Don't use magic numbers, and also improve readability for adjacent lines.

florian 2022-07-29 11:37 UTC timeline-keyboard-navigation
Commit 57baac30d679d436d27b8eaefc6a73fa87d99545e732c368be19e63550400197
1 file changed +3 -3
+3 -3
--- src/graph.js
+++ src/graph.js
@@ -858,11 +858,11 @@
858858
var td = document.getElementById('timeline-data-' + i);
859859
if( !td ) break;
860860
var ti = JSON.parse(td.textContent || td.innerText);
861861
for( var k=0; k<ti.rowinfo.length; k++ ){
862862
if( id=='m' + ti.rowinfo[k].id ) return {
863
- 'b': ti.baseUrl, 'h': ti.rowinfo[k].h
863
+ 'baseurl': ti.baseUrl, 'hash': ti.rowinfo[k].h
864864
};
865865
}
866866
}
867867
return null;
868868
}
@@ -918,12 +918,12 @@
918918
document.cookie = 'fossil_timeline_kbnav=1;path=/';
919919
var id = kf.value;
920920
if( id && dx==0 ){
921921
var ri = focusRowinfoFromId(id);
922922
if( ri ){
923
- var page = ( key==75/*K*/ ) ? '/info/' : '/timeline?c=';
924
- var href = ri.b + page + ri.h;
923
+ var page = key==kVIEW ? '/info/' : '/timeline?c=';
924
+ var href = ri.baseurl + page + ri.hash;
925925
if( href!=location.href.slice(-href.length) ){
926926
location.href = href;
927927
return;
928928
}
929929
}
930930
--- src/graph.js
+++ src/graph.js
@@ -858,11 +858,11 @@
858 var td = document.getElementById('timeline-data-' + i);
859 if( !td ) break;
860 var ti = JSON.parse(td.textContent || td.innerText);
861 for( var k=0; k<ti.rowinfo.length; k++ ){
862 if( id=='m' + ti.rowinfo[k].id ) return {
863 'b': ti.baseUrl, 'h': ti.rowinfo[k].h
864 };
865 }
866 }
867 return null;
868 }
@@ -918,12 +918,12 @@
918 document.cookie = 'fossil_timeline_kbnav=1;path=/';
919 var id = kf.value;
920 if( id && dx==0 ){
921 var ri = focusRowinfoFromId(id);
922 if( ri ){
923 var page = ( key==75/*K*/ ) ? '/info/' : '/timeline?c=';
924 var href = ri.b + page + ri.h;
925 if( href!=location.href.slice(-href.length) ){
926 location.href = href;
927 return;
928 }
929 }
930
--- src/graph.js
+++ src/graph.js
@@ -858,11 +858,11 @@
858 var td = document.getElementById('timeline-data-' + i);
859 if( !td ) break;
860 var ti = JSON.parse(td.textContent || td.innerText);
861 for( var k=0; k<ti.rowinfo.length; k++ ){
862 if( id=='m' + ti.rowinfo[k].id ) return {
863 'baseurl': ti.baseUrl, 'hash': ti.rowinfo[k].h
864 };
865 }
866 }
867 return null;
868 }
@@ -918,12 +918,12 @@
918 document.cookie = 'fossil_timeline_kbnav=1;path=/';
919 var id = kf.value;
920 if( id && dx==0 ){
921 var ri = focusRowinfoFromId(id);
922 if( ri ){
923 var page = key==kVIEW ? '/info/' : '/timeline?c=';
924 var href = ri.baseurl + page + ri.hash;
925 if( href!=location.href.slice(-href.length) ){
926 location.href = href;
927 return;
928 }
929 }
930

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button