Fossil SCM

Remember-me toggle defaults to off, per forum feedback.

stephan 2020-07-27 15:56 login-session-cookie
Commit 587cd77e0065239b31f38e6d59528bad21d9bf394c83b63382c579cf366872b6
1 file changed +4 -3
+4 -3
--- src/login.c
+++ src/login.c
@@ -525,12 +525,13 @@
525525
int uid; /* User id logged in user */
526526
char *zSha1Pw;
527527
const char *zIpAddr; /* IP address of requestor */
528528
const char *zReferer;
529529
const int noAnon = P("noanon")!=0;
530
- int rememberMe; /* If true, use persistent cookie,
531
- else session cookie */
530
+ int rememberMe; /* If true, use persistent cookie, else
531
+ session cookie. Toggled per
532
+ checkbox. */
532533
533534
login_check_credentials();
534535
fossil_redirect_to_https_if_needed(1);
535536
sqlite3_create_function(g.db, "constant_time_cmp", 2, SQLITE_UTF8, 0,
536537
constant_time_cmp_function, 0, 0);
@@ -612,11 +613,11 @@
612613
zIpAddr = PD("REMOTE_ADDR","nil"); /* Complete IP address for logging */
613614
zReferer = P("HTTP_REFERER");
614615
uid = login_is_valid_anonymous(zUsername, zPasswd, P("cs"));
615616
if(zUsername==0){
616617
/* Initial login page hit. */
617
- rememberMe = 1 /* seems like a sensible default */;
618
+ rememberMe = 0;
618619
}else{
619620
rememberMe = P("remember")!=0;
620621
}
621622
if( uid>0 ){
622623
login_set_anon_cookie(zIpAddr, NULL, rememberMe?0:1);
623624
--- src/login.c
+++ src/login.c
@@ -525,12 +525,13 @@
525 int uid; /* User id logged in user */
526 char *zSha1Pw;
527 const char *zIpAddr; /* IP address of requestor */
528 const char *zReferer;
529 const int noAnon = P("noanon")!=0;
530 int rememberMe; /* If true, use persistent cookie,
531 else session cookie */
 
532
533 login_check_credentials();
534 fossil_redirect_to_https_if_needed(1);
535 sqlite3_create_function(g.db, "constant_time_cmp", 2, SQLITE_UTF8, 0,
536 constant_time_cmp_function, 0, 0);
@@ -612,11 +613,11 @@
612 zIpAddr = PD("REMOTE_ADDR","nil"); /* Complete IP address for logging */
613 zReferer = P("HTTP_REFERER");
614 uid = login_is_valid_anonymous(zUsername, zPasswd, P("cs"));
615 if(zUsername==0){
616 /* Initial login page hit. */
617 rememberMe = 1 /* seems like a sensible default */;
618 }else{
619 rememberMe = P("remember")!=0;
620 }
621 if( uid>0 ){
622 login_set_anon_cookie(zIpAddr, NULL, rememberMe?0:1);
623
--- src/login.c
+++ src/login.c
@@ -525,12 +525,13 @@
525 int uid; /* User id logged in user */
526 char *zSha1Pw;
527 const char *zIpAddr; /* IP address of requestor */
528 const char *zReferer;
529 const int noAnon = P("noanon")!=0;
530 int rememberMe; /* If true, use persistent cookie, else
531 session cookie. Toggled per
532 checkbox. */
533
534 login_check_credentials();
535 fossil_redirect_to_https_if_needed(1);
536 sqlite3_create_function(g.db, "constant_time_cmp", 2, SQLITE_UTF8, 0,
537 constant_time_cmp_function, 0, 0);
@@ -612,11 +613,11 @@
613 zIpAddr = PD("REMOTE_ADDR","nil"); /* Complete IP address for logging */
614 zReferer = P("HTTP_REFERER");
615 uid = login_is_valid_anonymous(zUsername, zPasswd, P("cs"));
616 if(zUsername==0){
617 /* Initial login page hit. */
618 rememberMe = 0;
619 }else{
620 rememberMe = P("remember")!=0;
621 }
622 if( uid>0 ){
623 login_set_anon_cookie(zIpAddr, NULL, rememberMe?0:1);
624

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button