Fossil SCM
In the status-change widget, start its inner help text element hidden so that it does not interfere with no-js clients. It gets unhidden in the forum JS. Problem reported by Martin G.
Commit
69cc41e6b3f2ce36d3dd88a7c8e9f04c948635b6ea2ea108c10cf700a9ca2710
Parent
079ea1c339d4cff…
2 files changed
+1
-1
+7
+1
-1
| --- src/forum.c | ||
| +++ src/forum.c | ||
| @@ -900,11 +900,11 @@ | ||
| 900 | 900 | } |
| 901 | 901 | if( !sCurrent ) sCurrent = &fss->aStatus[0]; |
| 902 | 902 | assert( sCurrent ); |
| 903 | 903 | @ <fieldset class='forum-status-selection'>\ |
| 904 | 904 | @ <legend>Status \ |
| 905 | - @ <span class='help-buttonlet'>\ | |
| 905 | + @ <span class='help-buttonlet initially-hidden'>\ | |
| 906 | 906 | @ Moderators and the post's owner may change \ |
| 907 | 907 | @ the status of this thread. See \ |
| 908 | 908 | @ <a href='%R/help/forum-statuses' target='_new'>\ |
| 909 | 909 | @ /help/forum-statuses</a></span>\ |
| 910 | 910 | @ </legend>\ |
| 911 | 911 |
| --- src/forum.c | |
| +++ src/forum.c | |
| @@ -900,11 +900,11 @@ | |
| 900 | } |
| 901 | if( !sCurrent ) sCurrent = &fss->aStatus[0]; |
| 902 | assert( sCurrent ); |
| 903 | @ <fieldset class='forum-status-selection'>\ |
| 904 | @ <legend>Status \ |
| 905 | @ <span class='help-buttonlet'>\ |
| 906 | @ Moderators and the post's owner may change \ |
| 907 | @ the status of this thread. See \ |
| 908 | @ <a href='%R/help/forum-statuses' target='_new'>\ |
| 909 | @ /help/forum-statuses</a></span>\ |
| 910 | @ </legend>\ |
| 911 |
| --- src/forum.c | |
| +++ src/forum.c | |
| @@ -900,11 +900,11 @@ | |
| 900 | } |
| 901 | if( !sCurrent ) sCurrent = &fss->aStatus[0]; |
| 902 | assert( sCurrent ); |
| 903 | @ <fieldset class='forum-status-selection'>\ |
| 904 | @ <legend>Status \ |
| 905 | @ <span class='help-buttonlet initially-hidden'>\ |
| 906 | @ Moderators and the post's owner may change \ |
| 907 | @ the status of this thread. See \ |
| 908 | @ <a href='%R/help/forum-statuses' target='_new'>\ |
| 909 | @ /help/forum-statuses</a></span>\ |
| 910 | @ </legend>\ |
| 911 |
| --- src/fossil.page.forumpost.js | ||
| +++ src/fossil.page.forumpost.js | ||
| @@ -1049,10 +1049,17 @@ | ||
| 1049 | 1049 | ':scope > fieldset.forum-status-selection' |
| 1050 | 1050 | ); |
| 1051 | 1051 | if( eStatusChange ) eToDisable.push(eStatusChange); |
| 1052 | 1052 | })/*for-each form*/; |
| 1053 | 1053 | }/* /forumpost and /forumthread */ |
| 1054 | + | |
| 1055 | + document.body.querySelectorAll('.initially-hidden').forEach(e=>{ | |
| 1056 | + /* This is a workaround for a span.help-buttonlet which we need | |
| 1057 | + to start hidden so that it does not show up for no-JS | |
| 1058 | + clients. */ | |
| 1059 | + e.classList.remove('initially-hidden'); | |
| 1060 | + }); | |
| 1054 | 1061 | |
| 1055 | 1062 | if( Date.now() % 17 === 0 ){ |
| 1056 | 1063 | /* Purge old drafts only every now and then. */ |
| 1057 | 1064 | F.ForumPostEditor.purgeOldDrafts(/^draft-forum.*/); |
| 1058 | 1065 | } |
| 1059 | 1066 |
| --- src/fossil.page.forumpost.js | |
| +++ src/fossil.page.forumpost.js | |
| @@ -1049,10 +1049,17 @@ | |
| 1049 | ':scope > fieldset.forum-status-selection' |
| 1050 | ); |
| 1051 | if( eStatusChange ) eToDisable.push(eStatusChange); |
| 1052 | })/*for-each form*/; |
| 1053 | }/* /forumpost and /forumthread */ |
| 1054 | |
| 1055 | if( Date.now() % 17 === 0 ){ |
| 1056 | /* Purge old drafts only every now and then. */ |
| 1057 | F.ForumPostEditor.purgeOldDrafts(/^draft-forum.*/); |
| 1058 | } |
| 1059 |
| --- src/fossil.page.forumpost.js | |
| +++ src/fossil.page.forumpost.js | |
| @@ -1049,10 +1049,17 @@ | |
| 1049 | ':scope > fieldset.forum-status-selection' |
| 1050 | ); |
| 1051 | if( eStatusChange ) eToDisable.push(eStatusChange); |
| 1052 | })/*for-each form*/; |
| 1053 | }/* /forumpost and /forumthread */ |
| 1054 | |
| 1055 | document.body.querySelectorAll('.initially-hidden').forEach(e=>{ |
| 1056 | /* This is a workaround for a span.help-buttonlet which we need |
| 1057 | to start hidden so that it does not show up for no-JS |
| 1058 | clients. */ |
| 1059 | e.classList.remove('initially-hidden'); |
| 1060 | }); |
| 1061 | |
| 1062 | if( Date.now() % 17 === 0 ){ |
| 1063 | /* Purge old drafts only every now and then. */ |
| 1064 | F.ForumPostEditor.purgeOldDrafts(/^draft-forum.*/); |
| 1065 | } |
| 1066 |