Fossil SCM
/stats_report now shows report list by default. Removed an unused variable.
Commit
6e42254616a36491a7dbf8f7075af38013426e35
Parent
08b9b5b0d9e9cf8…
1 file changed
+7
-3
+7
-3
| --- src/timeline.c | ||
| +++ src/timeline.c | ||
| @@ -2006,13 +2006,12 @@ | ||
| 2006 | 2006 | ** view=REPORT_NAME Valid values: bymonth, byyear, byuser |
| 2007 | 2007 | ** user=NAME Restricts statistics to the given user |
| 2008 | 2008 | */ |
| 2009 | 2009 | void stats_report_page(){ |
| 2010 | 2010 | HQuery url; /* URL for various branch links */ |
| 2011 | - char const * zView = PD("view","bymonth"); /* Which view/report to show. */ | |
| 2011 | + char const * zView = P("view"); /* Which view/report to show. */ | |
| 2012 | 2012 | char const *zUserName = P("user"); |
| 2013 | - int whichReport = 0; | |
| 2014 | 2013 | url_initialize(&url, "stats_report"); |
| 2015 | 2014 | /* We have to figure out which report to run before continuing so |
| 2016 | 2015 | that we can add (or not) the user= param to the buttons in a sane |
| 2017 | 2016 | manner. |
| 2018 | 2017 | */ |
| @@ -2031,10 +2030,15 @@ | ||
| 2031 | 2030 | }else if(0==fossil_strcmp(zView,"byweek")){ |
| 2032 | 2031 | @ TODO: by-week report. |
| 2033 | 2032 | }else if(0==fossil_strcmp(zView,"byuser")){ |
| 2034 | 2033 | stats_report_by_user(); |
| 2035 | 2034 | }else{ |
| 2036 | - @ TODO: show report select list. | |
| 2035 | + @ <h1>Select a report to show:</h1> | |
| 2036 | + @ <ul> | |
| 2037 | + @ <li><a href='?view=byyear'>Events by year</a></li> | |
| 2038 | + @ <li><a href='?view=bymonth'>Events by month</a></li> | |
| 2039 | + @ <li><a href='?view=byuser'>Events by user</a></li> | |
| 2040 | + @ </ul> | |
| 2037 | 2041 | } |
| 2038 | 2042 | |
| 2039 | 2043 | style_footer(); |
| 2040 | 2044 | } |
| 2041 | 2045 |
| --- src/timeline.c | |
| +++ src/timeline.c | |
| @@ -2006,13 +2006,12 @@ | |
| 2006 | ** view=REPORT_NAME Valid values: bymonth, byyear, byuser |
| 2007 | ** user=NAME Restricts statistics to the given user |
| 2008 | */ |
| 2009 | void stats_report_page(){ |
| 2010 | HQuery url; /* URL for various branch links */ |
| 2011 | char const * zView = PD("view","bymonth"); /* Which view/report to show. */ |
| 2012 | char const *zUserName = P("user"); |
| 2013 | int whichReport = 0; |
| 2014 | url_initialize(&url, "stats_report"); |
| 2015 | /* We have to figure out which report to run before continuing so |
| 2016 | that we can add (or not) the user= param to the buttons in a sane |
| 2017 | manner. |
| 2018 | */ |
| @@ -2031,10 +2030,15 @@ | |
| 2031 | }else if(0==fossil_strcmp(zView,"byweek")){ |
| 2032 | @ TODO: by-week report. |
| 2033 | }else if(0==fossil_strcmp(zView,"byuser")){ |
| 2034 | stats_report_by_user(); |
| 2035 | }else{ |
| 2036 | @ TODO: show report select list. |
| 2037 | } |
| 2038 | |
| 2039 | style_footer(); |
| 2040 | } |
| 2041 |
| --- src/timeline.c | |
| +++ src/timeline.c | |
| @@ -2006,13 +2006,12 @@ | |
| 2006 | ** view=REPORT_NAME Valid values: bymonth, byyear, byuser |
| 2007 | ** user=NAME Restricts statistics to the given user |
| 2008 | */ |
| 2009 | void stats_report_page(){ |
| 2010 | HQuery url; /* URL for various branch links */ |
| 2011 | char const * zView = P("view"); /* Which view/report to show. */ |
| 2012 | char const *zUserName = P("user"); |
| 2013 | url_initialize(&url, "stats_report"); |
| 2014 | /* We have to figure out which report to run before continuing so |
| 2015 | that we can add (or not) the user= param to the buttons in a sane |
| 2016 | manner. |
| 2017 | */ |
| @@ -2031,10 +2030,15 @@ | |
| 2030 | }else if(0==fossil_strcmp(zView,"byweek")){ |
| 2031 | @ TODO: by-week report. |
| 2032 | }else if(0==fossil_strcmp(zView,"byuser")){ |
| 2033 | stats_report_by_user(); |
| 2034 | }else{ |
| 2035 | @ <h1>Select a report to show:</h1> |
| 2036 | @ <ul> |
| 2037 | @ <li><a href='?view=byyear'>Events by year</a></li> |
| 2038 | @ <li><a href='?view=bymonth'>Events by month</a></li> |
| 2039 | @ <li><a href='?view=byuser'>Events by user</a></li> |
| 2040 | @ </ul> |
| 2041 | } |
| 2042 | |
| 2043 | style_footer(); |
| 2044 | } |
| 2045 |