Fossil SCM

Disabling the "auto paragraph" feature in the wiki renderer when styling an HTML "table" element. Without this, the first cell's contents gets wrapped in "p" tags, unnecessarily. (None of the other cells get this effect.) With thie trunk default skin, this extra tag was invisible, but with this branch's skin, it shows up as a double-height first row in every table. For tables with a header row, this may appear to be an intentional feature, but it's not; it's a rendering bug. Credit for this goes to Stephan Beal (the eminemnt repo archaeologist) plus whichever "anonymous" posted [/info/0fd3c7d243 | this ticket], way back in 2010!

wyoung 2024-02-03 23:03 inskinerator-modern-backport
Commit 6f94da9b6b2b049cbc4e0061cee659b33dfb09f04411814054aab02d865f63d7
1 file changed +1
--- src/wikiformat.c
+++ src/wikiformat.c
@@ -1781,10 +1781,11 @@
17811781
if( backupToType(p, MUTYPE_TABLE|MUTYPE_TR) ){
17821782
if( stackTopType(p)==MUTYPE_TABLE ){
17831783
pushStack(p, MARKUP_TR);
17841784
blob_append_string(p->pOut, "<tr>");
17851785
}
1786
+ p->wantAutoParagraph = 0;
17861787
pushStack(p, markup.iCode);
17871788
renderMarkup(p->pOut, &markup);
17881789
}
17891790
}else
17901791
if( markup.iType==MUTYPE_HYPERLINK ){
17911792
--- src/wikiformat.c
+++ src/wikiformat.c
@@ -1781,10 +1781,11 @@
1781 if( backupToType(p, MUTYPE_TABLE|MUTYPE_TR) ){
1782 if( stackTopType(p)==MUTYPE_TABLE ){
1783 pushStack(p, MARKUP_TR);
1784 blob_append_string(p->pOut, "<tr>");
1785 }
 
1786 pushStack(p, markup.iCode);
1787 renderMarkup(p->pOut, &markup);
1788 }
1789 }else
1790 if( markup.iType==MUTYPE_HYPERLINK ){
1791
--- src/wikiformat.c
+++ src/wikiformat.c
@@ -1781,10 +1781,11 @@
1781 if( backupToType(p, MUTYPE_TABLE|MUTYPE_TR) ){
1782 if( stackTopType(p)==MUTYPE_TABLE ){
1783 pushStack(p, MARKUP_TR);
1784 blob_append_string(p->pOut, "<tr>");
1785 }
1786 p->wantAutoParagraph = 0;
1787 pushStack(p, markup.iCode);
1788 renderMarkup(p->pOut, &markup);
1789 }
1790 }else
1791 if( markup.iType==MUTYPE_HYPERLINK ){
1792

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button