Fossil SCM

Do not redirect "diff" links on the "Show Files" option of the timeline to a different window. If the user wants to show the diff in a different window, let them click while holding down the Shift key.

drh 2013-05-27 02:00 trunk
Commit 71a916ee9507d6fbdcaf84a38176b46db19ef723
1 file changed +3 -6
+3 -6
--- src/timeline.c
+++ src/timeline.c
@@ -497,26 +497,23 @@
497497
}
498498
continue;
499499
}
500500
if( isNew ){
501501
@ <li> %h(zFilename) (new file) &nbsp;
502
- @ %z(xhref("target='diffwindow'","%R/artifact/%S",zNew))
503
- @ [view]</a></li>
502
+ @ %z(href("%R/artifact/%S",zNew))[view]</a></li>
504503
}else if( isDel ){
505504
@ <li> %h(zFilename) (deleted)</li>
506505
}else if( fossil_strcmp(zOld,zNew)==0 && zOldName!=0 ){
507506
@ <li> %h(zOldName) &rarr; %h(zFilename)
508
- @ %z(xhref("target='diffwindow'","%R/artifact/%S",zNew))
509
- @ [view]</a></li>
507
+ @ %z(href("%R/artifact/%S",zNew))[view]</a></li>
510508
}else{
511509
if( zOldName!=0 ){
512510
@ <li> %h(zOldName) &rarr; %h(zFilename)
513511
}else{
514512
@ <li> %h(zFilename) &nbsp;
515513
}
516
- @ %z(xhref("target='diffwindow'","%R/fdiff?v1=%S&v2=%S&sbs=1",zOld,zNew))
517
- @ [diff]</a></li>
514
+ @ %z(href("%R/fdiff?v1=%S&v2=%S&sbs=1",zOld,zNew))[diff]</a></li>
518515
}
519516
}
520517
db_reset(&fchngQuery);
521518
if( inUl ){
522519
@ </ul>
523520
--- src/timeline.c
+++ src/timeline.c
@@ -497,26 +497,23 @@
497 }
498 continue;
499 }
500 if( isNew ){
501 @ <li> %h(zFilename) (new file) &nbsp;
502 @ %z(xhref("target='diffwindow'","%R/artifact/%S",zNew))
503 @ [view]</a></li>
504 }else if( isDel ){
505 @ <li> %h(zFilename) (deleted)</li>
506 }else if( fossil_strcmp(zOld,zNew)==0 && zOldName!=0 ){
507 @ <li> %h(zOldName) &rarr; %h(zFilename)
508 @ %z(xhref("target='diffwindow'","%R/artifact/%S",zNew))
509 @ [view]</a></li>
510 }else{
511 if( zOldName!=0 ){
512 @ <li> %h(zOldName) &rarr; %h(zFilename)
513 }else{
514 @ <li> %h(zFilename) &nbsp;
515 }
516 @ %z(xhref("target='diffwindow'","%R/fdiff?v1=%S&v2=%S&sbs=1",zOld,zNew))
517 @ [diff]</a></li>
518 }
519 }
520 db_reset(&fchngQuery);
521 if( inUl ){
522 @ </ul>
523
--- src/timeline.c
+++ src/timeline.c
@@ -497,26 +497,23 @@
497 }
498 continue;
499 }
500 if( isNew ){
501 @ <li> %h(zFilename) (new file) &nbsp;
502 @ %z(href("%R/artifact/%S",zNew))[view]</a></li>
 
503 }else if( isDel ){
504 @ <li> %h(zFilename) (deleted)</li>
505 }else if( fossil_strcmp(zOld,zNew)==0 && zOldName!=0 ){
506 @ <li> %h(zOldName) &rarr; %h(zFilename)
507 @ %z(href("%R/artifact/%S",zNew))[view]</a></li>
 
508 }else{
509 if( zOldName!=0 ){
510 @ <li> %h(zOldName) &rarr; %h(zFilename)
511 }else{
512 @ <li> %h(zFilename) &nbsp;
513 }
514 @ %z(href("%R/fdiff?v1=%S&v2=%S&sbs=1",zOld,zNew))[diff]</a></li>
 
515 }
516 }
517 db_reset(&fchngQuery);
518 if( inUl ){
519 @ </ul>
520

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button