Fossil SCM

Added comments and documentation for the removal of d cap.

wyoung 2020-03-12 18:03 eradicate-d-cap
Commit 7454cce841beaf85eb0e9d65eff0aa4f2df5e628b6294951ed0ba80076f70178
Parent dfa6609a9ac5c7f…
3 files changed +4 +1 +16
~ src/capabilities.c ~ src/login.c ~ www/caps/ref.html
M src/capabilities.c
+4
--- src/capabilities.c
+++ src/capabilities.c
@@ -242,10 +242,14 @@
242242
 "Admin", "Create and delete users" },
243243
 { 'b', CAPCLASS_WIKI|CAPCLASS_TKT, 0,
244244
 "Attach", "Add attchments to wiki or tickets" },
245245
 { 'c', CAPCLASS_TKT, 0,
246246
 "Append-Tkt", "Append to existing tickets" },
247
+ /*
248
+ ** d unused since fork from CVSTrac;
249
+ ** see https://fossil-scm.org/forum/forumpost/43c78f4bef
250
+ */
247251
 { 'e', CAPCLASS_DATA, 0,
248252
 "View-PII", "View sensitive info such as email addresses" },
249253
 { 'f', CAPCLASS_WIKI, 0,
250254
 "New-Wiki", "Create new wiki pages" },
251255
 { 'g', CAPCLASS_DATA, 0,
252256
--- src/capabilities.c
+++ src/capabilities.c
@@ -242,10 +242,14 @@
242 "Admin", "Create and delete users" },
243 { 'b', CAPCLASS_WIKI|CAPCLASS_TKT, 0,
244 "Attach", "Add attchments to wiki or tickets" },
245 { 'c', CAPCLASS_TKT, 0,
246 "Append-Tkt", "Append to existing tickets" },
 
 
 
 
247 { 'e', CAPCLASS_DATA, 0,
248 "View-PII", "View sensitive info such as email addresses" },
249 { 'f', CAPCLASS_WIKI, 0,
250 "New-Wiki", "Create new wiki pages" },
251 { 'g', CAPCLASS_DATA, 0,
252
--- src/capabilities.c
+++ src/capabilities.c
@@ -242,10 +242,14 @@
242 "Admin", "Create and delete users" },
243 { 'b', CAPCLASS_WIKI|CAPCLASS_TKT, 0,
244 "Attach", "Add attchments to wiki or tickets" },
245 { 'c', CAPCLASS_TKT, 0,
246 "Append-Tkt", "Append to existing tickets" },
247 /*
248 ** d unused since fork from CVSTrac;
249 ** see https://fossil-scm.org/forum/forumpost/43c78f4bef
250 */
251 { 'e', CAPCLASS_DATA, 0,
252 "View-PII", "View sensitive info such as email addresses" },
253 { 'f', CAPCLASS_WIKI, 0,
254 "New-Wiki", "Create new wiki pages" },
255 { 'g', CAPCLASS_DATA, 0,
256
M src/login.c
+1
--- src/login.c
+++ src/login.c
@@ -1319,10 +1319,11 @@
13191319
 for(i=0; i<nCap && rc && zCap[i]; i++){
13201320
 switch( zCap[i] ){
13211321
 case 'a': rc = p->Admin; break;
13221322
 case 'b': rc = p->Attach; break;
13231323
 case 'c': rc = p->ApndTkt; break;
1324
+ /* d unused: see comment in capabilities.c */
13241325
 case 'e': rc = p->RdAddr; break;
13251326
 case 'f': rc = p->NewWiki; break;
13261327
 case 'g': rc = p->Clone; break;
13271328
 case 'h': rc = p->Hyperlink; break;
13281329
 case 'i': rc = p->Write; break;
13291330
--- src/login.c
+++ src/login.c
@@ -1319,10 +1319,11 @@
1319 for(i=0; i<nCap && rc && zCap[i]; i++){
1320 switch( zCap[i] ){
1321 case 'a': rc = p->Admin; break;
1322 case 'b': rc = p->Attach; break;
1323 case 'c': rc = p->ApndTkt; break;
 
1324 case 'e': rc = p->RdAddr; break;
1325 case 'f': rc = p->NewWiki; break;
1326 case 'g': rc = p->Clone; break;
1327 case 'h': rc = p->Hyperlink; break;
1328 case 'i': rc = p->Write; break;
1329
--- src/login.c
+++ src/login.c
@@ -1319,10 +1319,11 @@
1319 for(i=0; i<nCap && rc && zCap[i]; i++){
1320 switch( zCap[i] ){
1321 case 'a': rc = p->Admin; break;
1322 case 'b': rc = p->Attach; break;
1323 case 'c': rc = p->ApndTkt; break;
1324 /* d unused: see comment in capabilities.c */
1325 case 'e': rc = p->RdAddr; break;
1326 case 'f': rc = p->NewWiki; break;
1327 case 'g': rc = p->Clone; break;
1328 case 'h': rc = p->Hyperlink; break;
1329 case 'i': rc = p->Write; break;
1330
M www/caps/ref.html
+16
--- www/caps/ref.html
+++ www/caps/ref.html
@@ -70,10 +70,26 @@
7070
 <th>ApndTkt</th>
7171
 <td>
7272
 Append comments to existing tickets. Mnemonic: <b>c</b>omment.
7373
 </td>
7474
 </tr>
75
+
76
+ <tr id="d">
77
+ <th>d</th>
78
+ <th>n/a</th>
79
+ <td>
80
+ Legacy capability letter from Fossil's forebear <a
81
+ href="http://cvstrac.org/">CVSTrac</a>, which has no useful
82
+ meaning in Fossil due to its durable blockchain nature. This
83
+ letter was assigned by default to Developer in repos created with
84
+ Fossil 2.10 or earlier, but it has no effect in current or past
85
+ versions of Fossil; we recommend that you remove it in case we
86
+ ever reuse this letter for another purpose. See <a
87
+ href="https://fossil-scm.org/forum/forumpost/43c78f4bef">this
88
+ post</a> for details.
89
+ </td>
90
+ </tr>
7591
7692
 <tr id="e">
7793
 <th>e</th>
7894
 <th>RdAddr</th>
7995
 <td>
8096
--- www/caps/ref.html
+++ www/caps/ref.html
@@ -70,10 +70,26 @@
70 <th>ApndTkt</th>
71 <td>
72 Append comments to existing tickets. Mnemonic: <b>c</b>omment.
73 </td>
74 </tr>
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
75
76 <tr id="e">
77 <th>e</th>
78 <th>RdAddr</th>
79 <td>
80
--- www/caps/ref.html
+++ www/caps/ref.html
@@ -70,10 +70,26 @@
70 <th>ApndTkt</th>
71 <td>
72 Append comments to existing tickets. Mnemonic: <b>c</b>omment.
73 </td>
74 </tr>
75
76 <tr id="d">
77 <th>d</th>
78 <th>n/a</th>
79 <td>
80 Legacy capability letter from Fossil's forebear <a
81 href="http://cvstrac.org/">CVSTrac</a>, which has no useful
82 meaning in Fossil due to its durable blockchain nature. This
83 letter was assigned by default to Developer in repos created with
84 Fossil 2.10 or earlier, but it has no effect in current or past
85 versions of Fossil; we recommend that you remove it in case we
86 ever reuse this letter for another purpose. See <a
87 href="https://fossil-scm.org/forum/forumpost/43c78f4bef">this
88 post</a> for details.
89 </td>
90 </tr>
91
92 <tr id="e">
93 <th>e</th>
94 <th>RdAddr</th>
95 <td>
96

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button