Fossil SCM
Added a missing db_finalize() in piechart_render() for the empty chart case.
Commit
7913bba6109d8a109dd79dc2e7c3ff82052393db4697e32f166a0bbcf6bcef6e
Parent
b0a38d5fb3437d0…
1 file changed
+4
-1
+4
-1
| --- src/piechart.c | ||
| +++ src/piechart.c | ||
| @@ -142,11 +142,14 @@ | ||
| 142 | 142 | if( r<0.33333*r2 ) r = 0.33333*r2; |
| 143 | 143 | h = 0; |
| 144 | 144 | zFg = skin_detail_boolean("white-foreground") ? "white" : "black"; |
| 145 | 145 | |
| 146 | 146 | db_prepare(&q, "SELECT sum(amt), count(*) FROM piechart"); |
| 147 | - if( db_step(&q)!=SQLITE_ROW ) return; | |
| 147 | + if( db_step(&q)!=SQLITE_ROW ){ | |
| 148 | + db_finalize(&q); | |
| 149 | + return; | |
| 150 | + } | |
| 148 | 151 | rTotal = db_column_double(&q, 0); |
| 149 | 152 | nTotal = db_column_int(&q, 1); |
| 150 | 153 | db_finalize(&q); |
| 151 | 154 | rTooSmall = 0.0; |
| 152 | 155 | nTooSmall = 0; |
| 153 | 156 |
| --- src/piechart.c | |
| +++ src/piechart.c | |
| @@ -142,11 +142,14 @@ | |
| 142 | if( r<0.33333*r2 ) r = 0.33333*r2; |
| 143 | h = 0; |
| 144 | zFg = skin_detail_boolean("white-foreground") ? "white" : "black"; |
| 145 | |
| 146 | db_prepare(&q, "SELECT sum(amt), count(*) FROM piechart"); |
| 147 | if( db_step(&q)!=SQLITE_ROW ) return; |
| 148 | rTotal = db_column_double(&q, 0); |
| 149 | nTotal = db_column_int(&q, 1); |
| 150 | db_finalize(&q); |
| 151 | rTooSmall = 0.0; |
| 152 | nTooSmall = 0; |
| 153 |
| --- src/piechart.c | |
| +++ src/piechart.c | |
| @@ -142,11 +142,14 @@ | |
| 142 | if( r<0.33333*r2 ) r = 0.33333*r2; |
| 143 | h = 0; |
| 144 | zFg = skin_detail_boolean("white-foreground") ? "white" : "black"; |
| 145 | |
| 146 | db_prepare(&q, "SELECT sum(amt), count(*) FROM piechart"); |
| 147 | if( db_step(&q)!=SQLITE_ROW ){ |
| 148 | db_finalize(&q); |
| 149 | return; |
| 150 | } |
| 151 | rTotal = db_column_double(&q, 0); |
| 152 | nTotal = db_column_int(&q, 1); |
| 153 | db_finalize(&q); |
| 154 | rTooSmall = 0.0; |
| 155 | nTooSmall = 0; |
| 156 |