Fossil SCM

Fix crash in /reports page, when compiling with recent gcc. (this is NOT an -O2 optimization bug!)

jan.nijtmans 2015-06-02 08:17 trunk
Commit 8184f39d803f9ad6c8f8880996c6a9f3557f1d5d
1 file changed +1 -1
+1 -1
--- src/statrep.c
+++ src/statrep.c
@@ -672,10 +672,11 @@
672672
HQuery url; /* URL for various branch links */
673673
const char *zView = P("view"); /* Which view/report to show. */
674674
int eType = RPT_NONE; /* Numeric code for view/report to show */
675675
int i; /* Loop counter */
676676
const char *zUserName; /* Name of user */
677
+ const char *azView[16]; /* Drop-down menu of view types */
677678
const struct {
678679
const char *zName; /* Name of view= screen type */
679680
const char *zVal; /* Value of view= query parameter */
680681
int eType; /* Corresponding RPT_* define */
681682
} aViewType[] = {
@@ -712,11 +713,10 @@
712713
}
713714
url_initialize(&url, "reports");
714715
cgi_query_parameters_to_url(&url);
715716
if( eType!=RPT_NONE ){
716717
int nView = 0; /* Slots used in azView[] */
717
- const char *azView[16]; /* Drop-down menu of view types */
718718
for(i=0; i<ArraySize(aViewType); i++){
719719
azView[nView++] = aViewType[i].zVal;
720720
azView[nView++] = aViewType[i].zName;
721721
}
722722
if( eType!=RPT_BYFILE ){
723723
--- src/statrep.c
+++ src/statrep.c
@@ -672,10 +672,11 @@
672 HQuery url; /* URL for various branch links */
673 const char *zView = P("view"); /* Which view/report to show. */
674 int eType = RPT_NONE; /* Numeric code for view/report to show */
675 int i; /* Loop counter */
676 const char *zUserName; /* Name of user */
 
677 const struct {
678 const char *zName; /* Name of view= screen type */
679 const char *zVal; /* Value of view= query parameter */
680 int eType; /* Corresponding RPT_* define */
681 } aViewType[] = {
@@ -712,11 +713,10 @@
712 }
713 url_initialize(&url, "reports");
714 cgi_query_parameters_to_url(&url);
715 if( eType!=RPT_NONE ){
716 int nView = 0; /* Slots used in azView[] */
717 const char *azView[16]; /* Drop-down menu of view types */
718 for(i=0; i<ArraySize(aViewType); i++){
719 azView[nView++] = aViewType[i].zVal;
720 azView[nView++] = aViewType[i].zName;
721 }
722 if( eType!=RPT_BYFILE ){
723
--- src/statrep.c
+++ src/statrep.c
@@ -672,10 +672,11 @@
672 HQuery url; /* URL for various branch links */
673 const char *zView = P("view"); /* Which view/report to show. */
674 int eType = RPT_NONE; /* Numeric code for view/report to show */
675 int i; /* Loop counter */
676 const char *zUserName; /* Name of user */
677 const char *azView[16]; /* Drop-down menu of view types */
678 const struct {
679 const char *zName; /* Name of view= screen type */
680 const char *zVal; /* Value of view= query parameter */
681 int eType; /* Corresponding RPT_* define */
682 } aViewType[] = {
@@ -712,11 +713,10 @@
713 }
714 url_initialize(&url, "reports");
715 cgi_query_parameters_to_url(&url);
716 if( eType!=RPT_NONE ){
717 int nView = 0; /* Slots used in azView[] */
 
718 for(i=0; i<ArraySize(aViewType); i++){
719 azView[nView++] = aViewType[i].zVal;
720 azView[nView++] = aViewType[i].zName;
721 }
722 if( eType!=RPT_BYFILE ){
723

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button