Fossil SCM

Fix a coding mistake on an error path in the HTTP server logic. Because the mistake is on an error path, it is actually harmless, but it needs to be fixed nevertheless.

drh 2025-05-02 11:31 trunk
Commit 85067dc91967cef43ac73c789ad785325b6f486658c94f3eebe07c5ac87f53d0
1 file changed +1 -1
+1 -1
--- src/cgi.c
+++ src/cgi.c
@@ -2661,11 +2661,11 @@
26612661
listen4 = socket(AF_INET, SOCK_STREAM, 0);
26622662
if( listen4>0 ){
26632663
setsockopt(listen4, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
26642664
rc = bind(listen4, (struct sockaddr*)&inaddr4, sizeof(inaddr4));
26652665
if( rc<0 ){
2666
- close(listen6);
2666
+ close(listen4);
26672667
listen4 = -1;
26682668
}
26692669
}
26702670
if( listen4<0 ){
26712671
fossil_fatal("cannot open a listening socket on %s:%d",
26722672
--- src/cgi.c
+++ src/cgi.c
@@ -2661,11 +2661,11 @@
2661 listen4 = socket(AF_INET, SOCK_STREAM, 0);
2662 if( listen4>0 ){
2663 setsockopt(listen4, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
2664 rc = bind(listen4, (struct sockaddr*)&inaddr4, sizeof(inaddr4));
2665 if( rc<0 ){
2666 close(listen6);
2667 listen4 = -1;
2668 }
2669 }
2670 if( listen4<0 ){
2671 fossil_fatal("cannot open a listening socket on %s:%d",
2672
--- src/cgi.c
+++ src/cgi.c
@@ -2661,11 +2661,11 @@
2661 listen4 = socket(AF_INET, SOCK_STREAM, 0);
2662 if( listen4>0 ){
2663 setsockopt(listen4, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
2664 rc = bind(listen4, (struct sockaddr*)&inaddr4, sizeof(inaddr4));
2665 if( rc<0 ){
2666 close(listen4);
2667 listen4 = -1;
2668 }
2669 }
2670 if( listen4<0 ){
2671 fossil_fatal("cannot open a listening socket on %s:%d",
2672

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button