Fossil SCM

Remove a harmless comparison from the decompress() SQL function implementation.

drh 2020-12-09 16:15 trunk
Commit 87567ad869f0809f6beccc3f94c71a21f68bffd77ecdd203bb9217586ade6fd3
1 file changed -1
--- src/sqlcmd.c
+++ src/sqlcmd.c
@@ -119,11 +119,10 @@
119119
pIn = sqlite3_value_blob(argv[0]);
120120
if( pIn==0 ) return;
121121
nIn = sqlite3_value_bytes(argv[0]);
122122
if( nIn<4 ) return;
123123
nOut = (pIn[0]<<24) + (pIn[1]<<16) + (pIn[2]<<8) + pIn[3];
124
- if( nOut<0 ) return;
125124
pOut = sqlite3_malloc( nOut+1 );
126125
rc = uncompress(pOut, &nOut, &pIn[4], nIn-4);
127126
if( rc==Z_OK ){
128127
sqlite3_result_blob(context, pOut, nOut, sqlite3_free);
129128
}else if( rc==Z_MEM_ERROR ){
130129
--- src/sqlcmd.c
+++ src/sqlcmd.c
@@ -119,11 +119,10 @@
119 pIn = sqlite3_value_blob(argv[0]);
120 if( pIn==0 ) return;
121 nIn = sqlite3_value_bytes(argv[0]);
122 if( nIn<4 ) return;
123 nOut = (pIn[0]<<24) + (pIn[1]<<16) + (pIn[2]<<8) + pIn[3];
124 if( nOut<0 ) return;
125 pOut = sqlite3_malloc( nOut+1 );
126 rc = uncompress(pOut, &nOut, &pIn[4], nIn-4);
127 if( rc==Z_OK ){
128 sqlite3_result_blob(context, pOut, nOut, sqlite3_free);
129 }else if( rc==Z_MEM_ERROR ){
130
--- src/sqlcmd.c
+++ src/sqlcmd.c
@@ -119,11 +119,10 @@
119 pIn = sqlite3_value_blob(argv[0]);
120 if( pIn==0 ) return;
121 nIn = sqlite3_value_bytes(argv[0]);
122 if( nIn<4 ) return;
123 nOut = (pIn[0]<<24) + (pIn[1]<<16) + (pIn[2]<<8) + pIn[3];
 
124 pOut = sqlite3_malloc( nOut+1 );
125 rc = uncompress(pOut, &nOut, &pIn[4], nIn-4);
126 if( rc==Z_OK ){
127 sqlite3_result_blob(context, pOut, nOut, sqlite3_free);
128 }else if( rc==Z_MEM_ERROR ){
129

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button