Fossil SCM
Remove an unused static variable. Update the style guidelines to mention that imported code does not necessarily follow the guidelines.
Commit
8a53d4016ee960abe17c439edf2c11beb85fa5f627c3c11860c2181b474a2fcb
Parent
10f753a3ce924c5…
2 files changed
-9
+8
-2
-9
| --- src/setup.c | ||
| +++ src/setup.c | ||
| @@ -1385,19 +1385,10 @@ | ||
| 1385 | 1385 | "1", "HH:MM:SS", |
| 1386 | 1386 | "2", "YYYY-MM-DD HH:MM", |
| 1387 | 1387 | "3", "YYMMDD HH:MM", |
| 1388 | 1388 | "4", "(off)" |
| 1389 | 1389 | }; |
| 1390 | - static const char *const azCommentFormats[] = { | |
| 1391 | - "0", "[hash] comment (details)", | |
| 1392 | - "1", "[hash] comment", | |
| 1393 | - "2", "comment [hash] (details)", | |
| 1394 | - "3", "comment [hash]", | |
| 1395 | - "4", "comment (details)", | |
| 1396 | - "5", "comment-only", | |
| 1397 | - "12","comment | details", | |
| 1398 | - }; | |
| 1399 | 1390 | login_check_credentials(); |
| 1400 | 1391 | if( !g.perm.Setup ){ |
| 1401 | 1392 | login_needed(0); |
| 1402 | 1393 | return; |
| 1403 | 1394 | } |
| 1404 | 1395 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -1385,19 +1385,10 @@ | |
| 1385 | "1", "HH:MM:SS", |
| 1386 | "2", "YYYY-MM-DD HH:MM", |
| 1387 | "3", "YYMMDD HH:MM", |
| 1388 | "4", "(off)" |
| 1389 | }; |
| 1390 | static const char *const azCommentFormats[] = { |
| 1391 | "0", "[hash] comment (details)", |
| 1392 | "1", "[hash] comment", |
| 1393 | "2", "comment [hash] (details)", |
| 1394 | "3", "comment [hash]", |
| 1395 | "4", "comment (details)", |
| 1396 | "5", "comment-only", |
| 1397 | "12","comment | details", |
| 1398 | }; |
| 1399 | login_check_credentials(); |
| 1400 | if( !g.perm.Setup ){ |
| 1401 | login_needed(0); |
| 1402 | return; |
| 1403 | } |
| 1404 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -1385,19 +1385,10 @@ | |
| 1385 | "1", "HH:MM:SS", |
| 1386 | "2", "YYYY-MM-DD HH:MM", |
| 1387 | "3", "YYMMDD HH:MM", |
| 1388 | "4", "(off)" |
| 1389 | }; |
| 1390 | login_check_credentials(); |
| 1391 | if( !g.perm.Setup ){ |
| 1392 | login_needed(0); |
| 1393 | return; |
| 1394 | } |
| 1395 |
+8
-2
| --- www/style.wiki | ||
| +++ www/style.wiki | ||
| @@ -1,8 +1,15 @@ | ||
| 1 | 1 | <title>Coding Style</title> |
| 2 | 2 | |
| 3 | 3 | Fossil source code should following the style guidelines below. |
| 4 | + | |
| 5 | +<em> The Fossil source tree includes a few files taken from external | |
| 6 | +sources | |
| 7 | +(examples: [https://github.com/antirez/linenoise|linenoise] and | |
| 8 | +[http://zlib.net/|zLib]) | |
| 9 | +and this externally sourced code might not comply with these style guidelines. | |
| 10 | +</em> | |
| 4 | 11 | |
| 5 | 12 | <b>1. General points</b>: |
| 6 | 13 | |
| 7 | 14 | <ol> |
| 8 | 15 | <li value=10> No line of code exceeds 80 characters in length. (Occasional |
| @@ -35,12 +42,11 @@ | ||
| 35 | 42 | |
| 36 | 43 | <li> alloca(): By default, sqlite3.c is compiled with the -DSQLITE_USE_ALLOCA flag to use the alloca() function. |
| 37 | 44 | alloca() is not considered ANSI C, and normally not recommended due to portability issues, but |
| 38 | 45 | performance and/or memory consumption improvement may be a stronger argument in favor of its usage. |
| 39 | 46 | (sqlite3.c) |
| 40 | - | |
| 41 | - </ol> | |
| 47 | + </ol> | |
| 42 | 48 | |
| 43 | 49 | <li> All comments and identifiers are in English. |
| 44 | 50 | |
| 45 | 51 | <li> The program is single-threaded. Do not use threads. |
| 46 | 52 | (One exception to this is the HTTP server implementation for Windows, |
| 47 | 53 |
| --- www/style.wiki | |
| +++ www/style.wiki | |
| @@ -1,8 +1,15 @@ | |
| 1 | <title>Coding Style</title> |
| 2 | |
| 3 | Fossil source code should following the style guidelines below. |
| 4 | |
| 5 | <b>1. General points</b>: |
| 6 | |
| 7 | <ol> |
| 8 | <li value=10> No line of code exceeds 80 characters in length. (Occasional |
| @@ -35,12 +42,11 @@ | |
| 35 | |
| 36 | <li> alloca(): By default, sqlite3.c is compiled with the -DSQLITE_USE_ALLOCA flag to use the alloca() function. |
| 37 | alloca() is not considered ANSI C, and normally not recommended due to portability issues, but |
| 38 | performance and/or memory consumption improvement may be a stronger argument in favor of its usage. |
| 39 | (sqlite3.c) |
| 40 | |
| 41 | </ol> |
| 42 | |
| 43 | <li> All comments and identifiers are in English. |
| 44 | |
| 45 | <li> The program is single-threaded. Do not use threads. |
| 46 | (One exception to this is the HTTP server implementation for Windows, |
| 47 |
| --- www/style.wiki | |
| +++ www/style.wiki | |
| @@ -1,8 +1,15 @@ | |
| 1 | <title>Coding Style</title> |
| 2 | |
| 3 | Fossil source code should following the style guidelines below. |
| 4 | |
| 5 | <em> The Fossil source tree includes a few files taken from external |
| 6 | sources |
| 7 | (examples: [https://github.com/antirez/linenoise|linenoise] and |
| 8 | [http://zlib.net/|zLib]) |
| 9 | and this externally sourced code might not comply with these style guidelines. |
| 10 | </em> |
| 11 | |
| 12 | <b>1. General points</b>: |
| 13 | |
| 14 | <ol> |
| 15 | <li value=10> No line of code exceeds 80 characters in length. (Occasional |
| @@ -35,12 +42,11 @@ | |
| 42 | |
| 43 | <li> alloca(): By default, sqlite3.c is compiled with the -DSQLITE_USE_ALLOCA flag to use the alloca() function. |
| 44 | alloca() is not considered ANSI C, and normally not recommended due to portability issues, but |
| 45 | performance and/or memory consumption improvement may be a stronger argument in favor of its usage. |
| 46 | (sqlite3.c) |
| 47 | </ol> |
| 48 | |
| 49 | <li> All comments and identifiers are in English. |
| 50 | |
| 51 | <li> The program is single-threaded. Do not use threads. |
| 52 | (One exception to this is the HTTP server implementation for Windows, |
| 53 |