Fossil SCM

Avoid clobbering the last-sync-pw when doing sync --once.

andybradford 2013-11-01 08:11 UTC url-password-fixes
Commit 8bdc3ccd2bb8bb6f8edd27944b12c9938dbd4e7c
2 files changed +2 -2 +1 -2
+2 -2
--- src/url.c
+++ src/url.c
@@ -114,11 +114,11 @@
114114
/* Parse up the user-id and password */
115115
for(j=iStart; j<i && zUrl[j]!=':'; j++){}
116116
g.urlUser = mprintf("%.*s", j-iStart, &zUrl[iStart]);
117117
dehttpize(g.urlUser);
118118
if( j<i ){
119
- urlFlags |= URL_ASK_REMEMBER_PW;
119
+ if( urlFlags & URL_REMEMBER ) urlFlags |= URL_ASK_REMEMBER_PW;
120120
g.urlPasswd = mprintf("%.*s", i-j-1, &zUrl[j+1]);
121121
dehttpize(g.urlPasswd);
122122
}
123123
if( g.urlIsSsh && g.urlPasswd ){
124124
zLogin = mprintf("%t:*@", g.urlUser);
@@ -225,11 +225,11 @@
225225
g.urlCanonical = mprintf("file://%T", g.urlName);
226226
blob_reset(&cfile);
227227
}else if( g.urlUser!=0 && g.urlPasswd==0 && (urlFlags & URL_PROMPT_PW) ){
228228
url_prompt_for_password();
229229
bPrompted = 1;
230
- }else if( g.urlUser!=0 && (urlFlags & URL_ASK_REMEMBER_PW ) &&
230
+ }else if( g.urlUser!=0 && ( urlFlags & URL_ASK_REMEMBER_PW ) &&
231231
save_password_prompt() ){
232232
g.urlFlags = urlFlags |= URL_REMEMBER_PW;
233233
}
234234
if( urlFlags & URL_REMEMBER ){
235235
if( bSetUrl ){
236236
--- src/url.c
+++ src/url.c
@@ -114,11 +114,11 @@
114 /* Parse up the user-id and password */
115 for(j=iStart; j<i && zUrl[j]!=':'; j++){}
116 g.urlUser = mprintf("%.*s", j-iStart, &zUrl[iStart]);
117 dehttpize(g.urlUser);
118 if( j<i ){
119 urlFlags |= URL_ASK_REMEMBER_PW;
120 g.urlPasswd = mprintf("%.*s", i-j-1, &zUrl[j+1]);
121 dehttpize(g.urlPasswd);
122 }
123 if( g.urlIsSsh && g.urlPasswd ){
124 zLogin = mprintf("%t:*@", g.urlUser);
@@ -225,11 +225,11 @@
225 g.urlCanonical = mprintf("file://%T", g.urlName);
226 blob_reset(&cfile);
227 }else if( g.urlUser!=0 && g.urlPasswd==0 && (urlFlags & URL_PROMPT_PW) ){
228 url_prompt_for_password();
229 bPrompted = 1;
230 }else if( g.urlUser!=0 && (urlFlags & URL_ASK_REMEMBER_PW ) &&
231 save_password_prompt() ){
232 g.urlFlags = urlFlags |= URL_REMEMBER_PW;
233 }
234 if( urlFlags & URL_REMEMBER ){
235 if( bSetUrl ){
236
--- src/url.c
+++ src/url.c
@@ -114,11 +114,11 @@
114 /* Parse up the user-id and password */
115 for(j=iStart; j<i && zUrl[j]!=':'; j++){}
116 g.urlUser = mprintf("%.*s", j-iStart, &zUrl[iStart]);
117 dehttpize(g.urlUser);
118 if( j<i ){
119 if( urlFlags & URL_REMEMBER ) urlFlags |= URL_ASK_REMEMBER_PW;
120 g.urlPasswd = mprintf("%.*s", i-j-1, &zUrl[j+1]);
121 dehttpize(g.urlPasswd);
122 }
123 if( g.urlIsSsh && g.urlPasswd ){
124 zLogin = mprintf("%t:*@", g.urlUser);
@@ -225,11 +225,11 @@
225 g.urlCanonical = mprintf("file://%T", g.urlName);
226 blob_reset(&cfile);
227 }else if( g.urlUser!=0 && g.urlPasswd==0 && (urlFlags & URL_PROMPT_PW) ){
228 url_prompt_for_password();
229 bPrompted = 1;
230 }else if( g.urlUser!=0 && ( urlFlags & URL_ASK_REMEMBER_PW ) &&
231 save_password_prompt() ){
232 g.urlFlags = urlFlags |= URL_REMEMBER_PW;
233 }
234 if( urlFlags & URL_REMEMBER ){
235 if( bSetUrl ){
236
+1 -2
--- src/xfer.c
+++ src/xfer.c
@@ -1780,12 +1780,11 @@
17801780
if( fossil_strcmp(zMsg, "login failed")==0 ){
17811781
if( nCycle<2 ){
17821782
g.urlPasswd = 0;
17831783
go = 1;
17841784
if( g.cgiOutput==0 ){
1785
- g.urlFlags |= URL_PROMPT_PW | URL_ASK_REMEMBER_PW;
1786
- g.urlFlags |= URL_REMEMBER;
1785
+ g.urlFlags |= URL_PROMPT_PW;
17871786
url_prompt_for_password();
17881787
}
17891788
}
17901789
}else{
17911790
blob_appendf(&xfer.err, "server says: %s\n", zMsg);
17921791
--- src/xfer.c
+++ src/xfer.c
@@ -1780,12 +1780,11 @@
1780 if( fossil_strcmp(zMsg, "login failed")==0 ){
1781 if( nCycle<2 ){
1782 g.urlPasswd = 0;
1783 go = 1;
1784 if( g.cgiOutput==0 ){
1785 g.urlFlags |= URL_PROMPT_PW | URL_ASK_REMEMBER_PW;
1786 g.urlFlags |= URL_REMEMBER;
1787 url_prompt_for_password();
1788 }
1789 }
1790 }else{
1791 blob_appendf(&xfer.err, "server says: %s\n", zMsg);
1792
--- src/xfer.c
+++ src/xfer.c
@@ -1780,12 +1780,11 @@
1780 if( fossil_strcmp(zMsg, "login failed")==0 ){
1781 if( nCycle<2 ){
1782 g.urlPasswd = 0;
1783 go = 1;
1784 if( g.cgiOutput==0 ){
1785 g.urlFlags |= URL_PROMPT_PW;
 
1786 url_prompt_for_password();
1787 }
1788 }
1789 }else{
1790 blob_appendf(&xfer.err, "server says: %s\n", zMsg);
1791

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button