Fossil SCM
In /vdiff, exempt the 'from' and 'to' (branch names) args from the HTTP 418 response check because they otherwise trigger on some real-world branch names.
Commit
938fda79d49ede02c349137ca7e92925631c2ca07686f144134c50656f3b93c8
Parent
fc9c53abf1614b1…
1 file changed
+7
-2
+7
-2
| --- src/info.c | ||
| +++ src/info.c | ||
| @@ -1224,12 +1224,17 @@ | ||
| 1224 | 1224 | pTo = vdiff_parse_manifest("to", &ridTo); |
| 1225 | 1225 | if( pTo==0 ) return; |
| 1226 | 1226 | pFrom = vdiff_parse_manifest("from", &ridFrom); |
| 1227 | 1227 | if( pFrom==0 ) return; |
| 1228 | 1228 | zGlob = P("glob"); |
| 1229 | - zFrom = P_NoBot("from"); | |
| 1230 | - zTo = P_NoBot("to"); | |
| 1229 | + /* | |
| 1230 | + ** Maintenace reminder: we explicitly do _not_ use P_NoBot() | |
| 1231 | + ** for "from" and "to" because those args can contain legitimate | |
| 1232 | + ** strings which may trigger the looks-like SQL checks. | |
| 1233 | + */ | |
| 1234 | + zFrom = P("from"); | |
| 1235 | + zTo = P("to"); | |
| 1231 | 1236 | if( bInvert ){ |
| 1232 | 1237 | Manifest *pTemp = pTo; |
| 1233 | 1238 | const char *zTemp = zTo; |
| 1234 | 1239 | pTo = pFrom; |
| 1235 | 1240 | pFrom = pTemp; |
| 1236 | 1241 |
| --- src/info.c | |
| +++ src/info.c | |
| @@ -1224,12 +1224,17 @@ | |
| 1224 | pTo = vdiff_parse_manifest("to", &ridTo); |
| 1225 | if( pTo==0 ) return; |
| 1226 | pFrom = vdiff_parse_manifest("from", &ridFrom); |
| 1227 | if( pFrom==0 ) return; |
| 1228 | zGlob = P("glob"); |
| 1229 | zFrom = P_NoBot("from"); |
| 1230 | zTo = P_NoBot("to"); |
| 1231 | if( bInvert ){ |
| 1232 | Manifest *pTemp = pTo; |
| 1233 | const char *zTemp = zTo; |
| 1234 | pTo = pFrom; |
| 1235 | pFrom = pTemp; |
| 1236 |
| --- src/info.c | |
| +++ src/info.c | |
| @@ -1224,12 +1224,17 @@ | |
| 1224 | pTo = vdiff_parse_manifest("to", &ridTo); |
| 1225 | if( pTo==0 ) return; |
| 1226 | pFrom = vdiff_parse_manifest("from", &ridFrom); |
| 1227 | if( pFrom==0 ) return; |
| 1228 | zGlob = P("glob"); |
| 1229 | /* |
| 1230 | ** Maintenace reminder: we explicitly do _not_ use P_NoBot() |
| 1231 | ** for "from" and "to" because those args can contain legitimate |
| 1232 | ** strings which may trigger the looks-like SQL checks. |
| 1233 | */ |
| 1234 | zFrom = P("from"); |
| 1235 | zTo = P("to"); |
| 1236 | if( bInvert ){ |
| 1237 | Manifest *pTemp = pTo; |
| 1238 | const char *zTemp = zTo; |
| 1239 | pTo = pFrom; |
| 1240 | pFrom = pTemp; |
| 1241 |