Fossil SCM
Better comment why the group executable bit cannot be used on Cygwin, and possibly other IEEE 1003.1 ("POSIX.1") compliant systems, which support ACL's
Commit
9c3b544ec29e92f022b8fd69b87c57e0bb547d74
Parent
d9dfe11d0c8f859…
1 file changed
+4
-2
+4
-2
| --- src/file.c | ||
| +++ src/file.c | ||
| @@ -231,12 +231,14 @@ | ||
| 231 | 231 | symlink_create(blob_str(&content), zTo); |
| 232 | 232 | blob_reset(&content); |
| 233 | 233 | } |
| 234 | 234 | |
| 235 | 235 | #ifdef __CYGWIN__ |
| 236 | -/* Workaround for recently introduced Cygwin bug: group execute */ | |
| 237 | -/* permission is always set, so it cannot be relied upon! */ | |
| 236 | +/* On Cygwin (and possibly other IEEE 1003.1 ("POSIX.1") compliant systems) | |
| 237 | +** the group permission cannot be relied upon for security reasons. See: | |
| 238 | +** https://cygwin.com/faq/faq.html#faq.using.ssh-pubkey-stops-working | |
| 239 | +*/ | |
| 238 | 240 | # undef S_IXGRP |
| 239 | 241 | # define S_IXGRP 0 |
| 240 | 242 | #endif |
| 241 | 243 | |
| 242 | 244 | /* |
| 243 | 245 |
| --- src/file.c | |
| +++ src/file.c | |
| @@ -231,12 +231,14 @@ | |
| 231 | symlink_create(blob_str(&content), zTo); |
| 232 | blob_reset(&content); |
| 233 | } |
| 234 | |
| 235 | #ifdef __CYGWIN__ |
| 236 | /* Workaround for recently introduced Cygwin bug: group execute */ |
| 237 | /* permission is always set, so it cannot be relied upon! */ |
| 238 | # undef S_IXGRP |
| 239 | # define S_IXGRP 0 |
| 240 | #endif |
| 241 | |
| 242 | /* |
| 243 |
| --- src/file.c | |
| +++ src/file.c | |
| @@ -231,12 +231,14 @@ | |
| 231 | symlink_create(blob_str(&content), zTo); |
| 232 | blob_reset(&content); |
| 233 | } |
| 234 | |
| 235 | #ifdef __CYGWIN__ |
| 236 | /* On Cygwin (and possibly other IEEE 1003.1 ("POSIX.1") compliant systems) |
| 237 | ** the group permission cannot be relied upon for security reasons. See: |
| 238 | ** https://cygwin.com/faq/faq.html#faq.using.ssh-pubkey-stops-working |
| 239 | */ |
| 240 | # undef S_IXGRP |
| 241 | # define S_IXGRP 0 |
| 242 | #endif |
| 243 | |
| 244 | /* |
| 245 |