Fossil SCM

Update the /tarball and /zip pages to return status code 404 if given an unknown checkin to download.

drh 2017-06-09 13:09 trunk
Commit a10fc448ed3fce5113c2a44d18df0172c64a55624c4e21572566144106791b04
2 files changed +2 -1 +3 -2
+2 -1
--- src/tar.c
+++ src/tar.c
@@ -709,12 +709,13 @@
709709
zName[nName] = 0;
710710
break;
711711
}
712712
}
713713
}
714
- rid = name_to_typed_rid(nRid?zRid:zName, "ci");
714
+ rid = symbolic_name_to_rid(nRid?zRid:zName, "ci");
715715
if( rid==0 ){
716
+ cgi_set_status(404, "Not Found");
716717
@ Not found
717718
return;
718719
}
719720
if( nRid==0 && nName>10 ) zName[10] = 0;
720721
721722
--- src/tar.c
+++ src/tar.c
@@ -709,12 +709,13 @@
709 zName[nName] = 0;
710 break;
711 }
712 }
713 }
714 rid = name_to_typed_rid(nRid?zRid:zName, "ci");
715 if( rid==0 ){
 
716 @ Not found
717 return;
718 }
719 if( nRid==0 && nName>10 ) zName[10] = 0;
720
721
--- src/tar.c
+++ src/tar.c
@@ -709,12 +709,13 @@
709 zName[nName] = 0;
710 break;
711 }
712 }
713 }
714 rid = symbolic_name_to_rid(nRid?zRid:zName, "ci");
715 if( rid==0 ){
716 cgi_set_status(404, "Not Found");
717 @ Not found
718 return;
719 }
720 if( nRid==0 && nName>10 ) zName[10] = 0;
721
722
+3 -2
--- src/zip.c
+++ src/zip.c
@@ -565,12 +565,13 @@
565565
zName[nName] = 0;
566566
break;
567567
}
568568
}
569569
}
570
- rid = name_to_typed_rid(nRid?zRid:zName, "ci");
571
- if( rid==0 ){
570
+ rid = symbolic_name_to_rid(nRid?zRid:zName, "ci");
571
+ if( rid<=0 ){
572
+ cgi_set_status(404, "Not Found");
572573
@ Not found
573574
return;
574575
}
575576
if( nRid==0 && nName>10 ) zName[10] = 0;
576577
577578
--- src/zip.c
+++ src/zip.c
@@ -565,12 +565,13 @@
565 zName[nName] = 0;
566 break;
567 }
568 }
569 }
570 rid = name_to_typed_rid(nRid?zRid:zName, "ci");
571 if( rid==0 ){
 
572 @ Not found
573 return;
574 }
575 if( nRid==0 && nName>10 ) zName[10] = 0;
576
577
--- src/zip.c
+++ src/zip.c
@@ -565,12 +565,13 @@
565 zName[nName] = 0;
566 break;
567 }
568 }
569 }
570 rid = symbolic_name_to_rid(nRid?zRid:zName, "ci");
571 if( rid<=0 ){
572 cgi_set_status(404, "Not Found");
573 @ Not found
574 return;
575 }
576 if( nRid==0 && nName>10 ) zName[10] = 0;
577
578

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button