Fossil SCM
Remove comments calling for a now-resolved TODO. No code changes.
Commit
a5521984c32fae7a8a44cba0ad6ffed2fb1323456ebe6e30e4c5f0424ceae17a
Parent
39b4bd9c06fb0d2…
1 file changed
-15
-15
| --- src/fossil.page.chat.js | ||
| +++ src/fossil.page.chat.js | ||
| @@ -2649,25 +2649,10 @@ | ||
| 2649 | 2649 | //console.log("isOkay =",isOkay,"currentDelay =",Chat.timer.currentDelay); |
| 2650 | 2650 | } |
| 2651 | 2651 | }; |
| 2652 | 2652 | afterPollFetch.isFirstCall = true; |
| 2653 | 2653 | |
| 2654 | - /** | |
| 2655 | - FIXME: when polling fails because the remote server is | |
| 2656 | - reachable but it's not accepting HTTP requests, we should back | |
| 2657 | - off on polling for a while. e.g. if the remote web server process | |
| 2658 | - is killed, the poll fails quickly and immediately retries, | |
| 2659 | - hammering the remote server until the httpd is back up. That | |
| 2660 | - happens often during development of this application. | |
| 2661 | - | |
| 2662 | - XHR does not offer a direct way of distinguishing between | |
| 2663 | - HTTP/connection errors, but we can hypothetically use the | |
| 2664 | - xhrRequest.status value to do so, with status==0 being a | |
| 2665 | - connection error. We do not currently have a clean way of passing | |
| 2666 | - that info back to the fossil.fetch() client, so we'll need to | |
| 2667 | - hammer on that API a bit to get this working. | |
| 2668 | - */ | |
| 2669 | 2654 | const poll = Chat.poll = async function f(){ |
| 2670 | 2655 | if(f.running) return; |
| 2671 | 2656 | f.running = true; |
| 2672 | 2657 | Chat._isBatchLoading = f.isFirstCall; |
| 2673 | 2658 | if(true===f.isFirstCall){ |
| 2674 | 2659 |
| --- src/fossil.page.chat.js | |
| +++ src/fossil.page.chat.js | |
| @@ -2649,25 +2649,10 @@ | |
| 2649 | //console.log("isOkay =",isOkay,"currentDelay =",Chat.timer.currentDelay); |
| 2650 | } |
| 2651 | }; |
| 2652 | afterPollFetch.isFirstCall = true; |
| 2653 | |
| 2654 | /** |
| 2655 | FIXME: when polling fails because the remote server is |
| 2656 | reachable but it's not accepting HTTP requests, we should back |
| 2657 | off on polling for a while. e.g. if the remote web server process |
| 2658 | is killed, the poll fails quickly and immediately retries, |
| 2659 | hammering the remote server until the httpd is back up. That |
| 2660 | happens often during development of this application. |
| 2661 | |
| 2662 | XHR does not offer a direct way of distinguishing between |
| 2663 | HTTP/connection errors, but we can hypothetically use the |
| 2664 | xhrRequest.status value to do so, with status==0 being a |
| 2665 | connection error. We do not currently have a clean way of passing |
| 2666 | that info back to the fossil.fetch() client, so we'll need to |
| 2667 | hammer on that API a bit to get this working. |
| 2668 | */ |
| 2669 | const poll = Chat.poll = async function f(){ |
| 2670 | if(f.running) return; |
| 2671 | f.running = true; |
| 2672 | Chat._isBatchLoading = f.isFirstCall; |
| 2673 | if(true===f.isFirstCall){ |
| 2674 |
| --- src/fossil.page.chat.js | |
| +++ src/fossil.page.chat.js | |
| @@ -2649,25 +2649,10 @@ | |
| 2649 | //console.log("isOkay =",isOkay,"currentDelay =",Chat.timer.currentDelay); |
| 2650 | } |
| 2651 | }; |
| 2652 | afterPollFetch.isFirstCall = true; |
| 2653 | |
| 2654 | const poll = Chat.poll = async function f(){ |
| 2655 | if(f.running) return; |
| 2656 | f.running = true; |
| 2657 | Chat._isBatchLoading = f.isFirstCall; |
| 2658 | if(true===f.isFirstCall){ |
| 2659 |