Fossil SCM
If 'newbranch' field only contains spaces, consider it empty. Add missing MSVC linker option to the makemake.tcl script. Cherrypick of [5ceef9bcdd] and [c6f255607b].
Commit
afbc49cd2728a0e40bf70c778a573870010616e0
Parent
b7ff13a0aa6317f…
4 files changed
+3
-3
+1
-1
+1
-1
+1
-1
+3
-3
| --- src/info.c | ||
| +++ src/info.c | ||
| @@ -2204,12 +2204,12 @@ | ||
| 2204 | 2204 | ** chgcbn/chgbn: Handle change of (checkbox for) branch name in |
| 2205 | 2205 | ** remaining of form. |
| 2206 | 2206 | */ |
| 2207 | 2207 | @ <script> |
| 2208 | 2208 | @ function chgcbn(checked, branch){ |
| 2209 | - @ val = gebi('brname').value; | |
| 2210 | - @ if( !val || !checked) val = branch; | |
| 2209 | + @ val = gebi('brname').value.trim(); | |
| 2210 | + @ if( !val || !checked ) val = branch; | |
| 2211 | 2211 | @ cidbrid = document.getElementById('cbranch'); |
| 2212 | 2212 | @ if( cidbrid ) cidbrid.textContent = val; |
| 2213 | 2213 | @ } |
| 2214 | 2214 | @ function chgbn(val, branch){ |
| 2215 | 2215 | @ if( !val ) val = branch; |
| @@ -2348,11 +2348,11 @@ | ||
| 2348 | 2348 | @ <label><input id="newbr" type="checkbox" name="newbr"%s(zNewBrFlag) |
| 2349 | 2349 | @ onchange="chgcbn(this.checked,'%h(zBranchName)')" /> |
| 2350 | 2350 | @ Make this check-in the start of a new branch named:</label> |
| 2351 | 2351 | @ <input id="brname" type="text" style="width:15;" name="brname" |
| 2352 | 2352 | @ value="%h(zNewBranch)" |
| 2353 | - @ onkeyup="chgbn(this.value,'%h(zBranchName)')" /></td></tr> | |
| 2353 | + @ onkeyup="chgbn(this.value.trim(),'%h(zBranchName)')" /></td></tr> | |
| 2354 | 2354 | if( !fHasClosed ){ |
| 2355 | 2355 | if( is_a_leaf(rid) ){ |
| 2356 | 2356 | @ <tr><th align="right" valign="top">Leaf Closure:</th> |
| 2357 | 2357 | @ <td valign="top"> |
| 2358 | 2358 | @ <label><input type="checkbox" name="close"%s(zCloseFlag) /> |
| 2359 | 2359 |
| --- src/info.c | |
| +++ src/info.c | |
| @@ -2204,12 +2204,12 @@ | |
| 2204 | ** chgcbn/chgbn: Handle change of (checkbox for) branch name in |
| 2205 | ** remaining of form. |
| 2206 | */ |
| 2207 | @ <script> |
| 2208 | @ function chgcbn(checked, branch){ |
| 2209 | @ val = gebi('brname').value; |
| 2210 | @ if( !val || !checked) val = branch; |
| 2211 | @ cidbrid = document.getElementById('cbranch'); |
| 2212 | @ if( cidbrid ) cidbrid.textContent = val; |
| 2213 | @ } |
| 2214 | @ function chgbn(val, branch){ |
| 2215 | @ if( !val ) val = branch; |
| @@ -2348,11 +2348,11 @@ | |
| 2348 | @ <label><input id="newbr" type="checkbox" name="newbr"%s(zNewBrFlag) |
| 2349 | @ onchange="chgcbn(this.checked,'%h(zBranchName)')" /> |
| 2350 | @ Make this check-in the start of a new branch named:</label> |
| 2351 | @ <input id="brname" type="text" style="width:15;" name="brname" |
| 2352 | @ value="%h(zNewBranch)" |
| 2353 | @ onkeyup="chgbn(this.value,'%h(zBranchName)')" /></td></tr> |
| 2354 | if( !fHasClosed ){ |
| 2355 | if( is_a_leaf(rid) ){ |
| 2356 | @ <tr><th align="right" valign="top">Leaf Closure:</th> |
| 2357 | @ <td valign="top"> |
| 2358 | @ <label><input type="checkbox" name="close"%s(zCloseFlag) /> |
| 2359 |
| --- src/info.c | |
| +++ src/info.c | |
| @@ -2204,12 +2204,12 @@ | |
| 2204 | ** chgcbn/chgbn: Handle change of (checkbox for) branch name in |
| 2205 | ** remaining of form. |
| 2206 | */ |
| 2207 | @ <script> |
| 2208 | @ function chgcbn(checked, branch){ |
| 2209 | @ val = gebi('brname').value.trim(); |
| 2210 | @ if( !val || !checked ) val = branch; |
| 2211 | @ cidbrid = document.getElementById('cbranch'); |
| 2212 | @ if( cidbrid ) cidbrid.textContent = val; |
| 2213 | @ } |
| 2214 | @ function chgbn(val, branch){ |
| 2215 | @ if( !val ) val = branch; |
| @@ -2348,11 +2348,11 @@ | |
| 2348 | @ <label><input id="newbr" type="checkbox" name="newbr"%s(zNewBrFlag) |
| 2349 | @ onchange="chgcbn(this.checked,'%h(zBranchName)')" /> |
| 2350 | @ Make this check-in the start of a new branch named:</label> |
| 2351 | @ <input id="brname" type="text" style="width:15;" name="brname" |
| 2352 | @ value="%h(zNewBranch)" |
| 2353 | @ onkeyup="chgbn(this.value.trim(),'%h(zBranchName)')" /></td></tr> |
| 2354 | if( !fHasClosed ){ |
| 2355 | if( is_a_leaf(rid) ){ |
| 2356 | @ <tr><th align="right" valign="top">Leaf Closure:</th> |
| 2357 | @ <td valign="top"> |
| 2358 | @ <label><input type="checkbox" name="close"%s(zCloseFlag) /> |
| 2359 |
+1
-1
| --- src/makemake.tcl | ||
| +++ src/makemake.tcl | ||
| @@ -1035,11 +1035,11 @@ | ||
| 1035 | 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | 1037 | !endif |
| 1038 | 1038 | |
| 1039 | 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | -LDFLAGS = /NODEFAULTLIB:msvcrt | |
| 1040 | +LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO | |
| 1041 | 1041 | |
| 1042 | 1042 | !ifdef DEBUG |
| 1043 | 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | 1045 | !endif |
| 1046 | 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |
+1
-1
| --- src/makemake.tcl | ||
| +++ src/makemake.tcl | ||
| @@ -1035,11 +1035,11 @@ | ||
| 1035 | 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | 1037 | !endif |
| 1038 | 1038 | |
| 1039 | 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | -LDFLAGS = /NODEFAULTLIB:msvcrt | |
| 1040 | +LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO | |
| 1041 | 1041 | |
| 1042 | 1042 | !ifdef DEBUG |
| 1043 | 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | 1045 | !endif |
| 1046 | 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |
+1
-1
| --- src/makemake.tcl | ||
| +++ src/makemake.tcl | ||
| @@ -1035,11 +1035,11 @@ | ||
| 1035 | 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | 1037 | !endif |
| 1038 | 1038 | |
| 1039 | 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | -LDFLAGS = /NODEFAULTLIB:msvcrt | |
| 1040 | +LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO | |
| 1041 | 1041 | |
| 1042 | 1042 | !ifdef DEBUG |
| 1043 | 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | 1045 | !endif |
| 1046 | 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |
| --- src/makemake.tcl | |
| +++ src/makemake.tcl | |
| @@ -1035,11 +1035,11 @@ | |
| 1035 | !ifdef FOSSIL_ENABLE_SSL |
| 1036 | INCL = $(INCL) -I$(SSLINCDIR) |
| 1037 | !endif |
| 1038 | |
| 1039 | CFLAGS = -nologo -MT -O2 |
| 1040 | LDFLAGS = /NODEFAULTLIB:msvcrt /MANIFEST:NO |
| 1041 | |
| 1042 | !ifdef DEBUG |
| 1043 | CFLAGS = $(CFLAGS) -Zi |
| 1044 | LDFLAGS = $(LDFLAGS) /DEBUG |
| 1045 | !endif |
| 1046 |