Fossil SCM
Moved a db_finalize() which would not have been called in a couple of error cases.
Commit
afc1cec6a308d040b5a81f0241e5806352b1c332
Parent
65e946c7141c21e…
1 file changed
+1
-1
+1
-1
| --- src/json.c | ||
| +++ src/json.c | ||
| @@ -1292,17 +1292,17 @@ | ||
| 1292 | 1292 | }else if( 0 != cson_array_append( list, v ) ){ |
| 1293 | 1293 | cson_value_free(v); |
| 1294 | 1294 | goto error; |
| 1295 | 1295 | } |
| 1296 | 1296 | } |
| 1297 | - db_finalize(&q); | |
| 1298 | 1297 | goto end; |
| 1299 | 1298 | error: |
| 1300 | 1299 | g.json.resultCode = FSL_JSON_E_UNKNOWN; |
| 1301 | 1300 | cson_value_free(listV); |
| 1302 | 1301 | listV = NULL; |
| 1303 | 1302 | end: |
| 1303 | + db_finalize(&q); | |
| 1304 | 1304 | return listV; |
| 1305 | 1305 | } |
| 1306 | 1306 | |
| 1307 | 1307 | /* |
| 1308 | 1308 | ** Mapping of names to JSON pages/commands. Each name is a subpath of |
| 1309 | 1309 |
| --- src/json.c | |
| +++ src/json.c | |
| @@ -1292,17 +1292,17 @@ | |
| 1292 | }else if( 0 != cson_array_append( list, v ) ){ |
| 1293 | cson_value_free(v); |
| 1294 | goto error; |
| 1295 | } |
| 1296 | } |
| 1297 | db_finalize(&q); |
| 1298 | goto end; |
| 1299 | error: |
| 1300 | g.json.resultCode = FSL_JSON_E_UNKNOWN; |
| 1301 | cson_value_free(listV); |
| 1302 | listV = NULL; |
| 1303 | end: |
| 1304 | return listV; |
| 1305 | } |
| 1306 | |
| 1307 | /* |
| 1308 | ** Mapping of names to JSON pages/commands. Each name is a subpath of |
| 1309 |
| --- src/json.c | |
| +++ src/json.c | |
| @@ -1292,17 +1292,17 @@ | |
| 1292 | }else if( 0 != cson_array_append( list, v ) ){ |
| 1293 | cson_value_free(v); |
| 1294 | goto error; |
| 1295 | } |
| 1296 | } |
| 1297 | goto end; |
| 1298 | error: |
| 1299 | g.json.resultCode = FSL_JSON_E_UNKNOWN; |
| 1300 | cson_value_free(listV); |
| 1301 | listV = NULL; |
| 1302 | end: |
| 1303 | db_finalize(&q); |
| 1304 | return listV; |
| 1305 | } |
| 1306 | |
| 1307 | /* |
| 1308 | ** Mapping of names to JSON pages/commands. Each name is a subpath of |
| 1309 |