Fossil SCM
Ensure chars are signed when depending on the signedness.
Commit
b7c7c2097f108c7b409cc5e2fc7b02e8d7ae1fea57f54de6f0a733016353256e
Parent
a8780e4143a8147…
2 files changed
+1
-1
+3
-3
+1
-1
| --- src/json_finfo.c | ||
| +++ src/json_finfo.c | ||
| @@ -36,11 +36,11 @@ | ||
| 36 | 36 | char const * zAfter = NULL; |
| 37 | 37 | char const * zBefore = NULL; |
| 38 | 38 | int limit = -1; |
| 39 | 39 | int currentRow = 0; |
| 40 | 40 | char const * zCheckin = NULL; |
| 41 | - char sort = -1; | |
| 41 | + signed char sort = -1; | |
| 42 | 42 | if(!g.perm.Read){ |
| 43 | 43 | json_set_err(FSL_JSON_E_DENIED,"Requires 'o' privileges."); |
| 44 | 44 | return NULL; |
| 45 | 45 | } |
| 46 | 46 | json_warn( FSL_JSON_W_UNKNOWN, "Achtung: the output of the finfo command is up for change."); |
| 47 | 47 |
| --- src/json_finfo.c | |
| +++ src/json_finfo.c | |
| @@ -36,11 +36,11 @@ | |
| 36 | char const * zAfter = NULL; |
| 37 | char const * zBefore = NULL; |
| 38 | int limit = -1; |
| 39 | int currentRow = 0; |
| 40 | char const * zCheckin = NULL; |
| 41 | char sort = -1; |
| 42 | if(!g.perm.Read){ |
| 43 | json_set_err(FSL_JSON_E_DENIED,"Requires 'o' privileges."); |
| 44 | return NULL; |
| 45 | } |
| 46 | json_warn( FSL_JSON_W_UNKNOWN, "Achtung: the output of the finfo command is up for change."); |
| 47 |
| --- src/json_finfo.c | |
| +++ src/json_finfo.c | |
| @@ -36,11 +36,11 @@ | |
| 36 | char const * zAfter = NULL; |
| 37 | char const * zBefore = NULL; |
| 38 | int limit = -1; |
| 39 | int currentRow = 0; |
| 40 | char const * zCheckin = NULL; |
| 41 | signed char sort = -1; |
| 42 | if(!g.perm.Read){ |
| 43 | json_set_err(FSL_JSON_E_DENIED,"Requires 'o' privileges."); |
| 44 | return NULL; |
| 45 | } |
| 46 | json_warn( FSL_JSON_W_UNKNOWN, "Achtung: the output of the finfo command is up for change."); |
| 47 |
+3
-3
| --- src/json_timeline.c | ||
| +++ src/json_timeline.c | ||
| @@ -143,12 +143,12 @@ | ||
| 143 | 143 | ** property is set to the tag/branch name found in the request. |
| 144 | 144 | ** |
| 145 | 145 | ** Only one of "tag" or "branch" modes will work at a time, and if |
| 146 | 146 | ** both are specified, which one takes precedence is unspecified. |
| 147 | 147 | */ |
| 148 | -static char json_timeline_add_tag_branch_clause(Blob *pSql, | |
| 149 | - cson_object * pPayload){ | |
| 148 | +static signed char json_timeline_add_tag_branch_clause(Blob *pSql, | |
| 149 | + cson_object * pPayload){ | |
| 150 | 150 | char const * zTag = NULL; |
| 151 | 151 | char const * zBranch = NULL; |
| 152 | 152 | char const * zMiOnly = NULL; |
| 153 | 153 | char const * zUnhide = NULL; |
| 154 | 154 | int tagid = 0; |
| @@ -220,11 +220,11 @@ | ||
| 220 | 220 | ** applies one of them. |
| 221 | 221 | ** |
| 222 | 222 | ** Returns -1 if it adds a "before" clause, 1 if it adds |
| 223 | 223 | ** an "after" clause, and 0 if adds only an order-by clause. |
| 224 | 224 | */ |
| 225 | -static char json_timeline_add_time_clause(Blob *pSql){ | |
| 225 | +static signed char json_timeline_add_time_clause(Blob *pSql){ | |
| 226 | 226 | char const * zAfter = NULL; |
| 227 | 227 | char const * zBefore = NULL; |
| 228 | 228 | int rc = 0; |
| 229 | 229 | zAfter = json_find_option_cstr("after",NULL,"a"); |
| 230 | 230 | zBefore = zAfter ? NULL : json_find_option_cstr("before",NULL,"b"); |
| 231 | 231 |
| --- src/json_timeline.c | |
| +++ src/json_timeline.c | |
| @@ -143,12 +143,12 @@ | |
| 143 | ** property is set to the tag/branch name found in the request. |
| 144 | ** |
| 145 | ** Only one of "tag" or "branch" modes will work at a time, and if |
| 146 | ** both are specified, which one takes precedence is unspecified. |
| 147 | */ |
| 148 | static char json_timeline_add_tag_branch_clause(Blob *pSql, |
| 149 | cson_object * pPayload){ |
| 150 | char const * zTag = NULL; |
| 151 | char const * zBranch = NULL; |
| 152 | char const * zMiOnly = NULL; |
| 153 | char const * zUnhide = NULL; |
| 154 | int tagid = 0; |
| @@ -220,11 +220,11 @@ | |
| 220 | ** applies one of them. |
| 221 | ** |
| 222 | ** Returns -1 if it adds a "before" clause, 1 if it adds |
| 223 | ** an "after" clause, and 0 if adds only an order-by clause. |
| 224 | */ |
| 225 | static char json_timeline_add_time_clause(Blob *pSql){ |
| 226 | char const * zAfter = NULL; |
| 227 | char const * zBefore = NULL; |
| 228 | int rc = 0; |
| 229 | zAfter = json_find_option_cstr("after",NULL,"a"); |
| 230 | zBefore = zAfter ? NULL : json_find_option_cstr("before",NULL,"b"); |
| 231 |
| --- src/json_timeline.c | |
| +++ src/json_timeline.c | |
| @@ -143,12 +143,12 @@ | |
| 143 | ** property is set to the tag/branch name found in the request. |
| 144 | ** |
| 145 | ** Only one of "tag" or "branch" modes will work at a time, and if |
| 146 | ** both are specified, which one takes precedence is unspecified. |
| 147 | */ |
| 148 | static signed char json_timeline_add_tag_branch_clause(Blob *pSql, |
| 149 | cson_object * pPayload){ |
| 150 | char const * zTag = NULL; |
| 151 | char const * zBranch = NULL; |
| 152 | char const * zMiOnly = NULL; |
| 153 | char const * zUnhide = NULL; |
| 154 | int tagid = 0; |
| @@ -220,11 +220,11 @@ | |
| 220 | ** applies one of them. |
| 221 | ** |
| 222 | ** Returns -1 if it adds a "before" clause, 1 if it adds |
| 223 | ** an "after" clause, and 0 if adds only an order-by clause. |
| 224 | */ |
| 225 | static signed char json_timeline_add_time_clause(Blob *pSql){ |
| 226 | char const * zAfter = NULL; |
| 227 | char const * zBefore = NULL; |
| 228 | int rc = 0; |
| 229 | zAfter = json_find_option_cstr("after",NULL,"a"); |
| 230 | zBefore = zAfter ? NULL : json_find_option_cstr("before",NULL,"b"); |
| 231 |