Fossil SCM

Add comment to ourselves that copying the rebuild loop design into test-integrity will speed up test-integrity significantly.

danshearer 2026-10-26 14:35 UTC trunk
Commit c088cf957fffc55b4faaaf97ee5563ebe23a88e97fe5c20846485eff8b752776
1 file changed +2
--- src/content.c
+++ src/content.c
@@ -1046,10 +1046,12 @@
10461046
);
10471047
nErr++;
10481048
}
10491049
db_finalize(&q);
10501050
1051
+ /* This test-integrity loop is inefficient. Need to copy the rebuild loop
1052
+ ** design here */
10511053
db_prepare(&q, "SELECT rid, uuid, size FROM blob ORDER BY rid");
10521054
total = db_int(0, "SELECT max(rid) FROM blob");
10531055
while( db_step(&q)==SQLITE_ROW ){
10541056
int rid = db_column_int(&q, 0);
10551057
const char *zUuid = db_column_text(&q, 1);
10561058
--- src/content.c
+++ src/content.c
@@ -1046,10 +1046,12 @@
1046 );
1047 nErr++;
1048 }
1049 db_finalize(&q);
1050
 
 
1051 db_prepare(&q, "SELECT rid, uuid, size FROM blob ORDER BY rid");
1052 total = db_int(0, "SELECT max(rid) FROM blob");
1053 while( db_step(&q)==SQLITE_ROW ){
1054 int rid = db_column_int(&q, 0);
1055 const char *zUuid = db_column_text(&q, 1);
1056
--- src/content.c
+++ src/content.c
@@ -1046,10 +1046,12 @@
1046 );
1047 nErr++;
1048 }
1049 db_finalize(&q);
1050
1051 /* This test-integrity loop is inefficient. Need to copy the rebuild loop
1052 ** design here */
1053 db_prepare(&q, "SELECT rid, uuid, size FROM blob ORDER BY rid");
1054 total = db_int(0, "SELECT max(rid) FROM blob");
1055 while( db_step(&q)==SQLITE_ROW ){
1056 int rid = db_column_int(&q, 0);
1057 const char *zUuid = db_column_text(&q, 1);
1058

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button