Fossil SCM
TR-click event handling simplification.
Commit
c7f3d04244c378276f275d54aed51dda5c55c42db2cc8774c11b5c3c8879d7fc
Parent
49a60a580de9f3c…
1 file changed
+1
-7
+1
-7
| --- src/fossil.diff.js | ||
| +++ src/fossil.diff.js | ||
| @@ -188,19 +188,13 @@ | ||
| 188 | 188 | if(!tables.length) return F; |
| 189 | 189 | const addDiffSkipToTr = function f(tr){ |
| 190 | 190 | D.addClass(tr, 'jchunk'); |
| 191 | 191 | if(!f._handler){ |
| 192 | 192 | f._handler = function ff(event){ |
| 193 | - var e = event.target; | |
| 194 | - while(e && 'TR' !== e.tagName) e = e.parentElement; | |
| 195 | - if(!e){ | |
| 196 | - console.error("Internal event-handling error: didn't find TR target."); | |
| 197 | - return; | |
| 198 | - } | |
| 193 | + const e = this; | |
| 199 | 194 | e.removeEventListener('click',ff); |
| 200 | 195 | D.removeClass(e, 'jchunk', 'diffskip'); |
| 201 | - //console.debug("addDiffSkipToTr() Event:",e, event); | |
| 202 | 196 | fetchTrChunk(e); |
| 203 | 197 | }; |
| 204 | 198 | } |
| 205 | 199 | tr.addEventListener('click', f._handler, false); |
| 206 | 200 | }; |
| 207 | 201 |
| --- src/fossil.diff.js | |
| +++ src/fossil.diff.js | |
| @@ -188,19 +188,13 @@ | |
| 188 | if(!tables.length) return F; |
| 189 | const addDiffSkipToTr = function f(tr){ |
| 190 | D.addClass(tr, 'jchunk'); |
| 191 | if(!f._handler){ |
| 192 | f._handler = function ff(event){ |
| 193 | var e = event.target; |
| 194 | while(e && 'TR' !== e.tagName) e = e.parentElement; |
| 195 | if(!e){ |
| 196 | console.error("Internal event-handling error: didn't find TR target."); |
| 197 | return; |
| 198 | } |
| 199 | e.removeEventListener('click',ff); |
| 200 | D.removeClass(e, 'jchunk', 'diffskip'); |
| 201 | //console.debug("addDiffSkipToTr() Event:",e, event); |
| 202 | fetchTrChunk(e); |
| 203 | }; |
| 204 | } |
| 205 | tr.addEventListener('click', f._handler, false); |
| 206 | }; |
| 207 |
| --- src/fossil.diff.js | |
| +++ src/fossil.diff.js | |
| @@ -188,19 +188,13 @@ | |
| 188 | if(!tables.length) return F; |
| 189 | const addDiffSkipToTr = function f(tr){ |
| 190 | D.addClass(tr, 'jchunk'); |
| 191 | if(!f._handler){ |
| 192 | f._handler = function ff(event){ |
| 193 | const e = this; |
| 194 | e.removeEventListener('click',ff); |
| 195 | D.removeClass(e, 'jchunk', 'diffskip'); |
| 196 | fetchTrChunk(e); |
| 197 | }; |
| 198 | } |
| 199 | tr.addEventListener('click', f._handler, false); |
| 200 | }; |
| 201 |