Fossil SCM

Remove in-line JS from the /setup_skin page into the skin.js file.

drh 2017-12-06 21:11 trunk
Commit ca19f8b5d2bf6e67aed86228d56a8fb3141277eb8ca5107ac8543b08f4c93304
Parent 63fb653a7e943ae…
5 files changed +1 +8 +2 -1 +1 +1
~ src/main.mk + src/skin.js ~ src/skins.c ~ win/Makefile.mingw ~ win/Makefile.msc
M src/main.mk
+1
--- src/main.mk
+++ src/main.mk
@@ -200,10 +200,11 @@
200200
 $(SRCDIR)/href.js \
201201
 $(SRCDIR)/login.js \
202202
 $(SRCDIR)/markdown.md \
203203
 $(SRCDIR)/menu.js \
204204
 $(SRCDIR)/sbsdiff.js \
205
+ $(SRCDIR)/skin.js \
205206
 $(SRCDIR)/sorttable.js \
206207
 $(SRCDIR)/tree.js \
207208
 $(SRCDIR)/useredit.js \
208209
 $(SRCDIR)/wiki.wiki
209210
210211
211212
ADDED src/skin.js
--- src/main.mk
+++ src/main.mk
@@ -200,10 +200,11 @@
200 $(SRCDIR)/href.js \
201 $(SRCDIR)/login.js \
202 $(SRCDIR)/markdown.md \
203 $(SRCDIR)/menu.js \
204 $(SRCDIR)/sbsdiff.js \
 
205 $(SRCDIR)/sorttable.js \
206 $(SRCDIR)/tree.js \
207 $(SRCDIR)/useredit.js \
208 $(SRCDIR)/wiki.wiki
209
210
211 DDED src/skin.js
--- src/main.mk
+++ src/main.mk
@@ -200,10 +200,11 @@
200 $(SRCDIR)/href.js \
201 $(SRCDIR)/login.js \
202 $(SRCDIR)/markdown.md \
203 $(SRCDIR)/menu.js \
204 $(SRCDIR)/sbsdiff.js \
205 $(SRCDIR)/skin.js \
206 $(SRCDIR)/sorttable.js \
207 $(SRCDIR)/tree.js \
208 $(SRCDIR)/useredit.js \
209 $(SRCDIR)/wiki.wiki
210
211
212 DDED src/skin.js
A src/skin.js
+8
--- a/src/skin.js
+++ b/src/skin.js
@@ -0,0 +1,8 @@
1
+/* Javascript that runs for the /setup_skin page.
2
+*/
3
+(function(){
4
+ var x = document.getElementById('skStep1');
5
+ x.onchange = function(){
6
+ document.getElementById('f01').submit()
7
+ }
8
+}());
--- a/src/skin.js
+++ b/src/skin.js
@@ -0,0 +1,8 @@
 
 
 
 
 
 
 
 
--- a/src/skin.js
+++ b/src/skin.js
@@ -0,0 +1,8 @@
1 /* Javascript that runs for the /setup_skin page.
2 */
3 (function(){
4 var x = document.getElementById('skStep1');
5 x.onchange = function(){
6 document.getElementById('f01').submit()
7 }
8 }());
M src/skins.c
+2 -1
--- src/skins.c
+++ src/skins.c
@@ -915,11 +915,11 @@
915915
 @ be published to become the default skin.
916916
 @ Nine separate drafts are available to facilitate A/B testing.</p>
917917
 @
918918
 @ <form method='POST' action='%R/setup_skin#step2' id='f01'>
919919
 @ <p class='skinInput'>Draft skin to edit:
920
- @ <select size='1' name='sk' onchange='gebi("f01").submit()'>
920
+ @ <select size='1' name='sk' id='skStep1'>
921921
 for(i=1; i<=9; i++){
922922
 if( i==iSkin ){
923923
 @ <option value='%d(i)' selected>draft%d(i)</option>
924924
 }else{
925925
 @ <option value='%d(i)'>draft%d(i)</option>
@@ -1056,7 +1056,8 @@
10561056
 @ undo a prior publish
10571057
 }else{
10581058
 @ <p>Visit the <a href='%R/setup_skin_admin'>Skin Admin</a> page
10591059
 @ for cleanup and recovery actions.
10601060
 }
1061
+ style_load_one_js_file("skin.js");
10611062
 style_footer();
10621063
 }
10631064
--- src/skins.c
+++ src/skins.c
@@ -915,11 +915,11 @@
915 @ be published to become the default skin.
916 @ Nine separate drafts are available to facilitate A/B testing.</p>
917 @
918 @ <form method='POST' action='%R/setup_skin#step2' id='f01'>
919 @ <p class='skinInput'>Draft skin to edit:
920 @ <select size='1' name='sk' onchange='gebi("f01").submit()'>
921 for(i=1; i<=9; i++){
922 if( i==iSkin ){
923 @ <option value='%d(i)' selected>draft%d(i)</option>
924 }else{
925 @ <option value='%d(i)'>draft%d(i)</option>
@@ -1056,7 +1056,8 @@
1056 @ undo a prior publish
1057 }else{
1058 @ <p>Visit the <a href='%R/setup_skin_admin'>Skin Admin</a> page
1059 @ for cleanup and recovery actions.
1060 }
 
1061 style_footer();
1062 }
1063
--- src/skins.c
+++ src/skins.c
@@ -915,11 +915,11 @@
915 @ be published to become the default skin.
916 @ Nine separate drafts are available to facilitate A/B testing.</p>
917 @
918 @ <form method='POST' action='%R/setup_skin#step2' id='f01'>
919 @ <p class='skinInput'>Draft skin to edit:
920 @ <select size='1' name='sk' id='skStep1'>
921 for(i=1; i<=9; i++){
922 if( i==iSkin ){
923 @ <option value='%d(i)' selected>draft%d(i)</option>
924 }else{
925 @ <option value='%d(i)'>draft%d(i)</option>
@@ -1056,7 +1056,8 @@
1056 @ undo a prior publish
1057 }else{
1058 @ <p>Visit the <a href='%R/setup_skin_admin'>Skin Admin</a> page
1059 @ for cleanup and recovery actions.
1060 }
1061 style_load_one_js_file("skin.js");
1062 style_footer();
1063 }
1064
M win/Makefile.mingw
+1
--- win/Makefile.mingw
+++ win/Makefile.mingw
@@ -609,10 +609,11 @@
609609
 $(SRCDIR)/href.js \
610610
 $(SRCDIR)/login.js \
611611
 $(SRCDIR)/markdown.md \
612612
 $(SRCDIR)/menu.js \
613613
 $(SRCDIR)/sbsdiff.js \
614
+ $(SRCDIR)/skin.js \
614615
 $(SRCDIR)/sorttable.js \
615616
 $(SRCDIR)/tree.js \
616617
 $(SRCDIR)/useredit.js \
617618
 $(SRCDIR)/wiki.wiki
618619
619620
--- win/Makefile.mingw
+++ win/Makefile.mingw
@@ -609,10 +609,11 @@
609 $(SRCDIR)/href.js \
610 $(SRCDIR)/login.js \
611 $(SRCDIR)/markdown.md \
612 $(SRCDIR)/menu.js \
613 $(SRCDIR)/sbsdiff.js \
 
614 $(SRCDIR)/sorttable.js \
615 $(SRCDIR)/tree.js \
616 $(SRCDIR)/useredit.js \
617 $(SRCDIR)/wiki.wiki
618
619
--- win/Makefile.mingw
+++ win/Makefile.mingw
@@ -609,10 +609,11 @@
609 $(SRCDIR)/href.js \
610 $(SRCDIR)/login.js \
611 $(SRCDIR)/markdown.md \
612 $(SRCDIR)/menu.js \
613 $(SRCDIR)/sbsdiff.js \
614 $(SRCDIR)/skin.js \
615 $(SRCDIR)/sorttable.js \
616 $(SRCDIR)/tree.js \
617 $(SRCDIR)/useredit.js \
618 $(SRCDIR)/wiki.wiki
619
620
M win/Makefile.msc
+1
--- win/Makefile.msc
+++ win/Makefile.msc
@@ -535,10 +535,11 @@
535535
 $(SRCDIR)\href.js \
536536
 $(SRCDIR)\login.js \
537537
 $(SRCDIR)\markdown.md \
538538
 $(SRCDIR)\menu.js \
539539
 $(SRCDIR)\sbsdiff.js \
540
+ $(SRCDIR)\skin.js \
540541
 $(SRCDIR)\sorttable.js \
541542
 $(SRCDIR)\tree.js \
542543
 $(SRCDIR)\useredit.js \
543544
 $(SRCDIR)\wiki.wiki
544545
545546
--- win/Makefile.msc
+++ win/Makefile.msc
@@ -535,10 +535,11 @@
535 $(SRCDIR)\href.js \
536 $(SRCDIR)\login.js \
537 $(SRCDIR)\markdown.md \
538 $(SRCDIR)\menu.js \
539 $(SRCDIR)\sbsdiff.js \
 
540 $(SRCDIR)\sorttable.js \
541 $(SRCDIR)\tree.js \
542 $(SRCDIR)\useredit.js \
543 $(SRCDIR)\wiki.wiki
544
545
--- win/Makefile.msc
+++ win/Makefile.msc
@@ -535,10 +535,11 @@
535 $(SRCDIR)\href.js \
536 $(SRCDIR)\login.js \
537 $(SRCDIR)\markdown.md \
538 $(SRCDIR)\menu.js \
539 $(SRCDIR)\sbsdiff.js \
540 $(SRCDIR)\skin.js \
541 $(SRCDIR)\sorttable.js \
542 $(SRCDIR)\tree.js \
543 $(SRCDIR)\useredit.js \
544 $(SRCDIR)\wiki.wiki
545
546

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button