Fossil SCM

chat: seem to have eliminated the tiny dead-zone between the label and checkbox in the settings menu.

stephan 2020-12-27 18:29 trunk
Commit dc8f3a3692628ca342695ecf2398d94a7c42d3061d220c6d6662360e1c5c5217
1 file changed +1 -2
+1 -2
--- src/chat.js
+++ src/chat.js
@@ -830,14 +830,13 @@
830830
D.append(line, btn);
831831
if(op.hasOwnProperty('boolValue')){
832832
const check = D.attr(D.checkbox(1, op.boolValue()),
833833
'aria-label', op.label);
834834
D.append(line, check);
835
- check.addEventListener('click', callback);
836835
}
837836
D.append(settingsPopup.e, line);
838
- btn.addEventListener('click', callback);
837
+ line.addEventListener('click', callback);
839838
});
840839
};
841840
settingsPopup.installHideHandlers(false, true, true)
842841
/** Reminder: click-to-hide interferes with "?" embedded within
843842
the popup, so cannot be used together with those. Enabling
844843
--- src/chat.js
+++ src/chat.js
@@ -830,14 +830,13 @@
830 D.append(line, btn);
831 if(op.hasOwnProperty('boolValue')){
832 const check = D.attr(D.checkbox(1, op.boolValue()),
833 'aria-label', op.label);
834 D.append(line, check);
835 check.addEventListener('click', callback);
836 }
837 D.append(settingsPopup.e, line);
838 btn.addEventListener('click', callback);
839 });
840 };
841 settingsPopup.installHideHandlers(false, true, true)
842 /** Reminder: click-to-hide interferes with "?" embedded within
843 the popup, so cannot be used together with those. Enabling
844
--- src/chat.js
+++ src/chat.js
@@ -830,14 +830,13 @@
830 D.append(line, btn);
831 if(op.hasOwnProperty('boolValue')){
832 const check = D.attr(D.checkbox(1, op.boolValue()),
833 'aria-label', op.label);
834 D.append(line, check);
 
835 }
836 D.append(settingsPopup.e, line);
837 line.addEventListener('click', callback);
838 });
839 };
840 settingsPopup.installHideHandlers(false, true, true)
841 /** Reminder: click-to-hide interferes with "?" embedded within
842 the popup, so cannot be used together with those. Enabling
843

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button