Fossil SCM

Catch zero length early in blob_constant_time_eq().

dmitry 2011-09-30 09:41 dmitry-security
Commit e3d022dffae1c9de318eb7b8ab79a84fcc7b4997
1 file changed +1 -1
+1 -1
--- src/blob.c
+++ src/blob.c
@@ -328,11 +328,11 @@
328328
329329
blob_is_init(pA);
330330
blob_is_init(pB);
331331
szA = blob_size(pA);
332332
szB = blob_size(pB);
333
- if( szA!=szB ) return 1;
333
+ if( szA!=szB || szA==0 ) return 1;
334334
335335
buf1 = blob_buffer(pA);
336336
buf2 = blob_buffer(pB);
337337
338338
for( i=0; i<szA; i++ ){
339339
--- src/blob.c
+++ src/blob.c
@@ -328,11 +328,11 @@
328
329 blob_is_init(pA);
330 blob_is_init(pB);
331 szA = blob_size(pA);
332 szB = blob_size(pB);
333 if( szA!=szB ) return 1;
334
335 buf1 = blob_buffer(pA);
336 buf2 = blob_buffer(pB);
337
338 for( i=0; i<szA; i++ ){
339
--- src/blob.c
+++ src/blob.c
@@ -328,11 +328,11 @@
328
329 blob_is_init(pA);
330 blob_is_init(pB);
331 szA = blob_size(pA);
332 szB = blob_size(pB);
333 if( szA!=szB || szA==0 ) return 1;
334
335 buf1 = blob_buffer(pA);
336 buf2 = blob_buffer(pB);
337
338 for( i=0; i<szA; i++ ){
339

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button