Fossil SCM
Better hyperlinks on the security-audit warning about the server load average setting.
Commit
e5c0543760699390bc38a471dcdfdf64a26fcf449b8662e81ec7f9d12cb77319
Parent
5999d2446b6c43c…
2 files changed
+5
-4
+1
+5
-4
| --- src/security_audit.c | ||
| +++ src/security_audit.c | ||
| @@ -551,18 +551,19 @@ | ||
| 551 | 551 | if( r<=0.0 ){ |
| 552 | 552 | @ <li><p> |
| 553 | 553 | @ Load average limiting is turned off. This can cause the server |
| 554 | 554 | @ to bog down if many requests for expensive services (such as |
| 555 | 555 | @ large diffs or tarballs) arrive at about the same time. |
| 556 | - @ To fix this, set the "Server Load Average Limit" on the | |
| 557 | - @ <a href="setup_access">Access Control</a> page to approximately | |
| 556 | + @ To fix this, set the | |
| 557 | + @ <a href='%R/setup_access#slal'>"Server Load Average Limit"</a> on the | |
| 558 | + @ <a href='%R/setup_access'>Access Control</a> page to the approximate | |
| 558 | 559 | @ the number of available cores on your server, or maybe just a little |
| 559 | 560 | @ less. |
| 560 | 561 | }else if( r>=8.0 ){ |
| 561 | 562 | @ <li><p> |
| 562 | - @ The "Server Load Average Limit" on the | |
| 563 | - @ <a href="setup_access">Access Control</a> page is set to %g(r), | |
| 563 | + @ The <a href='%R/setup_access#slal'>"Server Load Average Limit"</a> on | |
| 564 | + @ the <a href="setup_access">Access Control</a> page is set to %g(r), | |
| 564 | 565 | @ which seems high. Is this server really a %d((int)r)-core machine? |
| 565 | 566 | } |
| 566 | 567 | } |
| 567 | 568 | #endif |
| 568 | 569 | |
| 569 | 570 |
| --- src/security_audit.c | |
| +++ src/security_audit.c | |
| @@ -551,18 +551,19 @@ | |
| 551 | if( r<=0.0 ){ |
| 552 | @ <li><p> |
| 553 | @ Load average limiting is turned off. This can cause the server |
| 554 | @ to bog down if many requests for expensive services (such as |
| 555 | @ large diffs or tarballs) arrive at about the same time. |
| 556 | @ To fix this, set the "Server Load Average Limit" on the |
| 557 | @ <a href="setup_access">Access Control</a> page to approximately |
| 558 | @ the number of available cores on your server, or maybe just a little |
| 559 | @ less. |
| 560 | }else if( r>=8.0 ){ |
| 561 | @ <li><p> |
| 562 | @ The "Server Load Average Limit" on the |
| 563 | @ <a href="setup_access">Access Control</a> page is set to %g(r), |
| 564 | @ which seems high. Is this server really a %d((int)r)-core machine? |
| 565 | } |
| 566 | } |
| 567 | #endif |
| 568 | |
| 569 |
| --- src/security_audit.c | |
| +++ src/security_audit.c | |
| @@ -551,18 +551,19 @@ | |
| 551 | if( r<=0.0 ){ |
| 552 | @ <li><p> |
| 553 | @ Load average limiting is turned off. This can cause the server |
| 554 | @ to bog down if many requests for expensive services (such as |
| 555 | @ large diffs or tarballs) arrive at about the same time. |
| 556 | @ To fix this, set the |
| 557 | @ <a href='%R/setup_access#slal'>"Server Load Average Limit"</a> on the |
| 558 | @ <a href='%R/setup_access'>Access Control</a> page to the approximate |
| 559 | @ the number of available cores on your server, or maybe just a little |
| 560 | @ less. |
| 561 | }else if( r>=8.0 ){ |
| 562 | @ <li><p> |
| 563 | @ The <a href='%R/setup_access#slal'>"Server Load Average Limit"</a> on |
| 564 | @ the <a href="setup_access">Access Control</a> page is set to %g(r), |
| 565 | @ which seems high. Is this server really a %d((int)r)-core machine? |
| 566 | } |
| 567 | } |
| 568 | #endif |
| 569 | |
| 570 |
+1
| --- src/setup.c | ||
| +++ src/setup.c | ||
| @@ -447,10 +447,11 @@ | ||
| 447 | 447 | @ the out-bound data of sync, clone, and pull packets. |
| 448 | 448 | @ If the client request takes longer, a partial reply is given similar |
| 449 | 449 | @ to the download packet limit. 30s is a reasonable default. |
| 450 | 450 | @ (Property: "max-download-time")</p> |
| 451 | 451 | |
| 452 | + @ <a id="slal"></a> | |
| 452 | 453 | @ <hr /> |
| 453 | 454 | entry_attribute("Server Load Average Limit", 11, "max-loadavg", "mxldavg", |
| 454 | 455 | "0.0", 0); |
| 455 | 456 | @ <p>Some expensive operations (such as computing tarballs, zip archives, |
| 456 | 457 | @ or annotation/blame pages) are prohibited if the load average on the host |
| 457 | 458 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -447,10 +447,11 @@ | |
| 447 | @ the out-bound data of sync, clone, and pull packets. |
| 448 | @ If the client request takes longer, a partial reply is given similar |
| 449 | @ to the download packet limit. 30s is a reasonable default. |
| 450 | @ (Property: "max-download-time")</p> |
| 451 | |
| 452 | @ <hr /> |
| 453 | entry_attribute("Server Load Average Limit", 11, "max-loadavg", "mxldavg", |
| 454 | "0.0", 0); |
| 455 | @ <p>Some expensive operations (such as computing tarballs, zip archives, |
| 456 | @ or annotation/blame pages) are prohibited if the load average on the host |
| 457 |
| --- src/setup.c | |
| +++ src/setup.c | |
| @@ -447,10 +447,11 @@ | |
| 447 | @ the out-bound data of sync, clone, and pull packets. |
| 448 | @ If the client request takes longer, a partial reply is given similar |
| 449 | @ to the download packet limit. 30s is a reasonable default. |
| 450 | @ (Property: "max-download-time")</p> |
| 451 | |
| 452 | @ <a id="slal"></a> |
| 453 | @ <hr /> |
| 454 | entry_attribute("Server Load Average Limit", 11, "max-loadavg", "mxldavg", |
| 455 | "0.0", 0); |
| 456 | @ <p>Some expensive operations (such as computing tarballs, zip archives, |
| 457 | @ or annotation/blame pages) are prohibited if the load average on the host |
| 458 |