Fossil SCM
Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty <a href="#"> link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition.
Commit
e806e5c4df71f2e998e9524ba4237d39e95a6b1befa9ba8e5ae78efd33048c26
Parent
d7c43c5aa7761cb…
1 file changed
+1
| --- skins/default/footer.txt | ||
| +++ skins/default/footer.txt | ||
| @@ -32,8 +32,9 @@ | ||
| 32 | 32 | }); |
| 33 | 33 | } |
| 34 | 34 | else { |
| 35 | 35 | showPanel(); // just show what we built above |
| 36 | 36 | } |
| 37 | + return false; // prevent browser from acting on <a> click | |
| 37 | 38 | }); |
| 38 | 39 | })(); |
| 39 | 40 | </script> |
| 40 | 41 |
| --- skins/default/footer.txt | |
| +++ skins/default/footer.txt | |
| @@ -32,8 +32,9 @@ | |
| 32 | }); |
| 33 | } |
| 34 | else { |
| 35 | showPanel(); // just show what we built above |
| 36 | } |
| 37 | }); |
| 38 | })(); |
| 39 | </script> |
| 40 |
| --- skins/default/footer.txt | |
| +++ skins/default/footer.txt | |
| @@ -32,8 +32,9 @@ | |
| 32 | }); |
| 33 | } |
| 34 | else { |
| 35 | showPanel(); // just show what we built above |
| 36 | } |
| 37 | return false; // prevent browser from acting on <a> click |
| 38 | }); |
| 39 | })(); |
| 40 | </script> |
| 41 |