Fossil SCM

The periodic "updateClock()" call made in the header for several of the built-in skins (Eagle, Enhanced1, and Xekri) violates the new stricter CSP, since it requires a JS eval. We don't need an eval here: we can pass the function's name literally to window.setTimeout instead, which treats it as a Function object, which doesn't need to be eval'd.

wyoung 2018-08-11 20:49 trunk
Commit eac15b4c63321d173124786259fb5d6d77a2e2b1c4e50618123efff5cfaf2428
--- skins/eagle/header.txt
+++ skins/eagle/header.txt
@@ -84,11 +84,11 @@
8484
e.innerHTML = d.getUTCFullYear()+ '-' +
8585
f(d.getUTCMonth() + 1) + '-' +
8686
f(d.getUTCDate()) + ' ' +
8787
f(d.getUTCHours()) + ':' +
8888
f(d.getUTCMinutes());
89
- setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
89
+ setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
9090
}
9191
}
9292
updateClock();
9393
</script>
9494
<div class="mainmenu">
9595
--- skins/eagle/header.txt
+++ skins/eagle/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95
--- skins/eagle/header.txt
+++ skins/eagle/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95
--- skins/enhanced1/header.txt
+++ skins/enhanced1/header.txt
@@ -84,11 +84,11 @@
8484
e.innerHTML = d.getUTCFullYear()+ '-' +
8585
f(d.getUTCMonth() + 1) + '-' +
8686
f(d.getUTCDate()) + ' ' +
8787
f(d.getUTCHours()) + ':' +
8888
f(d.getUTCMinutes());
89
- setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
89
+ setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
9090
}
9191
}
9292
updateClock();
9393
</script>
9494
<div class="mainmenu">
9595
--- skins/enhanced1/header.txt
+++ skins/enhanced1/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95
--- skins/enhanced1/header.txt
+++ skins/enhanced1/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95
--- skins/xekri/header.txt
+++ skins/xekri/header.txt
@@ -84,11 +84,11 @@
8484
e.innerHTML = d.getUTCFullYear()+ '-' +
8585
f(d.getUTCMonth() + 1) + '-' +
8686
f(d.getUTCDate()) + ' ' +
8787
f(d.getUTCHours()) + ':' +
8888
f(d.getUTCMinutes());
89
- setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
89
+ setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
9090
}
9191
}
9292
updateClock();
9393
</script>
9494
<div class="mainmenu">
9595
--- skins/xekri/header.txt
+++ skins/xekri/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout("updateClock();",(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95
--- skins/xekri/header.txt
+++ skins/xekri/header.txt
@@ -84,11 +84,11 @@
84 e.innerHTML = d.getUTCFullYear()+ '-' +
85 f(d.getUTCMonth() + 1) + '-' +
86 f(d.getUTCDate()) + ' ' +
87 f(d.getUTCHours()) + ':' +
88 f(d.getUTCMinutes());
89 setTimeout(updateClock,(60-d.getUTCSeconds())*1000);
90 }
91 }
92 updateClock();
93 </script>
94 <div class="mainmenu">
95

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button