Fossil SCM

Revise test result summary to include 'ignored' results from tests marked with 'knownBug'.

mistachkin 2016-01-27 01:55 trunk
Commit f77fbed8e306e22ead8e50d6c525e212f6e699b5
1 file changed +12 -3
+12 -3
--- test/tester.tcl
+++ test/tester.tcl
@@ -336,11 +336,11 @@
336336
337337
# Perform a test
338338
#
339339
set test_count 0
340340
proc test {name expr {constraints ""}} {
341
- global bad_test test_count RESULT
341
+ global bad_test ignored_test test_count RESULT
342342
incr test_count
343343
set knownBug [expr {"knownBug" in $constraints}]
344344
set r [uplevel 1 [list expr $expr]]
345345
if {$r} {
346346
if {$knownBug && !$::STRICT} {
@@ -349,19 +349,21 @@
349349
protOut "test $name OK"
350350
}
351351
} else {
352352
if {$knownBug && !$::STRICT} {
353353
protOut "test $name FAILED (knownBug)!" 1
354
+ lappend ignored_test $name
354355
} else {
355356
protOut "test $name FAILED!" 1
356357
if {$::QUIET} {protOut "RESULT: $RESULT" 1}
357358
lappend bad_test $name
358359
if {$::HALT} exit
359360
}
360361
}
361362
}
362363
set bad_test {}
364
+set ignored_test {}
363365
364366
# Return a random string N characters long.
365367
#
366368
set vocabulary 01234567890abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
367369
append vocabulary " ()*^!.eeeeeeeeaaaaattiioo "
@@ -511,10 +513,17 @@
511513
protOut "***** End of $testfile: [llength $bad_test] errors so far ******"
512514
cd $origwd
513515
}
514516
set nErr [llength $bad_test]
515517
if {$nErr>0 || !$::QUIET} {
516
- protOut "***** Final result: $nErr errors out of $test_count tests" 1
518
+ protOut "***** Final results: $nErr errors out of $test_count tests" 1
519
+}
520
+if {$nErr>0} {
521
+ protOut "***** Considered failures: $bad_test" 1
522
+}
523
+set nErr [llength $ignored_test]
524
+if {$nErr>0 || !$::QUIET} {
525
+ protOut "***** Ignored results: $nErr ignored errors out of $test_count tests" 1
517526
}
518527
if {$nErr>0} {
519
- protOut "***** Failures: $bad_test" 1
528
+ protOut "***** Ignored failures: $ignored_test" 1
520529
}
521530
--- test/tester.tcl
+++ test/tester.tcl
@@ -336,11 +336,11 @@
336
337 # Perform a test
338 #
339 set test_count 0
340 proc test {name expr {constraints ""}} {
341 global bad_test test_count RESULT
342 incr test_count
343 set knownBug [expr {"knownBug" in $constraints}]
344 set r [uplevel 1 [list expr $expr]]
345 if {$r} {
346 if {$knownBug && !$::STRICT} {
@@ -349,19 +349,21 @@
349 protOut "test $name OK"
350 }
351 } else {
352 if {$knownBug && !$::STRICT} {
353 protOut "test $name FAILED (knownBug)!" 1
 
354 } else {
355 protOut "test $name FAILED!" 1
356 if {$::QUIET} {protOut "RESULT: $RESULT" 1}
357 lappend bad_test $name
358 if {$::HALT} exit
359 }
360 }
361 }
362 set bad_test {}
 
363
364 # Return a random string N characters long.
365 #
366 set vocabulary 01234567890abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
367 append vocabulary " ()*^!.eeeeeeeeaaaaattiioo "
@@ -511,10 +513,17 @@
511 protOut "***** End of $testfile: [llength $bad_test] errors so far ******"
512 cd $origwd
513 }
514 set nErr [llength $bad_test]
515 if {$nErr>0 || !$::QUIET} {
516 protOut "***** Final result: $nErr errors out of $test_count tests" 1
 
 
 
 
 
 
 
517 }
518 if {$nErr>0} {
519 protOut "***** Failures: $bad_test" 1
520 }
521
--- test/tester.tcl
+++ test/tester.tcl
@@ -336,11 +336,11 @@
336
337 # Perform a test
338 #
339 set test_count 0
340 proc test {name expr {constraints ""}} {
341 global bad_test ignored_test test_count RESULT
342 incr test_count
343 set knownBug [expr {"knownBug" in $constraints}]
344 set r [uplevel 1 [list expr $expr]]
345 if {$r} {
346 if {$knownBug && !$::STRICT} {
@@ -349,19 +349,21 @@
349 protOut "test $name OK"
350 }
351 } else {
352 if {$knownBug && !$::STRICT} {
353 protOut "test $name FAILED (knownBug)!" 1
354 lappend ignored_test $name
355 } else {
356 protOut "test $name FAILED!" 1
357 if {$::QUIET} {protOut "RESULT: $RESULT" 1}
358 lappend bad_test $name
359 if {$::HALT} exit
360 }
361 }
362 }
363 set bad_test {}
364 set ignored_test {}
365
366 # Return a random string N characters long.
367 #
368 set vocabulary 01234567890abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
369 append vocabulary " ()*^!.eeeeeeeeaaaaattiioo "
@@ -511,10 +513,17 @@
513 protOut "***** End of $testfile: [llength $bad_test] errors so far ******"
514 cd $origwd
515 }
516 set nErr [llength $bad_test]
517 if {$nErr>0 || !$::QUIET} {
518 protOut "***** Final results: $nErr errors out of $test_count tests" 1
519 }
520 if {$nErr>0} {
521 protOut "***** Considered failures: $bad_test" 1
522 }
523 set nErr [llength $ignored_test]
524 if {$nErr>0 || !$::QUIET} {
525 protOut "***** Ignored results: $nErr ignored errors out of $test_count tests" 1
526 }
527 if {$nErr>0} {
528 protOut "***** Ignored failures: $ignored_test" 1
529 }
530

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button