Fossil SCM
For the previous check-in, disable the submit button rather than use alert().
Commit
fe24713a27cc4d0a17057c3a26593c1a36b27d93223c4d990ad2a344b1b5f455
Parent
4a8a7742da82064…
1 file changed
+6
-5
+6
-5
| --- src/unversioned.c | ||
| +++ src/unversioned.c | ||
| @@ -563,17 +563,18 @@ | ||
| 563 | 563 | CX("<div>Added: %h</div>", zName); |
| 564 | 564 | } |
| 565 | 565 | form_begin("enctype='multipart/form-data'", "%R/uvlist"); |
| 566 | 566 | @ <label for='uvupload'>Upload unversioned file:</label> |
| 567 | 567 | @ <input type='file' id='uvupload' name='f'/> |
| 568 | - @ <input type='submit' id='uvsubmit' value='Upload'/> | |
| 568 | + @ <input type='submit' id='uvsubmit' value='Upload' disabled='disabled'/> | |
| 569 | 569 | @ </form> |
| 570 | 570 | @ <script nonce='%h(style_nonce())'>;/* unversioned.c:%d(__LINE__) */ |
| 571 | - @ document.getElementById('uvsubmit').onclick = function(){ | |
| 572 | - @ var bNofile = !document.getElementById('uvupload').value; | |
| 573 | - @ if (bNofile) alert('Please select a file'); | |
| 574 | - @ return !bNofile; | |
| 571 | + @ var upl = document.getElementById('uvupload'); | |
| 572 | + @ var sbm = document.getElementById('uvsubmit'); | |
| 573 | + @ upl.onchange = function(){ | |
| 574 | + @ if (!upl.value) sbm.setAttribute('disabled', 'disabled'); | |
| 575 | + @ else sbm.removeAttribute('disabled'); | |
| 575 | 576 | @ } |
| 576 | 577 | @ </script> |
| 577 | 578 | } |
| 578 | 579 | |
| 579 | 580 | /* |
| 580 | 581 |
| --- src/unversioned.c | |
| +++ src/unversioned.c | |
| @@ -563,17 +563,18 @@ | |
| 563 | CX("<div>Added: %h</div>", zName); |
| 564 | } |
| 565 | form_begin("enctype='multipart/form-data'", "%R/uvlist"); |
| 566 | @ <label for='uvupload'>Upload unversioned file:</label> |
| 567 | @ <input type='file' id='uvupload' name='f'/> |
| 568 | @ <input type='submit' id='uvsubmit' value='Upload'/> |
| 569 | @ </form> |
| 570 | @ <script nonce='%h(style_nonce())'>;/* unversioned.c:%d(__LINE__) */ |
| 571 | @ document.getElementById('uvsubmit').onclick = function(){ |
| 572 | @ var bNofile = !document.getElementById('uvupload').value; |
| 573 | @ if (bNofile) alert('Please select a file'); |
| 574 | @ return !bNofile; |
| 575 | @ } |
| 576 | @ </script> |
| 577 | } |
| 578 | |
| 579 | /* |
| 580 |
| --- src/unversioned.c | |
| +++ src/unversioned.c | |
| @@ -563,17 +563,18 @@ | |
| 563 | CX("<div>Added: %h</div>", zName); |
| 564 | } |
| 565 | form_begin("enctype='multipart/form-data'", "%R/uvlist"); |
| 566 | @ <label for='uvupload'>Upload unversioned file:</label> |
| 567 | @ <input type='file' id='uvupload' name='f'/> |
| 568 | @ <input type='submit' id='uvsubmit' value='Upload' disabled='disabled'/> |
| 569 | @ </form> |
| 570 | @ <script nonce='%h(style_nonce())'>;/* unversioned.c:%d(__LINE__) */ |
| 571 | @ var upl = document.getElementById('uvupload'); |
| 572 | @ var sbm = document.getElementById('uvsubmit'); |
| 573 | @ upl.onchange = function(){ |
| 574 | @ if (!upl.value) sbm.setAttribute('disabled', 'disabled'); |
| 575 | @ else sbm.removeAttribute('disabled'); |
| 576 | @ } |
| 577 | @ </script> |
| 578 | } |
| 579 | |
| 580 | /* |
| 581 |