<div style="clear: both"> is really necessary?

Fixed

1b41304d8b7acfc… · opened 15 years, 6 months ago

Type: Code_Defect
Priority: —
Severity: Cosmetic
Resolution: Fixed
Subsystem: —
Created: Sept. 28, 2010 7:11 a.m.

in the very end of page somehow restricts skinning of fossil. What is the goal of having this. Shouldn't it be just div#footer { clear: both; } property in CSS?

wolfgang added on 2010-09-28 08:22:06:
clear both is needed on pages with info boxes(branch,..):

style.c:
  /* Put the footer at the bottom of the page.
  ** the additional clear/both is needed to extend the content
  ** part to the end of an optional sidebox.
  */

This is added INSIDE the conten area. I'll try to move this to the footer style. This will require edits on all existing footers, because this has to be added to the footer style definition in the configured CSS.

wolfgang added on 2010-09-28 08:32:05:
should be solved with checkin [15b3ad2509] on branch wolfgangFormat2CSS_2. The css definition for div.footer has to be extended with clear: both;, otherwisse sideboxes on some pages(branch,..) will not extend the content area.

wolfgang added on 2010-09-28 08:46:24:
the display is not ok, if background color of the entirre page is different from the one, used for the content div. The siddebox maybe higher than the content area. So i'll try to move the clear:both back to the content area. Maybe i'll use a empty span with an own class definition.

wolfgang added on 2010-09-29 17:14:21:
on trunk: clear:both is only on pages using sideboxes

Fossil SCM

<div style="clear: both"> is really necessary?

Keyboard Shortcuts