Fossil SCM

"fossil patch push" for a merge with resolved conflicts does not work

Fixed

21037bfc1296dab… · opened 3 years, 5 months ago

Type
Code_Defect
Priority
Medium
Severity
Important
Resolution
Fixed
Subsystem
Created
Nov. 4, 2022 6:31 p.m.

Scenario:

  • Do "fossil merge $BRANCH" on the local machine.
  • Resolve minor merge conflicts
  • "fossil patch push $REMOTE"
  • ssh $REMOTE

The local changes that were entered after the merge to resolve the merge conflicts are not copied over to the remote side.

Here is a specific test case associated with the SQLite project:

  • "fossil up ba2539f6dee1fff"
  • "fossil merge c1c47eff48e0831b"
  • Resolve merge conflicts in Makefile.in and src/shell.c.in
  • "fossil push $REMOTE"

Comments (4)

drh 3 years, 5 months ago

Scenario:

  • Do "fossil merge $BRANCH" on the local machine.
  • Resolve minor merge conflicts
  • "fossil patch push $REMOTE"
  • ssh $REMOTE

The local changes that were entered after the merge to resolve the merge conflicts are not copied over to the remote side.

Here is a specific test case associated with the SQLite project:

  • "fossil up ba2539f6dee1fff"
  • "fossil merge c1c47eff48e0831b"
  • Resolve merge conflicts in Makefile.in and src/shell.c.in
  • "fossil push $REMOTE"
drh 3 years, 5 months ago

I have entered this ticket to record the issue. My intent is to fix it after the 2.20 release. It is not a rush.

drh 3 years, 4 months ago

The problem seems to arise because the merge did file renames, and that confuses the "patch apply" subprocess.

drh 3 years, 3 months ago

You can see the merge that causes the problem at the top of the change graph in https://sqlite.org/src/vdiff?diff=0&from=ba2539f6dee1fff4&to=c1c47eff48e0831b

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button