Fossil SCM
Revert's error handling is suboptimal.
Fixed
36d5fbf9a41c53e…
· opened 16 years, 5 months ago
- Type
- Code_Defect
- Priority
- —
- Severity
- Minor
- Resolution
- Fixed
- Subsystem
- —
- Created
- Oct. 25, 2009 1:47 p.m.
This command line fails quietly:
michael@isolde:~/junk/test$ fossil revert f6eb797b4f 3
revert file '3'? this will destroy local changes [y/N]? y
Of course I really was meant to put a -r in front of the revision number, but the complete absence of any kind of error message (like "file f6eb797b4f not in repository", say) kind of disguised my error. It may be better if Fossil flags an attempt to revert a file that doesn't exist.
eric added on 2009-10-27 20:10:16:
fossil revert only reverts one file. After getting the valid options and checking for any remaining (invalid) options, it just processes the last argument, ignoring any others. Maybe what it needs is a way to detect any excess arguments.
drh added on 2009-10-31 13:13:44:
Check-in [107f38dd014ae469dcac1f3e1c4fb230ffdc7d71]