Fossil SCM

i18n for filenames

Fixed

5317b79552cc460… · opened 16 years, 6 months ago

Type
Code_Defect
Priority
Severity
Severe
Resolution
Fixed
Subsystem
Created
Sept. 24, 2009 1:20 p.m.

When I run "fossil.exe add dir" under Windows, fossil recursively adding all files. If there are files with non-ascii names (Russian in my case), they inserted into fossil repo using system default encoding ('windows-1251' in Windows with Russian locale), and fossil works with them w/o problems. But in the web-interface on the files page (/dir) these files shown with unreadable names. This is because of UTF-8 fprintf(g.httpOut, "Content-Type: %s; charset=utf-8\r\n", zContentType); in the HTTP reply header (cgi.c).

Please delete "; charset=utf-8" part from Content-Type header because there no CP convertor in the fossil. This will allow to set any charset in the META tags in the page header template and use browser's internal CP convertor or CP autodetector.

This will also solve a problem from the ticket [d23fb0b742ac2e989e36bfef98281f970ab34e8f], I think.


drh added on 2009-09-24 14:32:43:
The fossil repository should store all filenames as UTF8. I think the bug here is that the "fossil add" command is not converting the names from the microsoft encoding into UTF8 before storing them.

Comments (1)

jan.nijtmans 13 years, 4 months ago

Should be fixed in 1.25

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button