Fossil SCM

Windows compile (MSVC makefile) broken regarding OpenSSL

Closed

5b2300c692845df… · opened 13 years ago

Type
Build_Problem
Priority
Medium
Severity
Important
Resolution
Fixed
Subsystem
Created
April 1, 2013 7:39 p.m.

As part of checkin [7ef7284d6b9], which added the zlib sources directly to the fossil sources, the line containing the "MSCDIR = c:\msc" definition was removed in "win/Makefile.msc", and the definition of the header and library inclusion paths "INCL" and "LIBDIR" a few lines later were adapted as well.

These changes are understandable if you consider only zlib, but the comment in the line before the MSCDIR definition mentioned that it is also used for SSL support. If one wants to compile fossil with SSL support, a setup as described here has to be used:

http://www.fossil-scm.org/fossil/wiki?name=compillingOnWindows (By the way, shouldn't this be only one "l" in "compiling"? Can't edit the name of the wiki page itself, only its contents)

These instructions are not valid anymore now with regard to OpenSSL!

Instead of each user manually adding the correct paths to the OpenSSL headers (INCL) and libraries (LIBDIR) and merging these fixes on each "fossil update", the cleaner and better solution to handle such additional external code would be to get back the separate MSCDIR definition and the usage of "(MSCDIR)\extra\include" or "(MSCDIR)\extra\libraries" for INCL resp. LIBDIR.

Comments (2)

nobody 13 years ago

As part of checkin [7ef7284d6b9], which added the zlib sources directly to the fossil sources, the line containing the "MSCDIR = c:\msc" definition was removed in "win/Makefile.msc", and the definition of the header and library inclusion paths "INCL" and "LIBDIR" a few lines later were adapted as well.

These changes are understandable if you consider only zlib, but the comment in the line before the MSCDIR definition mentioned that it is also used for SSL support. If one wants to compile fossil with SSL support, a setup as described here has to be used:

http://www.fossil-scm.org/fossil/wiki?name=compillingOnWindows (By the way, shouldn't this be only one "l" in "compiling"? Can't edit the name of the wiki page itself, only its contents)

These instructions are not valid anymore now with regard to OpenSSL!

Instead of each user manually adding the correct paths to the OpenSSL headers (INCL) and libraries (LIBDIR) and merging these fixes on each "fossil update", the cleaner and better solution to handle such additional external code would be to get back the separate MSCDIR definition and the usage of "(MSCDIR)\extra\include" or "(MSCDIR)\extra\libraries" for INCL resp. LIBDIR.

mistachkin 13 years ago

Fixed on trunk by check-in [c46e5f933d]. The wiki page is still incorrect.

To compile with OpenSSL enabled using MSVC, uncomment this line:

FOSSIL_ENABLE_SSL = 1

Prior to doing this, follow the OpenSSL instructions for building it with MSVC.

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button