Fossil SCM
html tags are apparently not escaped or converted when presented via timeline.rss
83e9e0016b65721…
· opened 16 years, 3 months ago
- Type
- Feature_Request
- Priority
- —
- Severity
- Important
- Resolution
- Rejected
- Subsystem
- —
- Created
- Jan. 10, 2010 12:46 a.m.
A fossil commit with a comment such as the following,
Note that couchdb document field names are now contained in priv/project.conf file. The strings within the <<>> are the names which should be used in html documents, e.g. <<"_id">> or <<"iata_code">> and the name to POST from a form would be "_id" or "iata_code" respectively.
will break my RSS reader when I read timeline.rss ; though I use liferea on GNU/Linux, I believe (though do not know) that illegal XML is being presented by timeline.rss by not escaping or encoding html tags and characters. For the above comment, liferea says that <<>> is an invalid element name. I can easily cause breakage by simply adding a commit comment such as
bugfix, added the opening <h1> tag in widget.html
in which case the RSS reader complains about an open tag with no closing tag. I then have to wait 20 new commits for the "bad" comment to roll out of the timeline.rss data before I can again read the fossil feed in my RSS reader.
NOTE that I wrote the above tag using encoded less than and greater than signs so that I could create this bug report. I cannot expect my fossil users (nor myself) to remember to write out ampersand g t ; etc. whenver an html tag is referenced in a commit comment.
Click edit for this report to see the actual text to which I am referring regarding "encoded less than and greater than signs".
My feature request is that timeline.rss present valid parseable XML atom or RSS data.
anonymous claiming to be Michael McDaniel added on 2010-01-22 16:02:36:
Single tag in commit comment still breaks timeline.rss xml feed; note that in this ticket addendum I wrote the html encoded list tag using "&" "lt" ";" otherwise when reading the ticket it is misleading. I cannot expect my users to html encode their comments (myself included).
I committed my project with comment
"... and fixed the misplaced <li> from previous checkin"
and have RSS reader error
XML Parser: Could not parse document: Entity: line 10: parser error :
Opening and ending tag mismatch: li line 10 and title
<title>... and fixed the misplaced <li> from previous checkin</title>
Entity: line 12:
If I remembered C well enough (I don't) I would dig in to the code.
Comments (1)
Closing ticket due to lack of any report to this effect from the past 10+ years. It's presumably been resolved since then. If not, please report it in the forum.