Fossil SCM

fossil init test fossil open test echo. > a.Txt fossil add . fossil commit -m test

ren a.Txt a.txt

fossil add . => ADDED a.txt which is ok.

fossil add . => ADDED a.txt "a.txt" will be mentionned everytime from now on.

This occurs because file names are case sensitive. Execute this command:

fossil rename a.Txt a.txt

and you will see this problem disappear.

Thanks for the info.

But under Linux, change the case of an existing file and it will only be added once. Which is ok.

Under Windows, it keeps getting added everytime. Which would make me think there is some case-related issue under Windows.

Even though it's a minor bug, I think I found the cause. See [d0764530d3] for the suggested fix.

The function vfile_scan() is documented to "Omit files named in VFILE", but this is not done case-insensitive on Windows. This also means that "fossil extras" and "fossil clean" need the --case-sensitive option, just like "fossil add" and "fossil addremove".

Please evaluate. Does this change have any side-effects I didn't think of?

Thank you for the patch. I have made a few tests and it seems to work fine.

Sorry to ask, but is this ok in add_cmd() ?

if( caseSensitive ){ db_multi_exec( "CREATE INDEX IF NOT EXISTS vfile_pathname " " ON vfile(pathname COLLATE nocase)" );

}

Fixed on trunk now.

Sorry to ask, but is this ok in add_cmd() ?

Yes, I think it is: The index is only needed when case-sensitive is off. On Windows, "case-sensitive" should be always off, on Cygwin it should be switchable (which is done in [9359b41fd5]), but that's unrelated to this buglet.

Sorry to ask, but is this ok in add_cmd() ?

Oops, you are right: the if expression should be opposite! Thanks for catching this!

Fixed now