Fossil SCM
Multiple notifications to a single ticket change
ad9aa572e7972f5…
· opened 3 years, 5 months ago
- Type
- Code_Defect
- Priority
- Immediate
- Severity
- Important
- Resolution
- Fixed
- Subsystem
- —
- Created
- Nov. 11, 2022 1:33 p.m.
A simple change to SQLite ticket 6c266900a22574d4 on 2022-11-11 13:17 generated four separate notification messages, and four chat entries from the chat robot. The change was just closing the ticket. The text of the notification email is shown below.
The desired behavior is a single notification for a single ticket change.
This happened while the server that sent the notifications was running Fossil 2.20 10d7174847 2022-11-04 18:02:25
This is an automated email sent by the Fossil repository at https://sqlite.org/src to report changes.
== 2013-01-02 00:08:44 Ticket Change ==
New ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i>. (user: anonymous)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2013-01-02 04:46:12 Ticket Change ==
Ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> status still Open with 5 other changes (user: anonymous)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2014-03-11 12:44:44 Ticket Change ==
Ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> status still Open with 3 other changes (user: drh)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2022-11-11 13:17:24 Ticket Change ==
Fixed ticket [6c266900](/6c266900a22574d4): <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> plus 4 other changes (user: drh)
https://sqlite.org/src/info/6c266900a22574d4d647
Comments (3)
A simple change to SQLite ticket 6c266900a22574d4 on 2022-11-11 13:17 generated four separate notification messages, and four chat entries from the chat robot. The change was just closing the ticket. The text of the notification email is shown below.
The desired behavior is a single notification for a single ticket change.
This happened while the server that sent the notifications was running Fossil 2.20 10d7174847 2022-11-04 18:02:25
This is an automated email sent by the Fossil repository at https://sqlite.org/src to report changes.
== 2013-01-02 00:08:44 Ticket Change ==
New ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i>. (user: anonymous)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2013-01-02 04:46:12 Ticket Change ==
Ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> status still Open with 5 other changes (user: anonymous)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2014-03-11 12:44:44 Ticket Change ==
Ticket [6c266900](/6c266900a22574d4) <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> status still Open with 3 other changes (user: drh)
https://sqlite.org/src/info/6c266900a22574d4d647
== 2022-11-11 13:17:24 Ticket Change ==
Fixed ticket [6c266900](/6c266900a22574d4): <i>shell: The column mode (and width option) does not manage correctly UTF-8</i> plus 4 other changes (user: drh)
https://sqlite.org/src/info/6c266900a22574d4d647
Another example of multiple notifications from a single change (again in the SQLite repository) at https://sqlite.org/src/artifact/c40bea505015e604. The notification text is shown below.
This is an automated email sent by the Fossil repository at https://sqlite.org/src to report changes.
== 2009-10-11 06:43:09 Ticket Change ==
New ticket [ee4b2b48](/ee4b2b48f5080f7e) <i>Prepared statement cache</i>. (user: rogerb)
https://sqlite.org/src/info/ee4b2b48f5080f7eaead
== 2009-10-11 07:36:09 Ticket Change ==
Ticket [ee4b2b48](/ee4b2b48f5080f7e) <i>Prepared statement cache</i> status still Open with 4 other changes (user: rogerb)
https://sqlite.org/src/info/ee4b2b48f5080f7eaead
== 2013-12-31 15:24:44 Ticket Change ==
Ticket [ee4b2b48](/ee4b2b48f5080f7e) <i>Prepared statement cache</i> status still Open with 3 other changes (user: anonymous)
https://sqlite.org/src/info/ee4b2b48f5080f7eaead
** Pending moderator approval (https://sqlite.org/src/modreq) **
== 2013-12-31 18:29:27 Ticket Change ==
Ticket [ee4b2b48](/ee4b2b48f5080f7e) <i>Prepared statement cache</i> status still Open with 4 other changes (user: anonymous)
https://sqlite.org/src/info/ee4b2b48f5080f7eaead
** Pending moderator approval (https://sqlite.org/src/modreq) **
== 2022-11-11 13:51:34 Ticket Change ==
Closed ticket [ee4b2b48](/ee4b2b48f5080f7e): <i>Prepared statement cache</i> plus 5 other changes (user: drh)
https://sqlite.org/src/info/ee4b2b48f5080f7eaead
Whenever a ticket changes, all changes to the ticket are rescanned. But we should only issue notifications for new changes. Accomplish this by running an UPDATE on the EVENT table for preexisting changes, rather than a REPLACE. Check-in fb040bb01326181e.