Fossil SCM
url_parse passes paths through mprintf, breaking % encoding (thus ~ too)
Fixed
c198af688022e37…
· opened 15 years, 11 months ago
- Type
- Code_Defect
- Priority
- —
- Severity
- Severe
- Resolution
- Fixed
- Subsystem
- —
- Created
- May 12, 2010 2:56 p.m.
fossil test-urlparser http://donkey.vernier.se/~fossil/picmidi
correctly parses and generates http://donkey.vernier.se/%7Efossil/picmidi, which is stored in the fossil.
On loading the remote-url for sync, pull, push, or merely display, this is passed through url_parse again, with devastating results:
fossil test-urlparser http://donkey.vernier.se/%7Efossil/picmidi
g.urlPath = /-1.094057E-02fossil/picmidi
I believe the failing line is in src/url.c:
g.urlPath = mprintf(&zUrl[i]);
anonymous added on 2010-09-23 02:02:45: Fixed in [a203674aa54063b166fe5999dd55c0443ed3f717], although never acknowledged.